Skip to content

Commit 71c7a0d

Browse files
jeraderjerader
committed
fix(step-generation): remove unneeded dispense after airGapInPlace
closes RQA-3913
1 parent 698bd4b commit 71c7a0d

File tree

4 files changed

+2
-350
lines changed

4 files changed

+2
-350
lines changed

‎step-generation/src/__tests__/distribute.test.ts

Lines changed: 0 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import {
2222
makeAspirateHelper,
2323
makeContext,
2424
makeDispenseHelper,
25-
makeDispenseAirGapHelper,
2625
makeTouchTipHelper,
2726
pickUpTipHelper,
2827
SOURCE_LABWARE,
@@ -37,16 +36,6 @@ import {
3736
DEST_WELL_BLOWOUT_DESTINATION,
3837
} from '../utils/misc'
3938

40-
const dispenseAirGapHelper = makeDispenseAirGapHelper({
41-
wellLocation: {
42-
origin: 'bottom',
43-
offset: {
44-
x: 0,
45-
y: 0,
46-
z: 11.54,
47-
},
48-
},
49-
})
5039
const aspirateHelper = makeAspirateHelper()
5140
const dispenseHelper = makeDispenseHelper()
5241
const touchTipHelper = makeTouchTipHelper()
@@ -450,8 +439,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
450439
makeMoveToWellHelper('A1'),
451440
makeAirGapHelper(5),
452441
delayCommand(12),
453-
454-
dispenseAirGapHelper('A2', 5),
455442
dispenseHelper('A2', 100),
456443
dispenseHelper('A3', 100),
457444

@@ -460,7 +447,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
460447
makeMoveToWellHelper('A1'),
461448
makeAirGapHelper(5),
462449
delayCommand(12),
463-
dispenseAirGapHelper('A4', 5),
464450
dispenseHelper('A4', 100),
465451
dispenseHelper('A5', 100),
466452
])
@@ -488,14 +474,12 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
488474
aspirateHelper('A1', 200),
489475
makeMoveToWellHelper('A1'),
490476
makeAirGapHelper(5),
491-
dispenseAirGapHelper('A2', 5),
492477
dispenseHelper('A2', 100),
493478
dispenseHelper('A3', 100),
494479

495480
aspirateHelper('A1', 200),
496481
makeMoveToWellHelper('A1'),
497482
makeAirGapHelper(5),
498-
dispenseAirGapHelper('A4', 5),
499483
dispenseHelper('A4', 100),
500484
dispenseHelper('A5', 100),
501485
])
@@ -524,9 +508,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
524508
aspirateHelper('A1', 200),
525509
makeMoveToWellHelper('A1'),
526510
makeAirGapHelper(5),
527-
528-
dispenseAirGapHelper('A2', 5),
529-
delayCommand(12),
530511
dispenseHelper('A2', 100),
531512
...delayWithOffset('A2', DEST_LABWARE),
532513
dispenseHelper('A3', 100),
@@ -535,9 +516,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
535516
aspirateHelper('A1', 200),
536517
makeMoveToWellHelper('A1'),
537518
makeAirGapHelper(5),
538-
539-
dispenseAirGapHelper('A4', 5),
540-
delayCommand(12),
541519
dispenseHelper('A4', 100),
542520
...delayWithOffset('A4', DEST_LABWARE),
543521
dispenseHelper('A5', 100),
@@ -928,8 +906,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
928906
makeAirGapHelper(31),
929907
delayCommand(11),
930908
// dispense #1
931-
dispenseAirGapHelper('B1', 31),
932-
delayCommand(12),
933909
dispenseHelper('B1', 45),
934910
...delayWithOffset('B1', DEST_LABWARE),
935911
// touch tip (disp #1)
@@ -976,8 +952,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
976952
makeAirGapHelper(31),
977953
delayCommand(11),
978954
// dispense #1
979-
dispenseAirGapHelper('A2', 31),
980-
delayCommand(12),
981955
dispenseHelper('A2', 100),
982956
...delayWithOffset('A2', DEST_LABWARE),
983957
// touch tip (disp #1)
@@ -1008,8 +982,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
1008982
makeMoveToWellHelper('A1'),
1009983
makeAirGapHelper(31),
1010984
delayCommand(11),
1011-
dispenseAirGapHelper('A4', 31),
1012-
delayCommand(12),
1013985
// dispense #3
1014986
dispenseHelper('A4', 100),
1015987
...delayWithOffset('A4', DEST_LABWARE),
@@ -1059,8 +1031,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
10591031
makeAirGapHelper(31),
10601032
delayCommand(11),
10611033
// dispense #1
1062-
dispenseAirGapHelper('A2', 31),
1063-
delayCommand(12),
10641034
dispenseHelper('A2', 100),
10651035
...delayWithOffset('A2', DEST_LABWARE),
10661036
// touch tip (disp #1)
@@ -1098,8 +1068,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
10981068
makeAirGapHelper(31),
10991069
delayCommand(11),
11001070
// dispense #3
1101-
dispenseAirGapHelper('A4', 31),
1102-
delayCommand(12),
11031071
dispenseHelper('A4', 100),
11041072
...delayWithOffset('A4', DEST_LABWARE),
11051073
// touch tip (disp #3)
@@ -1149,8 +1117,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
11491117
makeAirGapHelper(31),
11501118
delayCommand(11),
11511119
// dispense #1
1152-
dispenseAirGapHelper('A2', 31),
1153-
delayCommand(12),
11541120
dispenseHelper('A2', 100),
11551121
...delayWithOffset('A2', DEST_LABWARE),
11561122
// touch tip (disp #1)
@@ -1181,8 +1147,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
11811147
makeAirGapHelper(31),
11821148
delayCommand(11),
11831149
// dispense #3
1184-
dispenseAirGapHelper('A4', 31),
1185-
delayCommand(12),
11861150
dispenseHelper('A4', 100),
11871151
...delayWithOffset('A4', DEST_LABWARE),
11881152
// touch tip (disp #3)
@@ -1229,8 +1193,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
12291193
makeAirGapHelper(31),
12301194
delayCommand(11),
12311195
// dispense #1
1232-
dispenseAirGapHelper('A2', 31),
1233-
delayCommand(12),
12341196
dispenseHelper('A2', 100),
12351197
...delayWithOffset('A2', DEST_LABWARE),
12361198
// touch tip (disp #1)
@@ -1262,8 +1224,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
12621224
makeAirGapHelper(31),
12631225
delayCommand(11),
12641226
// dispense #3
1265-
dispenseAirGapHelper('A4', 31),
1266-
delayCommand(12),
12671227
dispenseHelper('A4', 100),
12681228
...delayWithOffset('A4', DEST_LABWARE),
12691229
// touch tip (disp #3)
@@ -1314,8 +1274,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
13141274
makeAirGapHelper(31),
13151275
delayCommand(11),
13161276
// dispense #1
1317-
dispenseAirGapHelper('A2', 31),
1318-
delayCommand(12),
13191277
dispenseHelper('A2', 100),
13201278
...delayWithOffset('A2', DEST_LABWARE),
13211279
// touch tip (disp #1)
@@ -1355,8 +1313,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
13551313
makeAirGapHelper(31),
13561314
delayCommand(11),
13571315
// dispense #3
1358-
dispenseAirGapHelper('A4', 31),
1359-
delayCommand(12),
13601316
dispenseHelper('A4', 100),
13611317
...delayWithOffset('A4', DEST_LABWARE),
13621318
// touch tip (disp #3)
@@ -1406,8 +1362,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
14061362
makeAirGapHelper(31),
14071363
delayCommand(11),
14081364
// dispense #1
1409-
dispenseAirGapHelper('A2', 31),
1410-
delayCommand(12),
14111365
dispenseHelper('A2', 100),
14121366
...delayWithOffset('A2', DEST_LABWARE),
14131367
// touch tip (disp #1)
@@ -1439,8 +1393,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
14391393
makeAirGapHelper(31),
14401394
delayCommand(11),
14411395
// dispense #3
1442-
dispenseAirGapHelper('A4', 31),
1443-
delayCommand(12),
14441396
dispenseHelper('A4', 100),
14451397
...delayWithOffset('A4', DEST_LABWARE),
14461398
// touch tip (disp #3)
@@ -1488,8 +1440,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
14881440
makeAirGapHelper(31),
14891441
delayCommand(11),
14901442
// dispense #1
1491-
dispenseAirGapHelper('A2', 31),
1492-
delayCommand(12),
14931443
dispenseHelper('A2', 100),
14941444
...delayWithOffset('A2', DEST_LABWARE),
14951445
// touch tip (disp #1)
@@ -1521,8 +1471,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
15211471
makeAirGapHelper(31),
15221472
delayCommand(11),
15231473
// dispense #3
1524-
dispenseAirGapHelper('A4', 31),
1525-
delayCommand(12),
15261474
dispenseHelper('A4', 100),
15271475
...delayWithOffset('A4', DEST_LABWARE),
15281476
// touch tip (disp #3)
@@ -1573,8 +1521,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
15731521
makeAirGapHelper(31),
15741522
delayCommand(11),
15751523
// dispense #1
1576-
dispenseAirGapHelper('A2', 31),
1577-
delayCommand(12),
15781524
dispenseHelper('A2', 100),
15791525
...delayWithOffset('A2', DEST_LABWARE),
15801526
// touch tip (disp #1)
@@ -1614,8 +1560,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
16141560
makeAirGapHelper(31),
16151561
delayCommand(11),
16161562
// dispense #3
1617-
dispenseAirGapHelper('A4', 31),
1618-
delayCommand(12),
16191563
dispenseHelper('A4', 100),
16201564
...delayWithOffset('A4', DEST_LABWARE),
16211565
// touch tip (disp #3)
@@ -1665,8 +1609,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
16651609
makeAirGapHelper(31),
16661610
delayCommand(11),
16671611
// dispense #1
1668-
dispenseAirGapHelper('A2', 31),
1669-
delayCommand(12),
16701612
dispenseHelper('A2', 100),
16711613
...delayWithOffset('A2', DEST_LABWARE),
16721614
// touch tip (disp #1)
@@ -1698,8 +1640,6 @@ describe('advanced settings: volume, mix, pre-wet tip, tip touch, tip position',
16981640
makeAirGapHelper(31),
16991641
delayCommand(11),
17001642
// dispense #3
1701-
dispenseAirGapHelper('A4', 31),
1702-
delayCommand(12),
17031643
dispenseHelper('A4', 100),
17041644
...delayWithOffset('A4', DEST_LABWARE),
17051645
// touch tip (disp #3)

0 commit comments

Comments
 (0)