fix(api): correctionVolume can be negative (#17413)

andySigler · web-flow · commit a693b6c4ad12 · 2025-02-06T10:30:08.000-05:00
diff --git a/api/src/opentrons/protocol_engine/commands/pipetting_common.py b/api/src/opentrons/protocol_engine/commands/pipetting_common.py
@@ -48,7 +48,6 @@ class AspirateVolumeMixin(BaseModel):
     correctionVolume: Optional[float] = Field(
         None,
         description="The correction volume in uL.",
-        ge=0,
     )
 
 
@@ -65,7 +64,6 @@ class DispenseVolumeMixin(BaseModel):
     correctionVolume: Optional[float] = Field(
         None,
         description="The correction volume in uL.",
-        ge=0,
     )
 
 
diff --git a/shared-data/command/schemas/12.json b/shared-data/command/schemas/12.json
@@ -67,7 +67,6 @@
         "correctionVolume": {
           "anyOf": [
             {
-              "minimum": 0.0,
               "type": "number"
             },
             {
@@ -176,7 +175,6 @@
         "correctionVolume": {
           "anyOf": [
             {
-              "minimum": 0.0,
               "type": "number"
             },
             {
@@ -215,7 +213,6 @@
         "correctionVolume": {
           "anyOf": [
             {
-              "minimum": 0.0,
               "type": "number"
             },
             {
@@ -413,7 +410,6 @@
         "correctionVolume": {
           "anyOf": [
             {
-              "minimum": 0.0,
               "type": "number"
             },
             {
@@ -1521,7 +1517,6 @@
         "correctionVolume": {
           "anyOf": [
             {
-              "minimum": 0.0,
               "type": "number"
             },
             {
@@ -1565,7 +1560,6 @@
         "correctionVolume": {
           "anyOf": [
             {
-              "minimum": 0.0,
               "type": "number"
             },
             {
@@ -1651,7 +1645,6 @@
         "correctionVolume": {
           "anyOf": [
             {
-              "minimum": 0.0,
               "type": "number"
             },
             {
@@ -1914,7 +1907,6 @@
         "correctionVolume": {
           "anyOf": [
             {
-              "minimum": 0.0,
               "type": "number"
             },
             {

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,6 @@ class AspirateVolumeMixin(BaseModel):`
`48`	`48`	`correctionVolume: Optional[float] = Field(`
`49`	`49`	`None,`
`50`	`50`	`description="The correction volume in uL.",`
`51`		`- ge=0,`
`52`	`51`	`)`
`53`	`52`
`54`	`53`
`@@ -65,7 +64,6 @@ class DispenseVolumeMixin(BaseModel):`
`65`	`64`	`correctionVolume: Optional[float] = Field(`
`66`	`65`	`None,`
`67`	`66`	`description="The correction volume in uL.",`
`68`		`- ge=0,`
`69`	`67`	`)`
`70`	`68`
`71`	`69`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,6 @@`
`67`	`67`	`"correctionVolume": {`
`68`	`68`	`"anyOf": [`
`69`	`69`	`{`
`70`		`- "minimum": 0.0,`
`71`	`70`	`"type": "number"`
`72`	`71`	`},`
`73`	`72`	`{`
`@@ -176,7 +175,6 @@`
`176`	`175`	`"correctionVolume": {`
`177`	`176`	`"anyOf": [`
`178`	`177`	`{`
`179`		`- "minimum": 0.0,`
`180`	`178`	`"type": "number"`
`181`	`179`	`},`
`182`	`180`	`{`
`@@ -215,7 +213,6 @@`
`215`	`213`	`"correctionVolume": {`
`216`	`214`	`"anyOf": [`
`217`	`215`	`{`
`218`		`- "minimum": 0.0,`
`219`	`216`	`"type": "number"`
`220`	`217`	`},`
`221`	`218`	`{`
`@@ -413,7 +410,6 @@`
`413`	`410`	`"correctionVolume": {`
`414`	`411`	`"anyOf": [`
`415`	`412`	`{`
`416`		`- "minimum": 0.0,`
`417`	`413`	`"type": "number"`
`418`	`414`	`},`
`419`	`415`	`{`
`@@ -1521,7 +1517,6 @@`
`1521`	`1517`	`"correctionVolume": {`
`1522`	`1518`	`"anyOf": [`
`1523`	`1519`	`{`
`1524`		`- "minimum": 0.0,`
`1525`	`1520`	`"type": "number"`
`1526`	`1521`	`},`
`1527`	`1522`	`{`
`@@ -1565,7 +1560,6 @@`
`1565`	`1560`	`"correctionVolume": {`
`1566`	`1561`	`"anyOf": [`
`1567`	`1562`	`{`
`1568`		`- "minimum": 0.0,`
`1569`	`1563`	`"type": "number"`
`1570`	`1564`	`},`
`1571`	`1565`	`{`
`@@ -1651,7 +1645,6 @@`
`1651`	`1645`	`"correctionVolume": {`
`1652`	`1646`	`"anyOf": [`
`1653`	`1647`	`{`
`1654`		`- "minimum": 0.0,`
`1655`	`1648`	`"type": "number"`
`1656`	`1649`	`},`
`1657`	`1650`	`{`
`@@ -1914,7 +1907,6 @@`
`1914`	`1907`	`"correctionVolume": {`
`1915`	`1908`	`"anyOf": [`
`1916`	`1909`	`{`
`1917`		`- "minimum": 0.0,`
`1918`	`1910`	`"type": "number"`
`1919`	`1911`	`},`
`1920`	`1912`	`{`