sum comments

Author: caila-marashaj

api/src/opentrons/protocol_api/core/legacy_simulator/legacy_instrument_core.py

@@ -571,4 +571,5 @@ def estimate_liquid_height(
         starting_liquid_height: float,
         operation_volume: float,
     ) -> float:
-        return 0.0
+        """This will never be called because it was added in API 2.21."""
+        assert False, "estimate_liquid_height only supported in API 2.21 & later"

api/src/opentrons/protocol_engine/state/frustum_helpers.py

@@ -241,8 +241,8 @@ def _get_segment_capacity(segment: WellSegment) -> float:
 def get_well_volumetric_capacity(
     well_geometry: InnerWellGeometry,
 ) -> List[Tuple[float, float]]:
-    """Return the total volumetric capacity of a well as a map of height borders to volume."""
-    #  [(top_height_0, total_volume_at_height_0), (top_height_1, total_volume_at_height_1), ...]
+    """Return the volumetric capacity of a well as a list of pairs relating segment heights to volumes."""
+    #  [(top_height_0, section_0_volume), (top_height_1, section_1_volume), ...]
     well_volume = []
 
     # get the well segments sorted in ascending order

api/src/opentrons/protocol_engine/state/geometry.py

@@ -1562,7 +1562,6 @@ def get_well_height_after_liquid_handling(
         well_geometry = self._labware.get_well_geometry(
             labware_id=labware_id, well_name=well_name
         )
-        # figure out what initial_height is here
         initial_volume = find_volume_at_well_height(
             target_height=initial_height, well_geometry=well_geometry
         )