You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(app): Fix accidental polling when a query is initially disabled (#17853)
## Overview
While testing EXEC-1342, we noticed a bug in our notifications machinery
that would cause the app to poll even when MQTT was available and it
shouldn't have to.
## Details
Specifically, the bug would happen for queries that started off with
`options` of `{enabled: false}` and became `{enabled: true}` later on.
[Here is the motivating
example](https://github.com/Opentrons/opentrons/blob/a3b78c28c0f9b51edbe68dc60908b4e3adc6cf2e/app/src/organisms/LabwarePositionCheck/LPCFlows/hooks/useLPCLabwareInfo/index.ts#L68-L77).
The `useNotifyDataReady` hook had a piece of state, `isNotifyEnabled`,
that would accidentally permanently latch to `false` whenever the hook
saw `{enabled: false}`.
## Test Plan and Hands on Testing
Tested as part of #17832 by monitoring the network logs.
## Risk assessment
Medium. This is common code for a lot of stuff, and it's hard to test.
0 commit comments