Skip to content

Commit bdaa205

Browse files
committed
pr feedback and removed legacy styled text test
1 parent 7460f00 commit bdaa205

File tree

5 files changed

+16
-316
lines changed

5 files changed

+16
-316
lines changed

app/src/molecules/InterventionModal/index.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,12 +176,12 @@ export function InterventionModal({
176176
}
177177

178178
const ICON_STYLE = css`
179-
width: 1rem;
180-
height: 1rem;
179+
width: ${SPACING.spacing16}
180+
height: ${SPACING.spacing16}
181181
margin: ${SPACING.spacing4};
182182
@media (${RESPONSIVENESS.touchscreenMediaQuerySpecs}) {
183-
width: 2rem;
184-
height: 2rem;
183+
width: ${SPACING.spacing32}
184+
height: ${SPACING.spacing32}
185185
margin: ${SPACING.spacing12};
186186
}
187187
`

app/src/organisms/ErrorRecoveryFlows/ErrorRecoveryWizard.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,13 @@ export function ErrorRecoveryWizard(
8383
export function ErrorRecoveryComponent(
8484
props: RecoveryContentProps
8585
): JSX.Element {
86-
const { recoveryMap, isDoorOpen, isOnDevice } = props
86+
const { recoveryMap, hasLaunchedRecovery, isDoorOpen, isOnDevice } = props
8787
const { route, step } = recoveryMap
8888
const { t } = useTranslation('error_recovery')
8989
const { showModal, toggleModal } = useErrorDetailsModal()
9090

9191
const buildTitleHeading = (): JSX.Element => {
92-
const titleText = props.hasLaunchedRecovery
93-
? t('recovery_mode')
94-
: t('cancel_run')
92+
const titleText = hasLaunchedRecovery ? t('recovery_mode') : t('cancel_run')
9593
return (
9694
<StyledText
9795
oddStyle="level4HeaderBold"

app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/CancelRun.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,10 @@ const FLEX_WIDTH = css`
155155
`
156156

157157
const ICON_SIZE = css`
158-
width: 2.5rem;
159-
height: 2.5rem;
158+
width: ${SPACING.spacing40}
159+
height: ${SPACING.spacing40}
160160
@media (${RESPONSIVENESS.touchscreenMediaQuerySpecs}) {
161-
width: 3.75rem;
162-
height: 3.75rem;
161+
width: ${SPACING.spacing60}
162+
height: ${SPACING.spacing60}
163163
}
164164
`

app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,16 @@ import {
88
SPACING,
99
Flex,
1010
StyledText,
11-
RESPONSIVENESS,
1211
} from '@opentrons/components'
1312
import { FLEX_ROBOT_TYPE, OT2_ROBOT_TYPE } from '@opentrons/shared-data'
1413

1514
import { RadioButton } from '../../../atoms/buttons'
16-
import { ODD_SECTION_TITLE_STYLE, RECOVERY_MAP } from '../constants'
15+
import {
16+
ODD_SECTION_TITLE_STYLE,
17+
RECOVERY_MAP,
18+
ODD_ONLY,
19+
DESKTOP_ONLY,
20+
} from '../constants'
1721
import {
1822
RecoveryFooterButtons,
1923
RecoverySingleColumnContentWrapper,
@@ -92,18 +96,6 @@ export function BeginRemoval({
9296
}
9397
}
9498

95-
const ODD_ONLY = css`
96-
@media not (${RESPONSIVENESS.touchscreenMediaQuerySpecs}) {
97-
display: none;
98-
}
99-
`
100-
101-
const DESKTOP_ONLY = css`
102-
@media ${RESPONSIVENESS.touchscreenMediaQuerySpecs} {
103-
display: none;
104-
}
105-
`
106-
10799
return (
108100
<RecoverySingleColumnContentWrapper>
109101
<StyledText

components/src/atoms/StyledText/__tests__/StyledText.test.tsx

Lines changed: 0 additions & 290 deletions
This file was deleted.

0 commit comments

Comments
 (0)