pr feedback and removed legacy styled text test

Opentrons · Jul 18, 2024 · bdaa205 · bdaa205
1 parent 7460f00
commit bdaa205
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 316 deletions.
diff --git a/app/src/molecules/InterventionModal/index.tsx b/app/src/molecules/InterventionModal/index.tsx
@@ -176,12 +176,12 @@ export function InterventionModal({
 }
 
 const ICON_STYLE = css`
-  width: 1rem;
-  height: 1rem;
+  width: ${SPACING.spacing16}
+  height: ${SPACING.spacing16}
   margin: ${SPACING.spacing4};
   @media (${RESPONSIVENESS.touchscreenMediaQuerySpecs}) {
-    width: 2rem;
-    height: 2rem;
+    width: ${SPACING.spacing32}
+    height: ${SPACING.spacing32}
     margin: ${SPACING.spacing12};
   }
 `
diff --git a/app/src/organisms/ErrorRecoveryFlows/ErrorRecoveryWizard.tsx b/app/src/organisms/ErrorRecoveryFlows/ErrorRecoveryWizard.tsx
@@ -83,15 +83,13 @@ export function ErrorRecoveryWizard(
 export function ErrorRecoveryComponent(
   props: RecoveryContentProps
 ): JSX.Element {
-  const { recoveryMap, isDoorOpen, isOnDevice } = props
+  const { recoveryMap, hasLaunchedRecovery, isDoorOpen, isOnDevice } = props
   const { route, step } = recoveryMap
   const { t } = useTranslation('error_recovery')
   const { showModal, toggleModal } = useErrorDetailsModal()
 
   const buildTitleHeading = (): JSX.Element => {
-    const titleText = props.hasLaunchedRecovery
-      ? t('recovery_mode')
-      : t('cancel_run')
+    const titleText = hasLaunchedRecovery ? t('recovery_mode') : t('cancel_run')
     return (
       <StyledText
         oddStyle="level4HeaderBold"

diff --git a/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/CancelRun.tsx b/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/CancelRun.tsx
@@ -155,10 +155,10 @@ const FLEX_WIDTH = css`
 `
 
 const ICON_SIZE = css`
-  width: 2.5rem;
-  height: 2.5rem;
+  width: ${SPACING.spacing40}
+  height: ${SPACING.spacing40}
   @media (${RESPONSIVENESS.touchscreenMediaQuerySpecs}) {
-    width: 3.75rem;
-    height: 3.75rem;
+    width: ${SPACING.spacing60}
+    height: ${SPACING.spacing60}
   }
 `
diff --git a/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx b/app/src/organisms/ErrorRecoveryFlows/RecoveryOptions/ManageTips.tsx
@@ -8,12 +8,16 @@ import {
   SPACING,
   Flex,
   StyledText,
-  RESPONSIVENESS,
 } from '@opentrons/components'
 import { FLEX_ROBOT_TYPE, OT2_ROBOT_TYPE } from '@opentrons/shared-data'
 
 import { RadioButton } from '../../../atoms/buttons'
-import { ODD_SECTION_TITLE_STYLE, RECOVERY_MAP } from '../constants'
+import {
+  ODD_SECTION_TITLE_STYLE,
+  RECOVERY_MAP,
+  ODD_ONLY,
+  DESKTOP_ONLY,
+} from '../constants'
 import {
   RecoveryFooterButtons,
   RecoverySingleColumnContentWrapper,
@@ -92,18 +96,6 @@ export function BeginRemoval({
     }
   }
 
-  const ODD_ONLY = css`
-    @media not (${RESPONSIVENESS.touchscreenMediaQuerySpecs}) {
-      display: none;
-    }
-  `
-
-  const DESKTOP_ONLY = css`
-    @media ${RESPONSIVENESS.touchscreenMediaQuerySpecs} {
-      display: none;
-    }
-  `
-
   return (
     <RecoverySingleColumnContentWrapper>
       <StyledText

diff --git a/components/src/atoms/StyledText/__tests__/StyledText.test.tsx b/components/src/atoms/StyledText/__tests__/StyledText.test.tsx