Skip to content

Commit d18fe07

Browse files
Explain older bugs.
1 parent 318145f commit d18fe07

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

shared-data/js/__tests__/labwareDefSchemaV2.test.ts

+16-11
Original file line numberDiff line numberDiff line change
@@ -95,17 +95,7 @@ const expectedWellsNotMatchingZDimension: Record<string, Set<string>> = {
9595
'B4',
9696
]),
9797

98-
// These height mismatches are legitimate. The zDimension should match the taller side.
99-
'opentrons_calibrationblock_short_side_left/1.json': new Set(['A1']),
100-
'opentrons_calibrationblock_short_side_right/1.json': new Set(['A2']),
101-
102-
// this labware has a lip
103-
'evotips_opentrons_96_labware/2.json': standard96WellNames,
104-
105-
// These height mismatches need to be investigated. See Jira RSS-202.
106-
// Each one should either be explained here or marked as a known bug.
107-
'nest_1_reservoir_195ml/1.json': new Set(['A1']),
108-
'nest_1_reservoir_195ml/2.json': new Set(['A1']),
98+
// This is probably legitimate. Heterogeneous tubes.
10999
'opentrons_40_aluminumblock_eppendorf_24x2ml_safelock_snapcap_generic_16x0.2ml_pcr_strip/1.json': new Set(
110100
[
111101
'A3',
@@ -134,9 +124,24 @@ const expectedWellsNotMatchingZDimension: Record<string, Set<string>> = {
134124
'D8',
135125
]
136126
),
127+
128+
// These height mismatches are legitimate. The zDimension should match the taller side.
129+
'opentrons_calibrationblock_short_side_left/1.json': new Set(['A1']),
130+
'opentrons_calibrationblock_short_side_right/1.json': new Set(['A2']),
131+
132+
// this labware has a lip
133+
'evotips_opentrons_96_labware/2.json': standard96WellNames,
134+
135+
// Presumably a bug. Fixed in v3 of this labware.
136+
'nest_1_reservoir_195ml/1.json': new Set(['A1']),
137+
'nest_1_reservoir_195ml/2.json': new Set(['A1']),
138+
139+
// These were probably bugs, but it's moot now, since these adapter+wellplate
140+
// combo-definitions have been superseded by proper labware stacking.
137141
'opentrons_96_flat_bottom_adapter_nest_wellplate_200ul_flat/1.json': standard96WellNames,
138142
'opentrons_96_pcr_adapter_nest_wellplate_100ul_pcr_full_skirt/1.json': standard96WellNames,
139143
'opentrons_universal_flat_adapter_corning_384_wellplate_112ul_flat/1.json': standard384WellNames,
144+
140145
// This batch may have incompletely-updated geometry from recent work related to
141146
// liquid level detection and meniscus-relative pipetting. Probably, the wells were
142147
// updated but not the overall labware dimensions. This needs to be investigated and fixed.

0 commit comments

Comments
 (0)