Skip to content

Commit dee56e1

Browse files
authored
feat(hardware): Store overpressure count on plungers (#17839)
<!-- Thanks for taking the time to open a Pull Request (PR)! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests GitHub provides robust markdown to format your PR. Links, diagrams, pictures, and videos along with text formatting make it possible to create a rich and informative PR. For more information on GitHub markdown, see: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview This corresponds with a firmware PR that enables the firmware to store lifetime overpressure errors in the eeprom and report them out separately from regular motion errors. also does a little touch-up where the auto-gen can IDs had gotten out of sync, the missing one is here now since this is the source of truth. <!-- Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources. --> ## Test Plan and Hands on Testing <!-- Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing. --> ## Changelog <!-- List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes. --> ## Review requests <!-- - What do you need from reviewers to feel confident this PR is ready to merge? - Ask questions. --> ## Risk assessment <!-- - Indicate the level of attention this PR needs. - Provide context to guide reviewers. - Discuss trade-offs, coupling, and side effects. - Look for the possibility, even if you think it's small, that your change may affect some other part of the system. - For instance, changing return tip behavior may also change the behavior of labware calibration. - How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions? - Especially in high risk PRs, explain how you know your testing is enough. -->
1 parent 95a41e7 commit dee56e1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

hardware/opentrons_hardware/firmware_bindings/constants.py

+2
Original file line numberDiff line numberDiff line change
@@ -332,6 +332,7 @@ class SensorType(int, Enum):
332332
pressure_temperature = 0x04
333333
humidity = 0x05
334334
temperature = 0x06
335+
UNUSED = 0x07
335336

336337

337338
@unique
@@ -444,6 +445,7 @@ class MotorUsageValueType(int, Enum):
444445
right_gear_motor_distance = 0x2
445446
force_application_time = 0x3
446447
total_error_count = 0x4
448+
overpressure_error_count = 0x5
447449

448450

449451
class MoveAckId(int, Enum):

0 commit comments

Comments
 (0)