Skip to content

Commit 79f7015

Browse files
authored
Merge pull request #2935 from Orange-OpenSource/ouds/main-2934-ouds-checkbox-enhancement-after-merge
fix(component): Checkbox, use divider token, fix doc and tac
2 parents fd2f797 + 4153da3 commit 79f7015

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Diff for: scss/forms/_control-item.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@
238238

239239
.control-item-divider {
240240
padding-bottom: subtract($ouds-control-item-space-inset, 1px);
241-
border-bottom: 1px solid $ouds-color-border-default; // TODO: Introduce design token once created
241+
border-bottom: $ouds-divider-border-width solid $ouds-color-border-default;
242242
}
243243

244244
.control-item-reverse {

Diff for: site/assets/js/tac.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
})
4949
const allowConsentButton = document.querySelector('#tarteaucitronAllAllowed')
5050
const denyConsentButton = document.querySelector('#tarteaucitronAllDenied')
51-
const checkboxes = document.querySelectorAll('.checkbox-indicator')
51+
const checkboxes = document.querySelectorAll('.control-item-indicator')
5252

5353
allowConsentButton.addEventListener('click', () => {
5454
for (let i = 0; i < checkboxes.length; i++) {
@@ -88,7 +88,7 @@
8888
.createRange()
8989
.createContextualFragment( // TODO replace with a form-switch
9090
`<label class="checkbox-standalone ">
91-
<input class="checkbox-indicator" type="checkbox" value="" id="googletagmanagerAllowed" aria-labelledby="googletagmanagerLine" onchange="${choiceEvent}"${((document.cookie.match(/^(?:.*;)?\s*cookie-consent\s*=\s*([^;]+)(?:.*)?$/) || [null])[1].match('!googletagmanager=true') ? 'checked' : '')}>
91+
<input class="control-item-indicator" type="checkbox" value="" id="googletagmanagerAllowed" aria-labelledby="googletagmanagerLine" onchange="${choiceEvent}"${((document.cookie.match(/^(?:.*;)?\s*cookie-consent\s*=\s*([^;]+)(?:.*)?$/) || [null])[1].match('!googletagmanager=true') ? 'checked' : '')}>
9292
<span class="visually-hidden">Google Tag Manager</span>
9393
<input id="googletagmanagerDenied" class="d-none">
9494
</label>`

Diff for: site/content/docs/0.3/migration-from-boosted.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ Now you should write:
164164

165165
```html
166166
<div class="checkbox-item">
167-
<div class="control-item-indicator-container">
167+
<div class="control-item-assets-container">
168168
<input class="control-item-indicator" type="checkbox" value="" id="checkboxDefault">
169169
</div>
170170
<div class="control-item-text-container">

0 commit comments

Comments
 (0)