-
Notifications
You must be signed in to change notification settings - Fork 57
Description
Prerequisites
- I have searched for duplicate or closed issues
- I have validated any HTML to avoid common problems
- I have read the contributing guidelines
Describe the issue
Buttons with icon have a different padding than the one indicated on Orange Design System (https://system.design.orange.com/0c1af118d/p/278ebc-standard-buttons/b/247486). Concerned :
-
Small secondary button: padding left and right equals 12px (10px padding + 2px border) in Boosted instead of 15px (13px padding + 2px border) in ODS
-
Large secondary button: padding left and right equals 22px (20px padding + 2px border) in Boosted instead of 20px (18px padding + 2px border) in ODS
I gave a wrong information to you regarding the sizes that we provide for some buttons in the Web UI Kit. The correct info is:
- Button with label, button with icon+label are provided in Small, Medium, and Large sizes in the Web UI Kit. But it is not reflected in the DSM and in Zeplin. We will correct that. In the meantime I can give you the specifications. => Issue Docs > Components > Buttons > With icon: Add "not in ODS" alert message #1125 no more need and therefore closed
- Other buttons are provided at Medium size only.
Specifications:
The changes that have to be made are :
- set icon size in small buttons to 15px instead of 16px (1rem) and change comment above (icons sizes are always a multiple of 5)
- set horizontal padding for small buttons to 13px instead of currently 10px - and not 15px (because in sketch horizontal padding in buttons includes 2px border). This has to be done for small buttons with or without icons
- set horizontal padding for large buttons to 18px instead of currently 20px - and not 20px (because in sketch horizontal padding in buttons includes 2px border). This has to be done for large buttons with or without icons
- slightly lower small buttons padding (try 1px lower). This has to be done for small buttons with or without icons
- do not change anything else because it already seems ok
Reduced test cases
NA
What operating system(s) are you seeing the problem on?
Windows, macOS
What browser(s) are you seeing the problem on?
Chrome, Firefox
What version of Boosted are you using?
v5.1.0
