Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add semicolon to logo's SVG's CSS #2080

Closed
wants to merge 1 commit into from

Conversation

julien-deramond
Copy link
Contributor

@julien-deramond julien-deramond commented Jun 12, 2023

Related issues

Closes #1774

Description

This PR modifies orange-logo.svg to add some semicolons that seem mandatory for Firefox when the style in minified. Haven't found/looked for resources online but this trick seems to work.

When trying it, clear your cache or launch the URLs in incognito mode.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)

After the merge

@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 5f8be8a
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64871e759aed2a000890f6d8
😎 Deploy Preview https://deploy-preview-2080--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond deleted the main-jd-test-fix-logo branch July 17, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Master logo doesn't transition to minified logo on Firefox
1 participant