Remove custom semantic state description for checkbox and checkbox item

Author: florentmaitre

core/src/main/java/com/orange/ouds/core/component/OudsCheckbox.kt

@@ -40,8 +40,6 @@ import androidx.compose.ui.graphics.Shape
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.res.painterResource
 import androidx.compose.ui.semantics.Role
-import androidx.compose.ui.semantics.semantics
-import androidx.compose.ui.semantics.stateDescription
 import androidx.compose.ui.state.ToggleableState
 import androidx.compose.ui.tooling.preview.PreviewParameter
 import androidx.compose.ui.unit.Dp
@@ -166,7 +164,6 @@ private fun OudsCheckbox(
         exceptionMessage = { "An OudsCheckbox or OudsTriStateCheckbox set to disabled with error parameter activated is not allowed." }
     ) {
         val interactionState by interactionSource.collectInteractionStateAsState()
-        val context = LocalContext.current
         val checkboxTokens = OudsTheme.componentsTokens.checkbox
         val state = previewState.orElse { rememberOudsControlState(enabled = enabled, interactionState = interactionState) }
 
@@ -175,14 +172,7 @@ private fun OudsCheckbox(
                 .widthIn(checkboxTokens.sizeMinWidth.dp)
                 .heightIn(min = checkboxTokens.sizeMinHeight.dp, max = checkboxTokens.sizeMaxHeight.dp)
                 .background(color = backgroundColor(state = state))
-                .outerBorder(state = state)
-                .semantics {
-                    stateDescription = when (value) {
-                        ToggleableState.Off -> context.getString(R.string.core_checkbox_unchecked_a11y)
-                        ToggleableState.On -> context.getString(R.string.core_checkbox_checked_a11y)
-                        ToggleableState.Indeterminate -> context.getString(R.string.core_checkbox_indeterminate_a11y)
-                    }
-                },
+                .outerBorder(state = state),
             contentAlignment = Alignment.Center,
         ) {
             OudsCheckboxIndicator(state = state, value = value, error = error)

core/src/main/java/com/orange/ouds/core/component/OudsCheckboxItem.kt

@@ -28,11 +28,9 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.semantics.Role
 import androidx.compose.ui.semantics.semantics
-import androidx.compose.ui.semantics.stateDescription
 import androidx.compose.ui.state.ToggleableState
 import androidx.compose.ui.tooling.preview.PreviewParameter
 import androidx.compose.ui.unit.dp
-import com.orange.ouds.core.R
 import com.orange.ouds.core.extensions.collectInteractionStateAsState
 import com.orange.ouds.core.utilities.LoremIpsumText
 import com.orange.ouds.core.utilities.OudsPreview
@@ -195,7 +193,6 @@ private fun OudsCheckboxItem(
     readOnly: Boolean = false,
     error: Boolean = false
 ) {
-    val context = LocalContext.current
     val interactionState by interactionSource.collectInteractionStateAsState()
     val state = previewState.orElse { rememberOudsControlItemState(enabled = enabled, readOnly = readOnly, interactionState = interactionState) }
 
@@ -223,13 +220,7 @@ private fun OudsCheckboxItem(
             ToggleableState.Off -> "Unselected"
             ToggleableState.Indeterminate -> "Indeterminate"
         },
-        modifier = modifier.semantics(mergeDescendants = true) {
-            stateDescription = when (value) {
-                ToggleableState.Off -> context.getString(R.string.core_checkbox_unchecked_a11y)
-                ToggleableState.On -> context.getString(R.string.core_checkbox_checked_a11y)
-                ToggleableState.Indeterminate -> context.getString(R.string.core_checkbox_indeterminate_a11y)
-            }
-        }
+        modifier = modifier.semantics(mergeDescendants = true) {}
     )
 }
 

core/src/main/res/values/strings.xml

@@ -14,9 +14,4 @@
     <!-- OudsButton -->
     <string name="core_button_loading_a11y">Loading</string>
 
-    <!-- OudsCheckbox -->
-    <string name="core_checkbox_checked_a11y">Checked</string>
-    <string name="core_checkbox_unchecked_a11y">Unchecked</string>
-    <string name="core_checkbox_indeterminate_a11y">Indeterminate</string>
-
 </resources>