Skip to content

Commit 2c27bab

Browse files
committed
review: delete warning
1 parent 0078701 commit 2c27bab

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

app/lib/ui/components/components_screen.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ import 'package:ouds_flutter_demo/ui/utilities/cards/ouds_cards_common.dart';
1919
import 'package:ouds_flutter_demo/ui/utilities/cards/ouds_vertical_image_first_card.dart';
2020
import 'package:provider/provider.dart';
2121

22-
import 'package:ouds_flutter_demo/ui/components/component_variants_screen.dart';
23-
2422
class ComponentsScreen extends StatelessWidget {
2523
final List<Component> oudsComponents;
2624

app/lib/ui/utilities/customizable/customizable_dropdown_menu.dart

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,14 @@ import 'package:provider/provider.dart';
1717
class CustomizationDropdownMenu<T> extends StatelessWidget {
1818
final String label;
1919
final List<T> options;
20-
int selectedItemIndex;
20+
final int selectedItemIndex;
2121
final String Function(T) getText;
2222
final Function(T, int) onSelectionChange;
2323
final List<Widget Function()>? itemLeadingIcons;
24-
T? selectedOption;
24+
final T? selectedOption;
25+
final bool isSelected;
2526

26-
var isSelected = false;
27-
28-
CustomizationDropdownMenu({
27+
const CustomizationDropdownMenu({
2928
super.key,
3029
required this.label,
3130
required this.options,
@@ -34,6 +33,7 @@ class CustomizationDropdownMenu<T> extends StatelessWidget {
3433
required this.selectedOption,
3534
this.itemLeadingIcons,
3635
required this.getText,
36+
this.isSelected = false,
3737
});
3838

3939
@override
@@ -67,24 +67,22 @@ class CustomizationDropdownMenu<T> extends StatelessWidget {
6767
),
6868
onSelected: (value) {
6969
if (value != null) {
70-
selectedItemIndex = options.indexOf(value);
71-
onSelectionChange(value, selectedItemIndex);
70+
final newIndex = options.indexOf(value);
71+
onSelectionChange(value, newIndex);
7272
}
7373
},
7474
leadingIcon: itemLeadingIcons != null ? buildDropdownLeadingIcon(context, itemLeadingIcons, selectedItemIndex) : null,
7575
dropdownMenuEntries: List.generate(options.length, (index) {
76-
selectedOption = options[index];
77-
selectedItemIndex = index;
7876
return DropdownMenuEntry<T>(
7977
labelWidget: Text(getText(options[index]),
8078
style: TextStyle(
8179
fontSize: OudsTheme.of(context).fontTokens.sizeBodyLargeMobile,
8280
fontWeight: OudsTheme.of(context).fontTokens.weightLabelStrong,
8381
letterSpacing: OudsTheme.of(context).fontTokens.letterSpacingBodyLargeMobile,
8482
)),
85-
value: selectedOption as T,
83+
value: options[index],
8684
label: getText(options[index]),
87-
leadingIcon: itemLeadingIcons != null ? buildDropdownLeadingIcon(context, itemLeadingIcons, selectedItemIndex) : null,
85+
leadingIcon: itemLeadingIcons != null ? buildDropdownLeadingIcon(context, itemLeadingIcons, index) : null,
8886
);
8987
}),
9088
),

0 commit comments

Comments
 (0)