User Phone number, VAT and IsCorporation (OCC-437)

[Skrypt]

I think the User Phone number should be taken from OC user phone number.
The VAT and IsCorporation fields should be optional and enabled as a feature.

Right now, I still need to have the user phone number but as "optional" and I think it is set to required on the checkout which is not something common. People want to keep their privacy sometimes. Now, when the SMS module is enabled or any other feature that requires a phone number to be assigned to the User it should simply enable that specific content part for the User.

Something similar than what I'm trying to do here: OrchardCMS/OrchardCore#19079

Jira issue

[sarahelsaig]

I think the User Phone number should be taken from OC user phone number.

I agree. This setting actually predates the user phone number in OC, but we should make the two compatible.

The VAT and IsCorporation fields should be optional and enabled as a feature.

These fields are already optional; as in null and false are their default values and you can hide the fields using Placement and shape overriding. The same is true for all the fields in the various OCC content parts, so making this toggled by feature is a slippery slope with little benefit.

Right now, I still need to have the user phone number but as "optional" and I think it is set to required on the checkout which is not something common.

What do you mean by "not common"? Phone number is required for checkout by both the two default payment providers (Stripe and Exactly), and many others I've seen.

[Skrypt]

A phone number is not generally required for a customer to complete a transaction on Stripe, but it may be mandatory depending on the merchant's settings or specific bank security protocols.

I've taken a look at checkout pages from Shopify as an example and most of the time the phone is optional.

To be honest here in Canada, we don't have sales tax exception based on a VAT number or if the user is a corporation, so I need to hide these fields with CSS or disable the feature entirely.

Also, then the form where we edit this is now less relevant because it ends up a form with a single input for the phone number. So, I wonder if we don't miss a complete "User profile" page instead of a "User Adresses" page. These 2 separated in 2 different forms that achieves the same goal of pre-filling the checkout page could be merged together. At least it would make sense to me! 😄

As for the TextField, I believe we don't use the BuildEditorAsync on it so I'm not sure how this can be integrated with the OCC frontend form to use the same shape. Maybe calling the shape directly but it already calls a shape in there. Will see.