Skip to content

Change the access of Shape of BuildShapeContext #18846

@infofromca

Description

@infofromca

Describe the bug

I want to assign
context.Shape = new EmptyShape();
in some condition.

Orchard Core version

latest main

To Reproduce

Expected behavior

change from --
using OrchardCore.DisplayManagement.Descriptors;
using OrchardCore.DisplayManagement.ModelBinding;
using OrchardCore.DisplayManagement.Zones;

namespace OrchardCore.DisplayManagement.Handlers;

public abstract class BuildShapeContext : IBuildShapeContext
{
protected BuildShapeContext(IShape shape, string groupId, IShapeFactory shapeFactory, IZoneHolding layout, IUpdateModel updater)
{
Shape = shape;
ShapeFactory = shapeFactory;
GroupId = groupId;
HtmlFieldPrefix = string.Empty;
Layout = layout;
FindPlacement = FindDefaultPlacement;
Updater = updater;
}

public IShape Shape { get; }
public IShapeFactory ShapeFactory { get; private set; }
public dynamic New => ShapeFactory;
public IZoneHolding Layout { get; set; }
public string GroupId { get; private set; }
public string HtmlFieldPrefix { get; protected set; }
public FindPlacementDelegate FindPlacement { get; set; }
public IUpdateModel Updater { get; }
public string DefaultZone { get; set; }
public string DefaultPosition { get; set; }

private static PlacementInfo FindDefaultPlacement(string shapeType, string differentiator, string displayType, IBuildShapeContext context)
{
    return null;
}

}

To--

using OrchardCore.DisplayManagement.Descriptors;
using OrchardCore.DisplayManagement.ModelBinding;
using OrchardCore.DisplayManagement.Zones;

namespace OrchardCore.DisplayManagement.Handlers;

public abstract class BuildShapeContext : IBuildShapeContext
{
protected BuildShapeContext(IShape shape, string groupId, IShapeFactory shapeFactory, IZoneHolding layout, IUpdateModel updater)
{
Shape = shape;
ShapeFactory = shapeFactory;
GroupId = groupId;
HtmlFieldPrefix = string.Empty;
Layout = layout;
FindPlacement = FindDefaultPlacement;
Updater = updater;
}

public IShape Shape { get; set; }
public IShapeFactory ShapeFactory { get; private set; }
public dynamic New => ShapeFactory;
public IZoneHolding Layout { get; set; }
public string GroupId { get; private set; }
public string HtmlFieldPrefix { get; protected set; }
public FindPlacementDelegate FindPlacement { get; set; }
public IUpdateModel Updater { get; }
public string DefaultZone { get; set; }
public string DefaultPosition { get; set; }

private static PlacementInfo FindDefaultPlacement(string shapeType, string differentiator, string displayType, IBuildShapeContext context)
{
    return null;
}

}

Logs and screenshots

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions