Merge pull request #655 from codeGlaze/refactor/data-extraction

#2 Refactor/data extraction

Author: datdamnzotz

CLAUDE.md

@@ -28,3 +28,4 @@ Before scanning the codebase, read the architecture map and KB index:
 - **`def` vs `defn`** — several key helpers are `def`s (partials/data), not `defn`s. Won't appear in `defn` greps
 - **Shared helper deps dictate placement** — if a shared helper calls X, X must stay shared too, even if X looks domain-specific
 - **`.clj-kondo` is in `.gitignore`** — use `git add -f` to stage kondo config
+- **`::` keywords and data extraction** — `_data.cljc` siblings use `:as-alias` to produce the parent namespace's qualified keywords without circular deps (see `magic_items_data.cljc`)

docs/TODO.md

@@ -74,3 +74,69 @@ jpackage --input target --main-jar orcpub.jar --type exe \
 - Bundle Datomic alongside the app, start as a Windows service (`--win-service`)
 - Package as two installers (app + transactor)
 - Single installer with a launcher script that starts both
+
+## Replace or fork lein-garden
+
+**Status:** Open — future work
+**Severity:** Low (tech debt)
+**Reported:** 2026-02-25
+
+### Problem
+
+`lein-garden` 0.3.0 (last release: 2016) is abandoned. It pins `ns-tracker`
+0.3.0 (2014), which doesn't understand `:as-alias` (Clojure 1.11+) and treats
+it as a real dependency — causing false circular dep errors during AOT.
+
+We work around this with a dependency override (`ns-tracker` 1.0.0 exclusion in
+`project.clj`), but the plugin itself is unmaintained and a liability.
+
+### Options
+
+1. **Maintenance fork** — fork `lein-garden` to `orcpub/lein-garden`, bump
+   `ns-tracker` to 1.0.0, publish to Clojars. Minimal effort, self-hosted.
+2. **Replace with a script** — `lein-garden` is a thin wrapper around
+   `garden.core/css`. A 10-line Leiningen alias or shell script calling
+   `garden.core/css` directly would do the same job with no plugin dependency.
+3. **Migrate to `lambdaisland/garden`** — the Garden CSS library itself is
+   alive (`com.lambdaisland/garden 1.9.606`). Evaluate if the maintained
+   version has its own build tooling.
+
+### Related
+
+- `project.clj` — `:plugins` section, ns-tracker exclusion/override
+- `ns-tracker` 1.0.0 fix: commit `6f508d5` (Sept 2021), released June 2024
+- `lein-garden` last release: 0.3.0, April 2016 — no maintained fork found
+
+## Magic item builder: saving throw bonus dropdown is a dead control
+
+**Status:** Open
+**Severity:** Low (cosmetic)
+**Reported:** 2026-02-25
+
+### Problem
+
+In the homebrew magic item builder, the "Saving Throw Bonus" section renders a
+dropdown per ability — but each dropdown is hardcoded to a single option
+(`"Increases By"`) with no `on-change` handler and no subscription for its value.
+
+Compare with the sibling sections:
+
+| Section | Options | Wired up? |
+|---------|---------|-----------|
+| Ability Bonus | "Becomes At Least", "Increases By" | Yes |
+| Speed Bonus | "Becomes At Least", "Increases By", "Equals Walking Speed" | Yes |
+| Saving Throw Bonus | "Increases By" (only) | **No** |
+
+The number field next to the dropdown works correctly — only the dropdown itself
+is inert.
+
+### Proposed fix
+
+Wire it up — add "Becomes At Least" option with `on-change` dispatch and
+subscription, matching the ability bonus pattern. Even though no SRD item uses
+a saving throw floor, homebrew creators should have the same modifier knobs
+available for saves as they do for abilities and speed.
+
+### Related
+
+- `src/cljs/orcpub/dnd/e5/views/builders/item.cljs` — `item-saving-throw-bonuses` (~line 302)

project.clj

@@ -39,6 +39,11 @@
                  [re-frame "1.4.4"]
                  [reagent "2.0.1"]
                  [com.lambdaisland/garden "1.9.606"]
+                 ;; lein-garden 0.3.0 injects ns-tracker 0.2.2 (^:displace) into
+                 ;; its subprocess classpath. That version doesn't understand
+                 ;; :as-alias (Clojure 1.11+), causing false circular dep errors.
+                 ;; This explicit dep displaces the old version everywhere garden runs.
+                 [ns-tracker "1.0.0"]
                  [org.apache.pdfbox/pdfbox "3.0.6"]
                  ;; Pedestal 0.7.0 uses Jetty 11, which is compatible with figwheel-main's Ring adapter.
                  ;; Pedestal 0.7.1+ and 0.8.x use Jetty 12, causing NoClassDefFoundError: ScopedHandler
@@ -95,6 +100,9 @@
   ;; spawns a subprocess via eval-in-project whose I/O pump hangs in no-TTY.
   ;; See docs/LEIN-UBERJAR-HANG.md
   :plugins [[lein-localrepo "0.5.4"]
+            ;; lein-garden 0.3.0 (2016, abandoned) — see docs/TODO.md
+            ;; "Replace or fork lein-garden" for long-term plan.
+            ;; ns-tracker override is in :dependencies (see comment there).
             [lein-garden "0.3.0"]
             [lein-environ "1.2.0"]
             [dev.weavejester/lein-cljfmt "0.16.0"]