Generic Grain Types cause a NullReference exception in CouchBaseDataManager

[enashed]

When using a generic grain types, I get this exception :

Exc level 0: System.NullReferenceException: Object reference not set to an instance of an object.
   at Orleans.Storage.CouchBaseDataManager.<Read>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Orleans.Storage.BaseJSONStorageProvider.<ReadStateAsync>d__16.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Orleans.Runtime.Scheduler.SchedulerExtensions.<>c__DisplayClass1_0.<<QueueTask>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Orleans.Runtime.Catalog.<SetupActivationState>d__63.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Orleans.Runtime.Catalog.<InitActivation>d__59.MoveNext()	28.17s		

I notice the following line in BaseJSONStorageProvider
var grainTypeName = grainType.Split('.').Last();

So if there a generic argument to the type, it would be something like this:
Foo.Foo[Foo.Bar, Foo, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]

Splitting on the . would not work in this case.

Also because the generic arguments makes the key too long, I can see a possibility to easily exceed 250 characters as a key for Couchbase.

For now I am avoiding any generic grain types, but not sure if there would be a solution in couchbase provider for this problem

[ashkan-saeedi-mazdeh]

@enashed I'll check in Orleans's gitter channel to see how others solved this, I mean how do they store generic type names so it doesn't cause issues because of key being long. I'm sure we can do check if the type is generic then get the type in another way. When I originally wrote this I did the splitting so the type name is not huge with Assembly and namespace and everything added.

Do you think you want/have the time to write the fix if I let you know how to do it?