GT(0) doesn't give a validation error for a `0` input

[carnage-mode]

Before you begin

• I have read the FAQ and my issue was not answered there

What version of Zog are you using
v0.21.6

Describe the bug
zog.Ptr(z.Int32().GT(0)).NotNil() doesnt error out when I supply it a 0 when used to validate

To Reproduce
Since this is a small example I'm providing a gist:
https://gist.github.com/carnage-mode/3a3e32eaa765f5b461c01d47891a211b

Expected behavior
To error out when 0 is supplied as input

[Oudwins]

Hey! Thank you for reporting this!

This is not exactly a bug. Its inherited behaviour from the Int schema because all schemas are optional by default. For example:

z.Int().GT(0).Validate(&0) // this also does't error. Because schema is optional by default and 0 is the default int value so we don't know if the value was provided or not
// You have to do
z.Int().GT(0).Required() // Which then gets you the Required error for 0 which is not ideal and the reason you should be using pointer in most of these cases.

I think the "bug" here is that this is very confusing and that by having a pointer wrapping a value you are already handling the zero value case so it should not be handled again.

I need to think a little bit about the best way to solve this, for now you can just do:

zog.Ptr(z.Int32().GT(0).Required(z.Message("Must be greater than 0")).NotNil()

[carnage-mode]

Thank you for the tip, I would suggest a documentation update for now

[Oudwins]

Umm yes will do. But this is definitively an interesting area. I'm wondering what you think is intuitive for this schema for example

Z. Ptr(z.INT().Default(1))

Sorry for awful code. Casing in mobile is hard