fix(ci): let publish self-restore, bundle package.json for SPA host

Backend: the Ubuntu runner preinstalls newer .NET SDKs that pick up
precedence over our requested 8.0.x, so `dotnet restore` (no RID)
produced an assets file without a linux-x64 target, breaking
`publish -r linux-x64 --no-restore`. Drop the separate restore step
and let publish restore itself; also pin the csproj explicitly to
avoid the solution-level --output warning.

Frontend: bundle a minimal package.json with `pm2 serve . --spa` as
the start script so App Service auto-detects it and runs it — no
reliance on a Portal-configured Startup Command. Loosen the health
check window to tolerate the first cold Oryx build.

Author: Yuval

.github/workflows/cd.yml

@@ -51,14 +51,16 @@ jobs:
         with:
           dotnet-version: "8.0.x"
 
-      - name: Restore
-        run: dotnet restore
-
       # Publish targeting linux-x64 so the output matches the App Service
       # runtime and does NOT include runtimes/win/* (backslash paths in those
       # files have historically corrupted wwwroot on Linux App Service).
+      #
+      # We let `publish` do its own restore here. The Ubuntu runner ships
+      # newer .NET SDKs alongside 8.0, and a prior `dotnet restore` without
+      # an explicit RID produced an assets file that didn't satisfy
+      # `publish -r linux-x64 --no-restore`.
       - name: Publish (linux-x64, framework-dependent)
-        run: dotnet publish -c Release -r linux-x64 --self-contained false -o ./publish-linux --no-restore
+        run: dotnet publish WebApplication1.csproj -c Release -r linux-x64 --self-contained false -o ./publish-linux
 
       # Zip on Linux so path separators are forward slashes. Paired with
       # WEBSITE_RUN_FROM_PACKAGE=1 on the App Service, the deploy mounts the
@@ -114,15 +116,28 @@ jobs:
         env:
           VITE_API_BASE_URL: https://app-groundshare-api.azurewebsites.net/api
 
-      # Zip only the built dist/ so the App Service wwwroot contains the SPA
-      # files at its root. The App Service Startup Command serves them via:
-      #   pm2 serve /home/site/wwwroot --no-daemon --spa
-      # `--spa` makes unmatched routes fall back to index.html so client-side
-      # routing (React Router) works on deep links and page refreshes.
+      # Zip the built dist/ along with a minimal package.json so Azure App
+      # Service (Linux Node) auto-starts it via `npm start`. The start script
+      # uses pm2's built-in static server with `--spa` so unmatched routes
+      # fall back to index.html (required for React Router deep links).
+      #
+      # Doing it this way removes the need to set a Startup Command in the
+      # Portal — the zip is self-describing.
       - name: Package dist
         working-directory: 03-Client
         run: |
-          cd dist
+          cp -r dist deploy-frontend
+          cat > deploy-frontend/package.json <<'JSON'
+          {
+            "name": "groundshare-web",
+            "version": "1.0.0",
+            "private": true,
+            "scripts": {
+              "start": "pm2 serve . --no-daemon --spa"
+            }
+          }
+          JSON
+          cd deploy-frontend
           zip -r ../deploy-frontend.zip .
 
       - name: Deploy to Azure App Service (frontend)
@@ -132,10 +147,12 @@ jobs:
           publish-profile: ${{ secrets.AZURE_WEBAPP_FRONTEND_PUBLISH_PROFILE }}
           package: 03-Client/deploy-frontend.zip
 
+      # First-time Oryx build + pm2 warmup on a cold Free-tier App Service
+      # can take 2-3 minutes. Poll for up to ~4 minutes before failing.
       - name: Health check
         run: |
-          sleep 30
-          for i in 1 2 3 4 5; do
+          sleep 60
+          for i in $(seq 1 12); do
             STATUS=$(curl -s -o /dev/null -w "%{http_code}" https://app-groundshare-web.azurewebsites.net/ || true)
             if [ "$STATUS" = "200" ]; then
               echo "Health check passed"
@@ -144,5 +161,5 @@ jobs:
             echo "Attempt $i: status $STATUS, retrying in 15s..."
             sleep 15
           done
-          echo "Health check failed after 5 attempts"
+          echo "Health check failed"
           exit 1