Merge pull request #49 from Overdrivr/interface-improvements

Interfaces cleanup

Author: Overdrivr

drivers/c/base/driver.h

@@ -15,7 +15,7 @@
     the driver has no more available data
 
 */
-int32_t read(void * buf, uint32_t sizeToRead)
+int32_t read(uint8_t * buf, uint32_t sizeToRead)
 {
     // Exemple
     /*
@@ -40,7 +40,7 @@ int32_t read(void * buf, uint32_t sizeToRead)
   @returns 0 if everything went well.
 
 */
-int32_t write(void * buf, uint32_t sizeToWrite)
+int32_t write(uint8_t * buf, uint32_t sizeToWrite)
 {
     // Exemple
     /*

drivers/cpp/arduino/Telemetry.cpp

@@ -2,12 +2,12 @@
 #include "telemetry_core.h"
 #include "HardwareSerial.h"
 
-int32_t read(void * buf, uint32_t sizeToRead)
+int32_t read(uint8_t * buf, uint32_t sizeToRead)
 {
     return Serial.readBytes((char*)(buf), sizeToRead);
 }
 
-int32_t write(void * buf, uint32_t sizeToWrite)
+int32_t write(uint8_t * buf, uint32_t sizeToWrite)
 {
     Serial.write((char*)(buf),sizeToWrite);
     return 0;

drivers/cpp/base/Telemetry.cpp

@@ -19,7 +19,7 @@
     the driver has no more available data
 
 */
-int32_t read(void * buf, uint32_t sizeToRead)
+int32_t read(uint8_t * buf, uint32_t sizeToRead)
 {
     // Exemple
     /*
@@ -44,7 +44,7 @@ int32_t read(void * buf, uint32_t sizeToRead)
   @returns 0 if everything went well.
 
 */
-int32_t write(void * buf, uint32_t sizeToWrite)
+int32_t write(uint8_t * buf, uint32_t sizeToWrite)
 {
     // Exemple
     /*

drivers/cpp/mbed/Telemetry.cpp

@@ -4,15 +4,15 @@
 
 static BufferedSerial pc(USBTX, USBRX);
 
-int32_t read(void * buf, uint32_t sizeToRead)
+int32_t read(uint8_t * buf, uint32_t sizeToRead)
 {
-    *(uint8_t*)(buf) = pc.getc();
+    buf[0] = pc.getc();
     return 1;
 }
 
-int32_t write(void * buf, uint32_t sizeToWrite)
+int32_t write(uint8_t * buf, uint32_t sizeToWrite)
 {
-    pc.write(buf,sizeToWrite);
+    pc.write((void*)(buf),sizeToWrite);
     return 0;
 }
 

src/telemetry/c/telemetry_core.c

@@ -133,7 +133,7 @@ void subscribe(void (*callback)(TM_state* s, TM_msg* m), TM_state * s)
   userCallback = callback;
 }
 
-void update_telemetry(float elapsedTime)
+void update_telemetry()
 {
   // If user forgot to define transport by calling init_telemetry, abort
   if(!transportPtr)

src/telemetry/headers/telemetry_core.h

@@ -33,6 +33,6 @@ void publish_f32(const char * topic, float msg);
 // second argument is a data structure that you can implement to access your program data inside the function
 void subscribe(void (*callback)(TM_state * s, TM_msg * m), TM_state * s);
 
-void update_telemetry(float elapsedTime);
+void update_telemetry();
 
 #endif

src/telemetry/headers/telemetry_utils.h

@@ -35,9 +35,9 @@ struct TM_msg {
 // Data structure for holding transport interface
 typedef struct TM_transport TM_transport;
 struct TM_transport {
-  int32_t (*read)(void * buf, uint32_t sizeToRead);
+  int32_t (*read)(uint8_t * buf, uint32_t sizeToRead);
   int32_t (*readable)();
-  int32_t (*write)(void * buf, uint32_t sizeToWrite);
+  int32_t (*write)(uint8_t * buf, uint32_t sizeToWrite);
   int32_t (*writeable)();
 };