Move cactbot eslint plugin to separate file

Author: valarnin

eslint.config.ts

@@ -1,19 +1,13 @@
 import js from '@eslint/js';
 import stylisticPlugin from '@stylistic/eslint-plugin';
 import { defineConfig } from 'eslint/config';
-import importPlugin, { flatConfigs as importPluginConfig } from 'eslint-plugin-import-x';
+import { flatConfigs as importPluginConfig } from 'eslint-plugin-import-x';
 import preferArrowFunctionsPlugin from 'eslint-plugin-prefer-arrow-functions';
 import unicornPlugin from 'eslint-plugin-unicorn';
 import globals from 'globals';
 import tseslint from 'typescript-eslint';
 
-import cactbotLocaleOrder from './eslint/cactbot-locale-order';
-import cactbotOutputStrings from './eslint/cactbot-output-strings';
-import cactbotPartyMemberPropertyAccess from './eslint/cactbot-party-member-property-access';
-import cactbotResponseDefaultSeverities from './eslint/cactbot-response-default-severities';
-import cactbotTimelineTriggers from './eslint/cactbot-timeline-triggers';
-import cactbotTriggerPropertyOrder from './eslint/cactbot-trigger-property-order';
-import cactbotTriggersetPropertyOrder from './eslint/cactbot-triggerset-property-order';
+import cactbotLintPlugin from './eslint/plugin';
 
 type Config = ReturnType<typeof defineConfig>[number];
 
@@ -120,20 +114,6 @@ const fixedGoogleConfig: Config = {
   },
 };
 
-// @TODO: Move this to a separate file in eslint folder, convert all these rules to typescript
-type RuleModule = (typeof importPlugin.rules)[string];
-const cactbotLintPlugin = {
-  rules: {
-    'locale-order': cactbotLocaleOrder as unknown as RuleModule,
-    'output-strings': cactbotOutputStrings as unknown as RuleModule,
-    'party-member-property-access': cactbotPartyMemberPropertyAccess as unknown as RuleModule,
-    'response-default-severities': cactbotResponseDefaultSeverities as unknown as RuleModule,
-    'timeline-triggers': cactbotTimelineTriggers as unknown as RuleModule,
-    'trigger-property-order': cactbotTriggerPropertyOrder as unknown as RuleModule,
-    'triggerset-property-order': cactbotTriggersetPropertyOrder as unknown as RuleModule,
-  },
-};
-
 // General rules for all files.
 const rules: Config['rules'] = {
   'arrow-spacing': [

eslint/plugin.ts

@@ -0,0 +1,33 @@
+import { RuleDefinition } from '@eslint/core';
+import { ESLint } from 'eslint';
+
+import cactbotLocaleOrder from './cactbot-locale-order';
+import cactbotOutputStrings from './cactbot-output-strings';
+import cactbotPartyMemberPropertyAccess from './cactbot-party-member-property-access';
+import cactbotResponseDefaultSeverities from './cactbot-response-default-severities';
+import cactbotTimelineTriggers from './cactbot-timeline-triggers';
+import cactbotTriggerPropertyOrder from './cactbot-trigger-property-order';
+import cactbotTriggersetPropertyOrder from './cactbot-triggerset-property-order';
+
+const lintRules: Record<string, RuleDefinition> = {
+  // @ts-expect-error TSESLint and ESLint rule types are structurally incompatible
+  'locale-order': cactbotLocaleOrder,
+  // @ts-expect-error TSESLint and ESLint rule types are structurally incompatible
+  'output-strings': cactbotOutputStrings,
+  // @ts-expect-error TSESLint and ESLint rule types are structurally incompatible
+  'party-member-property-access': cactbotPartyMemberPropertyAccess,
+  // @ts-expect-error TSESLint and ESLint rule types are structurally incompatible
+  'response-default-severities': cactbotResponseDefaultSeverities,
+  // @ts-expect-error TSESLint and ESLint rule types are structurally incompatible
+  'timeline-triggers': cactbotTimelineTriggers,
+  // @ts-expect-error TSESLint and ESLint rule types are structurally incompatible
+  'trigger-property-order': cactbotTriggerPropertyOrder,
+  // @ts-expect-error TSESLint and ESLint rule types are structurally incompatible
+  'triggerset-property-order': cactbotTriggersetPropertyOrder,
+};
+
+const plugin: ESLint.Plugin = {
+  rules: lintRules,
+};
+
+export default plugin;