Skip to content

Commit 72eca77

Browse files
arch/cortex-m: Updated the UserspaceKernelBoundary implementation
Signed-off-by: Ioan-Cristian CÎRSTEA <ioan.cirstea@oxidos.io>
1 parent 84cd8d9 commit 72eca77

1 file changed

Lines changed: 0 additions & 16 deletions

File tree

arch/cortex-m/src/syscall.rs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ use kernel::errorcode::ErrorCode;
1616
use kernel::memory_management::pointers::{
1717
ImmutableKernelVirtualPointer,
1818
ImmutableUserVirtualPointer,
19-
MutableKernelVirtualPointer,
20-
MutableUserVirtualPointer,
2119
};
2220

2321
use crate::CortexMVariant;
@@ -170,18 +168,10 @@ impl<A: CortexMVariant> kernel::syscall::UserspaceKernelBoundary for SysCall<A>
170168
Ok(())
171169
}
172170

173-
fn get_sp(&self, state: &mut Self::StoredState) -> MutableUserVirtualPointer<u8> {
174-
// SAFETY: `esp` is a valid user pointer
175-
unsafe { MutableUserVirtualPointer::new_from_raw(state.psp as *mut u8) }.unwrap()
176-
}
177-
178171
unsafe fn set_syscall_return_value(
179172
&self,
180-
_kernel_accessible_memory_start: &ImmutableKernelVirtualPointer<u8>,
181-
_kernel_app_brk: &ImmutableKernelVirtualPointer<u8>,
182173
user_accessible_memory_start: &ImmutableUserVirtualPointer<u8>,
183174
user_app_brk: &ImmutableUserVirtualPointer<u8>,
184-
_sp: &MutableKernelVirtualPointer<u8>,
185175
state: &mut Self::StoredState,
186176
return_value: kernel::syscall::SyscallReturn,
187177
) -> Result<(), ()> {
@@ -248,11 +238,8 @@ impl<A: CortexMVariant> kernel::syscall::UserspaceKernelBoundary for SysCall<A>
248238
/// In effect, this converts `svc` into `bl callback`.
249239
unsafe fn set_process_function(
250240
&self,
251-
_kernel_accessible_memory_start: &ImmutableKernelVirtualPointer<u8>,
252-
_kernel_app_brk: &ImmutableKernelVirtualPointer<u8>,
253241
user_accessible_memory_start: &ImmutableUserVirtualPointer<u8>,
254242
user_app_brk: &ImmutableUserVirtualPointer<u8>,
255-
_sp: &MutableKernelVirtualPointer<u8>,
256243
state: &mut CortexMStoredState,
257244
callback: kernel::process::FunctionCall,
258245
) -> Result<(), ()> {
@@ -284,11 +271,8 @@ impl<A: CortexMVariant> kernel::syscall::UserspaceKernelBoundary for SysCall<A>
284271

285272
unsafe fn switch_to_process(
286273
&self,
287-
_kernel_accessible_memory_start: &ImmutableKernelVirtualPointer<u8>,
288-
_kernel_app_brk: &ImmutableKernelVirtualPointer<u8>,
289274
user_accessible_memory_start: &ImmutableUserVirtualPointer<u8>,
290275
user_app_brk: &ImmutableUserVirtualPointer<u8>,
291-
_sp: &MutableKernelVirtualPointer<u8>,
292276
state: &mut CortexMStoredState,
293277
) -> (kernel::syscall::ContextSwitchReason, Option<ImmutableUserVirtualPointer<u8>>) {
294278
let user_accessible_memory_start_address = user_accessible_memory_start.get_address();

0 commit comments

Comments
 (0)