Move generateVariablesForScope to functions.

Author: rasmi

functions/package.json

@@ -18,7 +18,7 @@
     "node": "22"
   },
   "config": {
-    "firestore_tests": "src/log.utils.test.ts src/dl_api/experiments.dl_api.integration.test.ts"
+    "firestore_tests": "src/log.utils.test.ts src/dl_api/experiments.dl_api.integration.test.ts src/variables.utils.test.ts"
   },
   "main": "lib/index.js",
   "dependencies": {

functions/src/balanced_assignment.utils.ts

@@ -4,9 +4,9 @@ import {
   MediatorProfileExtended,
   StageConfig,
   createPublicDataFromStageConfigs,
-  generateVariablesForScope,
   VariableScope,
 } from '@deliberation-lab/utils';
+import {generateVariablesForScope} from './variables.utils';
 import {createMediatorsForCohort} from './mediator.utils';
 import {app} from './app';
 
@@ -67,7 +67,7 @@ export async function createCohortInternal(
   }
 
   // Add variable values at the cohort level
-  cohortConfig.variableMap = generateVariablesForScope(
+  cohortConfig.variableMap = await generateVariablesForScope(
     experiment.variableConfigs ?? [],
     {scope: VariableScope.COHORT, experimentId, cohortId: cohortConfig.id},
   );

functions/src/cohort.utils.ts

@@ -13,9 +13,9 @@ import {
   StageConfig,
   createExperimentConfig,
   createExperimentTemplate,
-  generateVariablesForScope,
   VariableScope,
 } from '@deliberation-lab/utils';
+import {generateVariablesForScope} from './variables.utils';
 import {getExperimentDownload} from './data';
 
 import {onCall, HttpsError} from 'firebase-functions/v2/https';
@@ -71,7 +71,7 @@ export const writeExperiment = onCall(async (request) => {
     }
 
     // Add variable values at the experiment level
-    experimentConfig.variableMap = generateVariablesForScope(
+    experimentConfig.variableMap = await generateVariablesForScope(
       experimentConfig.variableConfigs ?? [],
       {scope: VariableScope.EXPERIMENT, experimentId: experimentConfig.id},
     );

functions/src/experiment.endpoints.ts

@@ -15,7 +15,6 @@ import {
   StageConfig,
   TransferStageConfig,
   createParticipantProfileExtended,
-  generateVariablesForScope,
   setProfile,
   VariableScope,
 } from '@deliberation-lab/utils';
@@ -24,7 +23,7 @@ import {
   updateParticipantNextStage,
   handleAutomaticTransfer,
 } from './participant.utils';
-import {generateBalancedAssignmentVariables} from './balanced_assignment.utils';
+import {generateVariablesForScope} from './variables.utils';
 
 import {onCall, HttpsError} from 'firebase-functions/v2/https';
 
@@ -130,8 +129,7 @@ export const createParticipant = onCall(async (request) => {
     participantConfig.currentStageId = experiment.stageIds[0];
 
     // Add variable values at the participant level
-    // First, generate standard participant-scoped variables (static, random permutation)
-    participantConfig.variableMap = generateVariablesForScope(
+    participantConfig.variableMap = await generateVariablesForScope(
       experiment.variableConfigs ?? [],
       {
         scope: VariableScope.PARTICIPANT,
@@ -141,21 +139,6 @@ export const createParticipant = onCall(async (request) => {
       },
     );
 
-    // Then, generate balanced assignment variables (requires database queries)
-    const balancedAssignmentVariables =
-      await generateBalancedAssignmentVariables(
-        experiment.variableConfigs ?? [],
-        data.experimentId,
-        data.cohortId,
-        participantConfig.privateId,
-      );
-
-    // Merge balanced assignment variables into the participant's variable map
-    participantConfig.variableMap = {
-      ...participantConfig.variableMap,
-      ...balancedAssignmentVariables,
-    };
-
     // Write new participant document
     transaction.set(document, participantConfig);
   });