Skip to content

Commit 590993a

Browse files
authored
merge #64 -> develop
[Mod/#64] UI 수정 (홈,회원가입,필터)
2 parents 309dd0c + b639a68 commit 590993a

File tree

9 files changed

+88
-97
lines changed

9 files changed

+88
-97
lines changed

app/src/main/java/com/paw/key/core/designsystem/component/PawkeyButton.kt

Lines changed: 17 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,18 @@
11
package com.paw.key.core.designsystem.component
22

3-
import androidx.compose.foundation.BorderStroke
43
import androidx.compose.foundation.background
54
import androidx.compose.foundation.border
5+
import androidx.compose.foundation.layout.Arrangement
66
import androidx.compose.foundation.layout.Box
77
import androidx.compose.foundation.layout.Column
8-
import androidx.compose.foundation.layout.Spacer
98
import androidx.compose.foundation.layout.fillMaxWidth
10-
import androidx.compose.foundation.layout.height
119
import androidx.compose.foundation.layout.padding
1210
import androidx.compose.foundation.shape.RoundedCornerShape
13-
import androidx.compose.material3.Button
14-
import androidx.compose.material3.ButtonDefaults
1511
import androidx.compose.material3.Text
1612
import androidx.compose.runtime.Composable
1713
import androidx.compose.ui.Alignment
1814
import androidx.compose.ui.Modifier
1915
import androidx.compose.ui.graphics.Color
20-
import androidx.compose.ui.draw.clip
2116
import androidx.compose.ui.tooling.preview.Preview
2217
import androidx.compose.ui.unit.dp
2318
import com.paw.key.core.designsystem.theme.PawKeyTheme
@@ -28,16 +23,16 @@ import com.paw.key.core.util.noRippleClickable
2823
@Composable
2924
private fun PreviewPawkeyButton() {
3025
PawKeyTheme {
31-
Column {
26+
Column (
27+
verticalArrangement = Arrangement.spacedBy(12.dp),
28+
){
3229
// 초록색 버튼
3330
PawkeyButton(
3431
text = "신규 계정으로 회원가입",
3532
enabled = true,
3633
onClick = {}
3734
)
3835

39-
Spacer(modifier = Modifier.height(12.dp))
40-
4136
// 회색 버튼
4237
PawkeyButton(
4338
text = "신규 계정으로 회원가입",
@@ -50,6 +45,7 @@ private fun PreviewPawkeyButton() {
5045
text = "신규 계정으로 회원가입",
5146
enabled = true,
5247
onClick = {},
48+
isBorder = false,
5349
isBackGround = true
5450
)
5551

@@ -99,27 +95,23 @@ fun PawkeyButton(
9995
val borderColor = when {
10096
enabled && isBackGround -> PawKeyTheme.colors.green500
10197
!enabled && isBackGround -> PawKeyTheme.colors.gray200
102-
else -> PawKeyTheme.colors.white1
98+
else -> Color.Transparent
10399
}
104100

105-
Button(
106-
onClick = onClick,
107-
enabled = enabled,
108-
modifier = modifier.fillMaxWidth(),
109-
shape = RoundedCornerShape(8.dp),
110-
colors = ButtonDefaults.buttonColors(
111-
containerColor = backgroundColor,
112-
contentColor = contentColor,
113-
disabledContainerColor = backgroundColor,
114-
disabledContentColor = contentColor
115-
),
116-
border = if (isBackGround) BorderStroke(3.dp, borderColor) else null
101+
Box(
102+
modifier = modifier
103+
.fillMaxWidth()
104+
.background(backgroundColor, shape = RoundedCornerShape(8.dp))
105+
.then(if (isBorder || isBackGround) Modifier.border(1.dp, borderColor, RoundedCornerShape(8.dp)) else Modifier)
106+
.noRippleClickable{ onClick() }
107+
.padding(vertical = 14.dp),
108+
contentAlignment = Alignment.Center
117109
) {
118110
Text(
119111
text = text,
120-
modifier = Modifier
121-
.padding(vertical = 14.dp),
122-
style = PawKeyTheme.typography.body16Sb
112+
style = PawKeyTheme.typography.body16Sb,
113+
color = contentColor
123114
)
124115
}
125116
}
117+

app/src/main/java/com/paw/key/presentation/ui/course/entire/tab/map/List/TabListScreen.kt

Lines changed: 62 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import androidx.compose.foundation.border
55
import androidx.compose.foundation.clickable
66
import androidx.compose.foundation.layout.Arrangement
77
import androidx.compose.foundation.layout.Box
8+
import androidx.compose.foundation.layout.Column
89
import androidx.compose.foundation.layout.Row
910
import androidx.compose.foundation.layout.fillMaxSize
1011
import androidx.compose.foundation.layout.fillMaxWidth
@@ -57,73 +58,78 @@ fun TabListScreen(
5758
) {
5859
var showBottomSheet by remember { mutableStateOf(false) }
5960

60-
LazyColumn(
61-
verticalArrangement = Arrangement.spacedBy(20.dp),
61+
Column(
6262
modifier = modifier
6363
.fillMaxSize()
64-
.background(PawKeyTheme.colors.white2)
65-
.padding(bottom = 36.dp)
66-
6764
) {
68-
item {
69-
Row(
70-
horizontalArrangement = Arrangement.spacedBy(8.dp),
71-
verticalAlignment = Alignment.CenterVertically,
65+
Row(
66+
horizontalArrangement = Arrangement.spacedBy(8.dp),
67+
verticalAlignment = Alignment.CenterVertically,
68+
modifier = Modifier
69+
.fillMaxWidth()
70+
.background(color = PawKeyTheme.colors.white1)
71+
.padding(horizontal = 16.dp, vertical = 11.dp)
72+
) {
73+
Icon(
74+
imageVector = ImageVector.vectorResource(R.drawable.ic_course_optin_filter),
75+
contentDescription = "filter",
76+
tint = Color.Unspecified,
7277
modifier = Modifier
73-
.fillMaxWidth()
74-
.background(color = PawKeyTheme.colors.white1)
75-
.padding(horizontal = 16.dp, vertical = 11.dp)
76-
) {
77-
Icon(
78-
imageVector = ImageVector.vectorResource(R.drawable.ic_course_optin_filter),
79-
contentDescription = "filter",
80-
tint = Color.Unspecified,
81-
modifier = Modifier
82-
.noRippleClickable {
83-
showBottomSheet = true
84-
}
85-
)
86-
OptionChip(
87-
text = "선택한 옵션이 없어요",
88-
isActionChip = true
89-
)
90-
}
91-
}
92-
item {
93-
CourseCard(
94-
title = "제목을 입력해주세요",
95-
petName = "안녕꼬리",
96-
date = "21/1/1"
78+
.noRippleClickable {
79+
showBottomSheet = true
80+
}
9781
)
98-
}
99-
item {
100-
CourseCard(
101-
title = "제목을 입력해주세요",
102-
petName = "안녕꼬리",
103-
date = "21/1/1"
82+
OptionChip(
83+
text = "선택한 옵션이 없어요",
84+
isActionChip = true
10485
)
10586
}
106-
item {
107-
CourseCard(
108-
title = "제목을 입력해주세요",
109-
petName = "안녕꼬리",
110-
date = "21/1/1"
111-
)
87+
88+
LazyColumn(
89+
verticalArrangement = Arrangement.spacedBy(20.dp),
90+
modifier = modifier
91+
.fillMaxSize()
92+
.background(PawKeyTheme.colors.white2)
93+
.padding(bottom = 36.dp)
94+
95+
) {
96+
97+
item {
98+
CourseCard(
99+
title = "제목을 입력해주세요",
100+
petName = "안녕꼬리",
101+
date = "21/1/1"
102+
)
103+
}
104+
item {
105+
CourseCard(
106+
title = "제목을 입력해주세요",
107+
petName = "안녕꼬리",
108+
date = "21/1/1"
109+
)
110+
}
111+
item {
112+
CourseCard(
113+
title = "제목을 입력해주세요",
114+
petName = "안녕꼬리",
115+
date = "21/1/1"
116+
)
117+
}
118+
item {
119+
CourseCard(
120+
title = "제목을 입력해주세요",
121+
petName = "안녕꼬리",
122+
date = "21/1/1"
123+
)
124+
}
112125
}
113-
item {
114-
CourseCard(
115-
title = "제목을 입력해주세요",
116-
petName = "안녕꼬리",
117-
date = "21/1/1"
126+
if (showBottomSheet) {
127+
CourseOptionBottomSheet(
128+
viewModel = viewModel,
129+
onDismissRequest = { showBottomSheet = false }
118130
)
119131
}
120132
}
121-
if (showBottomSheet) {
122-
CourseOptionBottomSheet(
123-
viewModel = viewModel,
124-
onDismissRequest = { showBottomSheet = false }
125-
)
126-
}
127133
}
128134

129135
@Composable

app/src/main/java/com/paw/key/presentation/ui/home/HomeScreen.kt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import androidx.compose.foundation.lazy.LazyColumn
1818
import androidx.compose.material3.Text
1919
import androidx.compose.runtime.Composable
2020
import androidx.compose.runtime.SideEffect
21-
import androidx.compose.runtime.collectAsState
2221
import androidx.compose.runtime.getValue
2322
import androidx.compose.runtime.remember
2423
import androidx.compose.ui.Alignment
@@ -37,9 +36,9 @@ import com.paw.key.core.designsystem.component.CourseCard
3736
import com.paw.key.core.designsystem.theme.PawKeyTheme
3837
import com.paw.key.core.util.noRippleClickable
3938
import com.paw.key.presentation.ui.home.component.DaytimeCard
39+
import com.paw.key.presentation.ui.home.component.HomeTopBar
4040
import com.paw.key.presentation.ui.home.component.RowCalendar
4141
import com.paw.key.presentation.ui.home.component.SettingButton
42-
import com.paw.key.presentation.ui.home.component.TopBar
4342
import com.paw.key.presentation.ui.home.component.TrackingCard
4443
import com.paw.key.presentation.ui.home.component.WeatherCard
4544
import com.paw.key.presentation.ui.home.viewmodel.HomeViewModel
@@ -107,7 +106,7 @@ fun HomeScreen(
107106
.background(color = PawKeyTheme.colors.white2)
108107
.fillMaxSize()
109108
) {
110-
TopBar(location = "강남구 역삼동", onLocationClick = { viewModel.toggleLocationMenu() })
109+
HomeTopBar(location = "강남구 역삼동", onLocationClick = { viewModel.toggleLocationMenu() })
111110

112111
LazyColumn (
113112
verticalArrangement = Arrangement.spacedBy(12.dp),
@@ -185,7 +184,7 @@ fun HomeScreen(
185184
Box(
186185
contentAlignment = Alignment.TopEnd,
187186
modifier = Modifier
188-
.padding(top = 97.dp, start = 250.dp),
187+
.padding(top = 97.dp, start = 240.dp),
189188
) {
190189
SettingButton(
191190
modifier = Modifier

app/src/main/java/com/paw/key/presentation/ui/home/component/TopBar.kt renamed to app/src/main/java/com/paw/key/presentation/ui/home/component/HomeTopBar.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ import com.paw.key.core.designsystem.theme.PawKeyTheme
2727

2828
@Preview
2929
@Composable
30-
private fun PreviewTopBar() {
30+
private fun PreviewHomeTopBar() {
3131
PawKeyTheme {
32-
TopBar(
32+
HomeTopBar(
3333
location = "강남구 역삼동",
3434
onLocationClick = {},
3535
)
@@ -38,15 +38,15 @@ private fun PreviewTopBar() {
3838
}
3939

4040
@Composable
41-
fun TopBar(
41+
fun HomeTopBar(
4242
location: String,
4343
onLocationClick: () -> Unit,
4444
modifier: Modifier = Modifier,
4545
) {
4646
Card(
4747
modifier = modifier
4848
.fillMaxWidth()
49-
.height(97.dp)
49+
.height(46.dp)
5050
.background(color = PawKeyTheme.colors.white1),
5151
shape = RoundedCornerShape(
5252
bottomStart = 15.dp,

app/src/main/java/com/paw/key/presentation/ui/mypage/navigation/SavedCourseNavigation.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,8 @@ fun NavGraphBuilder.savedCourseNavGraph(
2727
) {
2828
composable<SavedCourse> {
2929
SavedCourseRoute(
30-
paddingValues = paddingValues,
3130
navigateUp = navigateUp,
3231
navigateNext = navigateNext,
33-
snackBarHostState = snackBarHostState,
3432
modifier = modifier
3533
)
3634
}

app/src/main/java/com/paw/key/presentation/ui/mypage/navigation/SavedDetailNavigation.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ fun NavGraphBuilder.savedDetailNavGraph(
2727
composable<SavedDetail> {
2828
SavedDetailRoute(
2929
navigateUp = navigateUp,
30-
snackBarHostState = snackBarHostState,
3130
modifier = modifier
3231
)
3332
}

app/src/main/java/com/paw/key/presentation/ui/mypage/navigation/UserProfileNavigation.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,7 @@ fun NavGraphBuilder.userProfileNavGraph(
2424
) {
2525
composable<UserProfile> {
2626
UserProfileRoute(
27-
paddingValues = paddingValues,
2827
navigateUp = navigateUp,
29-
navigateNext = navigateNext,
30-
snackBarHostState = snackBarHostState
3128
)
3229
}
3330
}

app/src/main/java/com/paw/key/presentation/ui/signup/SignUpDogScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,12 @@ fun SignUpDogScreen(
107107

108108
item {
109109
Column(
110-
verticalArrangement = Arrangement.spacedBy(10.dp)
111110
) {
112111
DogGenderSection(
113112
selectedGender = state.dogGender,
114113
onGenderSelected = viewModel::selectDogGender
115114
)
115+
Spacer(modifier = Modifier.height(10.dp))
116116
NeuteringCheckbox(
117117
isNeutered = state.isNeutered,
118118
onToggle = viewModel::toggleNeutering

app/src/main/java/com/paw/key/presentation/ui/signup/SignUpScreen.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ fun SignUpScreen(
117117
state.selectedGender != SignUpContract.Gender.UNKNOWN
118118

119119
PawkeyButton(
120-
text = stringResource(id = R.string.ic_onboarding_signup_name),
120+
text = stringResource(id = R.string.ic_onboarding_signup_button),
121121
enabled = isFormValid,
122122
onClick = {
123123
if (isFormValid) {

0 commit comments

Comments
 (0)