Skip to content

Commit b5b4b3d

Browse files
kariannaLegacyKingVestpokemonpastadependabot[bot]
authored
Karianna's fork of Vests gh_build PR (#7489)
* Fix Choose for Wind Dance Martial Arts Style * Minor fix for Variant Tiefling Ability * Allow 1-hander slashing weapons to qualify for Slashing Grace (Falcata, Khopesh, and Temple Sword) * Remove illegal ’ and convert to proper ' from PRECAMPAIGN tag. * Fixed integration tests related to Startfinder (#6890) * pcGenGUISFmechanicTest: updated sf_mechanic.xml to fix the integration test. The change is related to the commit 765bb11 * Partially reverted the commit ba9759c, because WeakReference lost values for CSKILL object. This is a regression. It is possible, that either SoftReference should be used, or a strong reference. Fixed: pcGenGUISFmechanicTest - after the bug with CSKILL is fixed Fixed: pcGenGUISFsoldierTest - after the bug with CSKILL is fixed * Fix Data Size issues * Fix Orphaned File error * Create stub for Blood of the Ancient - removes an orphan issue and can't find campaign via PRECAMPAIGN issue * DATA-4325 Typo in Inner Sea Races * Fixed a bug, when the OutputPanel couldn't show the file chooser dialog, because the underlying code works in Swing threads only. Now the entire content of the panel is running in JavaFX thread. (#6896) Removed few empty lines. * Bump org.springframework:spring-beans from 6.0.10 to 6.0.11 (#6899) Bumps [org.springframework:spring-beans](https://github.com/spring-projects/spring-framework) from 6.0.10 to 6.0.11. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.0.10...v6.0.11) --- updated-dependencies: - dependency-name: org.springframework:spring-beans dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.springframework:spring-web from 6.0.10 to 6.0.11 (#6898) Bumps [org.springframework:spring-web](https://github.com/spring-projects/spring-framework) from 6.0.10 to 6.0.11. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.0.10...v6.0.11) --- updated-dependencies: - dependency-name: org.springframework:spring-web dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.springframework:spring-core from 6.0.10 to 6.0.11 (#6897) Bumps [org.springframework:spring-core](https://github.com/spring-projects/spring-framework) from 6.0.10 to 6.0.11. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.0.10...v6.0.11) --- updated-dependencies: - dependency-name: org.springframework:spring-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * gradle investigation * Newsource 424 (#6901) * Goldielocks has incorrect value displayed for darkvision in the ability. * NEWSOURCE-424 Starfinder Near Space request * Newsource 435 (#6900) * Goldielocks has incorrect value displayed for darkvision in the ability. * NEWSOURCE-435 Request for Vanguard (Path of Iron - Ascension Games) * Bump org.junit.jupiter:junit-jupiter-params from 5.9.3 to 5.10.0 (#6902) Bumps [org.junit.jupiter:junit-jupiter-params](https://github.com/junit-team/junit5) from 5.9.3 to 5.10.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.9.3...r5.10.0) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-params dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.junit.platform:junit-platform-runner from 1.9.3 to 1.10.0 (#6906) Bumps [org.junit.platform:junit-platform-runner](https://github.com/junit-team/junit5) from 1.9.3 to 1.10.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](https://github.com/junit-team/junit5/commits) --- updated-dependencies: - dependency-name: org.junit.platform:junit-platform-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.junit.jupiter:junit-jupiter-api from 5.9.3 to 5.10.0 (#6905) Bumps [org.junit.jupiter:junit-jupiter-api](https://github.com/junit-team/junit5) from 5.9.3 to 5.10.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.9.3...r5.10.0) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.junit.jupiter:junit-jupiter-engine from 5.9.3 to 5.10.0 (#6903) Bumps [org.junit.jupiter:junit-jupiter-engine](https://github.com/junit-team/junit5) from 5.9.3 to 5.10.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.9.3...r5.10.0) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-engine dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.junit.platform:junit-platform-launcher from 1.9.3 to 1.10.0 (#6904) Bumps [org.junit.platform:junit-platform-launcher](https://github.com/junit-team/junit5) from 1.9.3 to 1.10.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](https://github.com/junit-team/junit5/commits) --- updated-dependencies: - dependency-name: org.junit.platform:junit-platform-launcher dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixed #6901: fixed the Piazo - Near Space cover. (#6907) * Bump org.apache.commons:commons-lang3 from 3.12.0 to 3.13.0 (#6908) Bumps org.apache.commons:commons-lang3 from 3.12.0 to 3.13.0. --- updated-dependencies: - dependency-name: org.apache.commons:commons-lang3 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump edu.sc.seis.launch4j from 3.0.3 to 3.0.4 (#6909) Bumps edu.sc.seis.launch4j from 3.0.3 to 3.0.4. --- updated-dependencies: - dependency-name: edu.sc.seis.launch4j dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump com.github.spotbugs from 5.0.14 to 5.1.0 (#6910) Bumps com.github.spotbugs from 5.0.14 to 5.1.0. --- updated-dependencies: - dependency-name: com.github.spotbugs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump com.github.spotbugs from 5.1.0 to 5.1.1 Bumps com.github.spotbugs from 5.1.0 to 5.1.1. --- updated-dependencies: - dependency-name: com.github.spotbugs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump com.github.spotbugs from 5.1.1 to 5.1.2 (#6912) Bumps com.github.spotbugs from 5.1.1 to 5.1.2. --- updated-dependencies: - dependency-name: com.github.spotbugs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Spaces before tags; symbols we avoid; and outputsheet improvements * Bump com.github.spotbugs from 5.1.2 to 5.1.3 (#6913) Bumps com.github.spotbugs from 5.1.2 to 5.1.3. --- updated-dependencies: - dependency-name: com.github.spotbugs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.apache.xmlgraphics:fop from 2.8 to 2.9 (#6915) Bumps org.apache.xmlgraphics:fop from 2.8 to 2.9. --- updated-dependencies: - dependency-name: org.apache.xmlgraphics:fop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix checkstyle warning * Added initial GH action support * Upgraded gradle wrapper to 8.11.1. * Added testing to gh-action. * First attempt to log data in test. It failed in GH actions. * Added the logging to all tests. * Added gradle cache to a github action setup-java. * Disabled logging, but added the test results upload. * Enabled "write" permissions for test results * Refactored TestHelper.java Added some logging. * Updated cache-dependency-path. * First attempt to cache build/classes and build/jre * Corrected a typo in gradle.yml * Try to clear the cache and fill it with values. * First step to remove NSIS from the distro; Removed explicit System.exit(0) in Main. It allows to enable "slowtest" that generates and compares XMLs. Marked SystemExitInterceptor as deprecated and removal=true. Since Java does not offer any alternative, we have to find a better solution. P.S. NSIS is planned to be removed to use jpackage only. * Performance optimization: the debugPrint (when called frequently) uses StackTrace to determine the logger name. This is expensive and replaced with an explicit logger creation. * Refactored Logging.java. * Upgraded gradle-wrapper from 8.11.1 to 8.12 * Remove .run/ from git repository, because it tracked by mistake in #7056 * Refactored several classes. The main goal was adding the Optional to methods that return null. In some cases, the null reference/result was not checked, but the code never failed, because it was not executed. There were no tests, that is why it was difficult to check, whether the refactoring was right :( * Corrected pf_Cleric test; 1. Corrected the typo in special properties (light crossbow); 2. Corrected maxdex for MAXDEX bonus; * Remove "public" and "abstract" for several interfaces (redundant) * Added more logging to PcgenFtlTestCase.java (it will help to determine the difference between "golden" and generated files). Trimmed lines in base.xml and base-xml.ftl template. * Trimmed different *.xml inputs. Corrected pf_Rogue.xml result: +1 reflex comes from Halfling Luch and +3 from his Cloak. * Updated build.gradle - disable security manager for all Test Gradle "actions" Created a "graceful exit" object + interceptor. It is supposed to replace System.Exit calls in different parts of the project; Updated reporting.gradle by increasing versions of some dependencies; Removed a DM_EXIT rule from spotbugs -> the calls of System.Exit must be replaced with GracefulExit. The decision to create a custom interceptor was taken based on the discussion from Reddit: https://www.reddit.com/r/java/comments/1fpxmfp/jep_486_permanently_disable_the_security_manager/ * Added JavaDoc to Exit* and GracefulExit classes. * Resolved warnings for Gradle 8.12: "Space-assignment syntax in Groovy DSL has been deprecated." * Moved GracefulExit from test to main (util). Replaced few System.exit with GracefulExit.exit calls. Refactored few methods to satisfy SonarQube warnings. * Refactored CommandLineArguments.java to avoid hidden System.exit calls. * Corrected failed int (slow) tests * Corrected a wrong assertion message * Removed SystemExitInterceptor.java, because it was deprecated; Refactored CommandLineArguments and its test. Increased the code coverage. * Added a checkstyle rule that prevents the project from System.exit usage outside GracefulExit. * Use the latest version of Freemarker template engine. * Resolved warnings from Gradle. * Resolved comments from Github PR. Moved a GUI-error message to the localization file. Formatted error messages * JaCoCo was added to github actions - now it shows the high-level code coverage my tests * Create a jpackage build. Signed-off-by: Vest <Vest@users.noreply.github.com> * First attempt to build releases for all OSes. Signed-off-by: Vest <Vest@users.noreply.github.com> * Changed the event to build a release conditionally. Signed-off-by: Vest <Vest@users.noreply.github.com> * Update gradle-release.yml * Corrected the artifact name Signed-off-by: Vest <Vest@users.noreply.github.com> * Attempt to create releases Signed-off-by: Vest <Vest@users.noreply.github.com> * Attempt to create releases (v2) Signed-off-by: Vest <Vest@users.noreply.github.com> * Corrected the artifact creation. Signed-off-by: Vest <Vest@users.noreply.github.com> * Attempt to create one more release Signed-off-by: Vest <Vest@users.noreply.github.com> * Updated JDK from 21.0.5 to 21.0.6 Signed-off-by: Vest <Vest@users.noreply.github.com> * Corrected a build for Windows (at least). gradle jpackageImage Signed-off-by: Vest <Vest@users.noreply.github.com> * Added ubuntu-24-arm Signed-off-by: Vest <Vest@users.noreply.github.com> * Added a hotfix to repair linux-arm build. Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Gradle wrapper to version 8.13 and fix output formatting in gradlew Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Gradle wrapper to version 8.14 Signed-off-by: Vest <Vest@users.noreply.github.com> * Removed jar-export-plugins from pluginbuild.xml Added the same task to plugins.gradle Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Appveyor config to adjust Gradle commands and formatting Removed the `buildNsis` task from the Gradle `test_script`, streamlining the build process. Additionally, fixed unnecessary trailing spaces in multiple sections for better formatting consistency. These changes simplify the CI process and improve readability. Signed-off-by: Vest <Vest@users.noreply.github.com> * Remove Ant-based build files for Gradle-only build system This commit deletes `build-gradle.xml` and `pluginbuild.xml` as they are no longer required. The transition to a Gradle-based build system eliminates dependency on Ant, simplifying the build process. Signed-off-by: Vest <Vest@users.noreply.github.com> * Update properties and refine Gradle plugin Jar tasks Added a new warning message for remote list preferences in properties. Improved Gradle tasks to include all nested class files for export and bonus plugins, ensuring more comprehensive builds. Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactor code style by removing unnecessary whitespace and updating method signatures in PCGenTaskExecutor and PluginLoader Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactored and changed files that didn't pass ```gradle checkstyleMain``` Few recent pull requests broke the styling: #7319 Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactored and changed files that didn't pass ```gradle checkstyleMain``` Few recent pull requests broke the styling: #7319 Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactor PluginClassLoader Signed-off-by: Vest <Vest@users.noreply.github.com> * Add plugins.gradle to Gradle configuration for release and test workflows Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Gradle wrapper to version 9.0.0 and fix classpath configuration in wrapper scripts Signed-off-by: Vest <Vest@users.noreply.github.com> * Update JavaFX version to 21.0.8 and improve URIFactory error handling with new tests Signed-off-by: Vest <Vest@users.noreply.github.com> * Improve README formatting and grammar for clarity and consistency Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactor test task configurations to use correct directory paths for test classes Signed-off-by: Vest <Vest@users.noreply.github.com> * Set name and description for code review agent Updated agent metadata with name and description. * Create Security Review Agent documentation Adds a new agent for security review of code. * Rename my-agent.md to my-code-review-agent.md * Changed PluginBuildTest, because the new plugins are built from corresponding .java files. The slow test has been reverted, because it was broken in old commits (DATA-4372) Signed-off-by: Vest <Vest@users.noreply.github.com> * Updated Java to 21.0.8 (mac aarch64) Gradle wrapper to 9.1.0 Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Gradle wrapper to version 9.2.0 and refactor dependency declarations to avoid Gradle's warnings. Such constructions will be deprecated in Gradle 10. Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Java&JavaFX to 25.0.1 and JaCoCo to 0.8.14 versions in build.gradle Signed-off-by: Vest <Vest@users.noreply.github.com> * Add native access flags for JavaFX modules in distribution.gradle Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactor JavaFX resource loading by introducing PanelFromResource utility class Signed-off-by: Vest <Vest@users.noreply.github.com> * Reverted a part of #7462, that broke DescriptionTest. Signed-off-by: Vest <Vest@users.noreply.github.com> * Update FXML files to use JavaFX 25.0.1 namespace Signed-off-by: Vest <Vest@users.noreply.github.com> * Corrected checkstyle findings Signed-off-by: Vest <Vest@users.noreply.github.com> * Added initial GH action support * Upgraded gradle wrapper to 8.11.1. * Added testing to gh-action. * First attempt to log data in test. It failed in GH actions. * Added the logging to all tests. * Added gradle cache to a github action setup-java. * Disabled logging, but added the test results upload. * Enabled "write" permissions for test results * Refactored TestHelper.java Added some logging. * Updated cache-dependency-path. * First attempt to cache build/classes and build/jre * Corrected a typo in gradle.yml * Try to clear the cache and fill it with values. * First step to remove NSIS from the distro; Removed explicit System.exit(0) in Main. It allows to enable "slowtest" that generates and compares XMLs. Marked SystemExitInterceptor as deprecated and removal=true. Since Java does not offer any alternative, we have to find a better solution. P.S. NSIS is planned to be removed to use jpackage only. * Performance optimization: the debugPrint (when called frequently) uses StackTrace to determine the logger name. This is expensive and replaced with an explicit logger creation. * Refactored Logging.java. * Upgraded gradle-wrapper from 8.11.1 to 8.12 * Remove .run/ from git repository, because it tracked by mistake in #7056 * Refactored several classes. The main goal was adding the Optional to methods that return null. In some cases, the null reference/result was not checked, but the code never failed, because it was not executed. There were no tests, that is why it was difficult to check, whether the refactoring was right :( * Updated PMD to 7.17 Added many rules to ruleset.xml Fixed few warnings Enabled config-cache for testing purposes. Signed-off-by: Vest <Vest@users.noreply.github.com> * Corrected pf_Cleric test; 1. Corrected the typo in special properties (light crossbow); 2. Corrected maxdex for MAXDEX bonus; * Remove "public" and "abstract" for several interfaces (redundant) * Added more logging to PcgenFtlTestCase.java (it will help to determine the difference between "golden" and generated files). Trimmed lines in base.xml and base-xml.ftl template. * Trimmed different *.xml inputs. Corrected pf_Rogue.xml result: +1 reflex comes from Halfling Luch and +3 from his Cloak. * Updated build.gradle - disable security manager for all Test Gradle "actions" Created a "graceful exit" object + interceptor. It is supposed to replace System.Exit calls in different parts of the project; Updated reporting.gradle by increasing versions of some dependencies; Removed a DM_EXIT rule from spotbugs -> the calls of System.Exit must be replaced with GracefulExit. The decision to create a custom interceptor was taken based on the discussion from Reddit: https://www.reddit.com/r/java/comments/1fpxmfp/jep_486_permanently_disable_the_security_manager/ * Added JavaDoc to Exit* and GracefulExit classes. * Resolved warnings for Gradle 8.12: "Space-assignment syntax in Groovy DSL has been deprecated." * Moved GracefulExit from test to main (util). Replaced few System.exit with GracefulExit.exit calls. Refactored few methods to satisfy SonarQube warnings. * Refactored CommandLineArguments.java to avoid hidden System.exit calls. * Corrected failed int (slow) tests * Corrected a wrong assertion message * Removed SystemExitInterceptor.java, because it was deprecated; Refactored CommandLineArguments and its test. Increased the code coverage. * Added a checkstyle rule that prevents the project from System.exit usage outside GracefulExit. * Use the latest version of Freemarker template engine. * Resolved warnings from Gradle. * Resolved comments from Github PR. Moved a GUI-error message to the localization file. Formatted error messages * JaCoCo was added to github actions - now it shows the high-level code coverage my tests * Create a jpackage build. Signed-off-by: Vest <Vest@users.noreply.github.com> * First attempt to build releases for all OSes. Signed-off-by: Vest <Vest@users.noreply.github.com> * Changed the event to build a release conditionally. Signed-off-by: Vest <Vest@users.noreply.github.com> * Update gradle-release.yml * Corrected the artifact name Signed-off-by: Vest <Vest@users.noreply.github.com> * Attempt to create releases Signed-off-by: Vest <Vest@users.noreply.github.com> * Attempt to create releases (v2) Signed-off-by: Vest <Vest@users.noreply.github.com> * Corrected the artifact creation. Signed-off-by: Vest <Vest@users.noreply.github.com> * Attempt to create one more release Signed-off-by: Vest <Vest@users.noreply.github.com> * Updated JDK from 21.0.5 to 21.0.6 Signed-off-by: Vest <Vest@users.noreply.github.com> * Corrected a build for Windows (at least). gradle jpackageImage Signed-off-by: Vest <Vest@users.noreply.github.com> * Added ubuntu-24-arm Signed-off-by: Vest <Vest@users.noreply.github.com> * Added a hotfix to repair linux-arm build. Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Gradle wrapper to version 8.13 and fix output formatting in gradlew Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Gradle wrapper to version 8.14 Signed-off-by: Vest <Vest@users.noreply.github.com> * Removed jar-export-plugins from pluginbuild.xml Added the same task to plugins.gradle Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Appveyor config to adjust Gradle commands and formatting Removed the `buildNsis` task from the Gradle `test_script`, streamlining the build process. Additionally, fixed unnecessary trailing spaces in multiple sections for better formatting consistency. These changes simplify the CI process and improve readability. Signed-off-by: Vest <Vest@users.noreply.github.com> * Remove Ant-based build files for Gradle-only build system This commit deletes `build-gradle.xml` and `pluginbuild.xml` as they are no longer required. The transition to a Gradle-based build system eliminates dependency on Ant, simplifying the build process. Signed-off-by: Vest <Vest@users.noreply.github.com> * Update properties and refine Gradle plugin Jar tasks Added a new warning message for remote list preferences in properties. Improved Gradle tasks to include all nested class files for export and bonus plugins, ensuring more comprehensive builds. Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactor code style by removing unnecessary whitespace and updating method signatures in PCGenTaskExecutor and PluginLoader Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactored and changed files that didn't pass ```gradle checkstyleMain``` Few recent pull requests broke the styling: #7319 Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactored and changed files that didn't pass ```gradle checkstyleMain``` Few recent pull requests broke the styling: #7319 Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactor PluginClassLoader Signed-off-by: Vest <Vest@users.noreply.github.com> * Add plugins.gradle to Gradle configuration for release and test workflows Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Gradle wrapper to version 9.0.0 and fix classpath configuration in wrapper scripts Signed-off-by: Vest <Vest@users.noreply.github.com> * Update JavaFX version to 21.0.8 and improve URIFactory error handling with new tests Signed-off-by: Vest <Vest@users.noreply.github.com> * Improve README formatting and grammar for clarity and consistency Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactor test task configurations to use correct directory paths for test classes Signed-off-by: Vest <Vest@users.noreply.github.com> * Changed PluginBuildTest, because the new plugins are built from corresponding .java files. The slow test has been reverted, because it was broken in old commits (DATA-4372) Signed-off-by: Vest <Vest@users.noreply.github.com> * Updated Java to 21.0.8 (mac aarch64) Gradle wrapper to 9.1.0 Signed-off-by: Vest <Vest@users.noreply.github.com> * DATA-4380 - 3.5e - Enable Jack Of All Trades to display 'Untrained' class skills * DATA-4379 - d20 modern, taking magical heritage, the 3 cantrips aren't selectable 6.08.00 rc10 * DATA-4381 - PF1e - Racial Heritage in Mythic not implemented * DATA-4381 - PF1e - Racial Heritage in Mythic not implemented * DATA-4383 PF1e Human Racial Heritage feat should only allow Humanoids; it currently allows any playable race * DATA-4384 Pf1e - Racial Heritage does not set RACESUBTYPE therefore all feats looking for a specific race do not qualify. Phase 1: Switch from "Racial Heritage ~ xxx" as a global to "Race ~ xxx" leaving Racial Heritage to correctly reference those qualifying for the Racial Heritage feat. * DATA-4384 Pf1e - Racial Heritage does not set RACESUBTYPE therefore all feats looking for a specific race do not qualify. Phase 2: Change PRERACE to PREFACT to simplify qualification as a Race and also clean up the RaceName%,SUBRACETYPE= vs RaceName,SUBRACETYPE= vs. RaceName% vs. RaceName entries. * Bump com.github.spotbugs from 6.4.2 to 6.4.4 (#7453) Bumps com.github.spotbugs from 6.4.2 to 6.4.4. --- updated-dependencies: - dependency-name: com.github.spotbugs dependency-version: 6.4.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.springframework:spring-beans from 6.2.11 to 6.2.12 (#7446) Bumps [org.springframework:spring-beans](https://github.com/spring-projects/spring-framework) from 6.2.11 to 6.2.12. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.11...v6.2.12) --- updated-dependencies: - dependency-name: org.springframework:spring-beans dependency-version: 6.2.12 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump com.github.spotbugs:spotbugs-annotations from 4.9.6 to 4.9.8 (#7452) Bumps [com.github.spotbugs:spotbugs-annotations](https://github.com/spotbugs/spotbugs) from 4.9.6 to 4.9.8. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](spotbugs/spotbugs@4.9.6...4.9.8) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs-annotations dependency-version: 4.9.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * DATA-4385 Pf1e - Improve descriptions for some equipment modifiers to indicate they are conditional * 6.09.info (#7459) * support HASINFO and INFO tags * INFO tags are case insensitive * 6.09.info (#7462) * support HASINFO and INFO tags * INFO tags are case insensitive * INFO tag used explicitly rather than trying to override DESC tag * 6.09.info (#7463) * support HASINFO and INFO tags * INFO tags are case insensitive * INFO tag used explicitly rather than trying to override DESC tag * return an empty string if the INFO tag does not exist * 6.09.info (#7464) * support HASINFO and INFO tags * INFO tags are case insensitive * INFO tag used explicitly rather than trying to override DESC tag * return an empty string if the INFO tag does not exist * do not try INFO string for DESC tags unless specified * 6.09.info (#7465) * support HASINFO and INFO tags * INFO tags are case insensitive * INFO tag used explicitly rather than trying to override DESC tag * return an empty string if the INFO tag does not exist * do not try INFO string for DESC tags unless specified * checking for equality with a String * Update Gradle wrapper to version 9.2.0 and refactor dependency declarations to avoid Gradle's warnings. Such constructions will be deprecated in Gradle 10. Signed-off-by: Vest <Vest@users.noreply.github.com> * Update Java&JavaFX to 25.0.1 and JaCoCo to 0.8.14 versions in build.gradle Signed-off-by: Vest <Vest@users.noreply.github.com> * Add native access flags for JavaFX modules in distribution.gradle Signed-off-by: Vest <Vest@users.noreply.github.com> * Refactor JavaFX resource loading by introducing PanelFromResource utility class Signed-off-by: Vest <Vest@users.noreply.github.com> * Reverted a part of #7462, that broke DescriptionTest. Signed-off-by: Vest <Vest@users.noreply.github.com> * Update FXML files to use JavaFX 25.0.1 namespace Signed-off-by: Vest <Vest@users.noreply.github.com> * Fix remnant issues from PREFACT conversion with multiples lingering from PRERACE * Clean up * Fix Non-Monk getting Wisdom bonus. * Fix a bunch of minor formatting errors in pcc files * Some textual improvements and typo fixes. * Corrected checkstyle findings Signed-off-by: Vest <Vest@users.noreply.github.com> * Upgrade to Java 25 and fix lots of typos * Revert failing MULT:YES and fix var name in build script * Fix merge conflicts in GH actions * Disable configuration cache for now * Update dependencies * Now correctly creates images, also allows build to continue on finding PMD violations * Add LLM AGENT guidance * Update pcgen version to match what we are releasing next * Use previous way to release and apply to GH Actions * Fix { * Linter fixes --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Vest <Vest@users.noreply.github.com> Co-authored-by: LegacyKing <drew0500@yahoo.com> Co-authored-by: Vest <Vest@users.noreply.github.com> Co-authored-by: pokemonpasta <pokemonpasta1000@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mertonmonk <33469335+mertonmonk@users.noreply.github.com> Co-authored-by: Cullen Walsh <ckwalsh@cullenwalsh.com> Co-authored-by: AtlasHackert <danielpharos@hotmail.com>
1 parent e02d4fd commit b5b4b3d

204 files changed

Lines changed: 3682 additions & 11155 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
name: Code Review Agent
3+
description: Agent that specilises in code reviews, digging into the why of the change.
4+
---
5+
6+
# My Agent
7+
8+
Agent that specilises in code reviews, digging into the why of the change.
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
name: Security Review Agent
3+
description: Security Review Agent
4+
---
5+
6+
# My Agent
7+
8+
Reviews the code for security vulnerabilities and bad coding practices.
Lines changed: 121 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
1+
name: Create Release
2+
3+
on:
4+
push:
5+
tags:
6+
- "v*.*.*"
7+
8+
permissions:
9+
contents: write
10+
11+
jobs:
12+
create_release:
13+
name: Create Release
14+
runs-on: ubuntu-latest
15+
steps:
16+
- name: Create Release
17+
id: create_release
18+
uses: softprops/action-gh-release@v2
19+
with:
20+
name: ${{ github.ref_name }}
21+
draft: false
22+
prerelease: false
23+
generate_release_notes: false
24+
25+
build_release:
26+
name: Build Release
27+
needs: create_release
28+
strategy:
29+
matrix:
30+
os: [ubuntu-latest, ubuntu-24.04-arm, macos-latest, windows-latest]
31+
include:
32+
- os: ubuntu-latest
33+
release_suffix: ubuntu
34+
- os: ubuntu-24.04-arm
35+
release_suffix: ubuntu-arm
36+
- os: macos-latest
37+
release_suffix: mac
38+
- os: windows-latest
39+
release_suffix: windows
40+
# windows-arm removed - no GitHub-hosted runner available yet
41+
runs-on: ${{ matrix.os }}
42+
steps:
43+
- uses: actions/checkout@v4
44+
45+
- name: Set up JDK 25
46+
uses: actions/setup-java@v4
47+
with:
48+
java-version: '25'
49+
distribution: 'temurin'
50+
cache: gradle
51+
cache-dependency-path: |
52+
build.gradle
53+
code/gradle/autobuild.gradle
54+
code/gradle/distribution.gradle
55+
code/gradle/release.gradle
56+
code/gradle/reporting.gradle
57+
code/gradle/plugins.gradle
58+
59+
# Configure Gradle for optimal use in GitHub Actions, including caching of downloaded dependencies.
60+
# See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md
61+
- name: Setup Gradle
62+
uses: gradle/actions/setup-gradle@v4
63+
with:
64+
cache-disabled: false
65+
cache-read-only: false
66+
cache-overwrite-existing: true
67+
68+
- uses: actions/cache@v4
69+
with:
70+
path: |
71+
${{ github.workspace }}/build/jre
72+
${{ github.workspace }}/build/libs
73+
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
74+
restore-keys: |
75+
${{ matrix.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
76+
${{ matrix.os }}-gradle
77+
78+
- name: Build the image
79+
if: success()
80+
run: ./gradlew clean build copyToOutput test compileSlowtest datatest pfinttest allReports buildDist prepareRelease pcgenRelease
81+
82+
- name: Upload zip based release assets for all platforms
83+
uses: actions/upload-artifact@v4
84+
if: matrix.os == 'macos-latest'
85+
with:
86+
name: ${{ matrix.os }}-zip
87+
path: ${{ github.workspace }}/build/release/image-*.zip
88+
89+
- name: Upload DMG release asset for macos
90+
uses: actions/upload-artifact@v4
91+
if: matrix.os == 'macos-latest'
92+
with:
93+
name: ${{ matrix.os }}-dmg
94+
path: ${{ github.workspace }}/build/release/*.dmg
95+
96+
- name: Upload PKG release asset for macos
97+
uses: actions/upload-artifact@v4
98+
if: matrix.os == 'macos-latest'
99+
with:
100+
name: ${{ matrix.os }}-pkg
101+
path: ${{ github.workspace }}/build/release/*.pkg
102+
103+
# - name: Upload release assets for ubuntu
104+
# uses: actions/upload-artifact@v4
105+
# if: matrix.os == 'ubuntu-latest'
106+
# with:
107+
# name: ${{ matrix.os }}
108+
# path: ${{ github.workspace }}/build/jpackage/*.deb
109+
#
110+
# - name: Upload release assets for windows
111+
# uses: actions/upload-artifact@v4
112+
# if: matrix.os == 'windows-latest'
113+
# with:
114+
# name: ${{ matrix.os }}
115+
# path: ${{ github.workspace }}/build/jpackage/*.msi
116+
#
117+
# - name: Release - ${{ matrix.os }}
118+
# uses: softprops/action-gh-release@v2
119+
# with:
120+
# tag_name: ${{ needs.create_release.outputs.tag-name }}
121+
# files: ${{ github.workspace }}/build/release/pcgen-*.*

.github/workflows/gradle-test.yml

Lines changed: 91 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,91 @@
1+
# This workflow will build a Java project with Gradle and cache/restore any dependencies to improve the workflow execution time
2+
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-gradle
3+
4+
name: Build PCGen with Gradle
5+
6+
on:
7+
pull_request:
8+
9+
jobs:
10+
build:
11+
12+
runs-on: ubuntu-latest
13+
permissions:
14+
checks: write
15+
pull-requests: write
16+
17+
steps:
18+
- uses: actions/checkout@v4
19+
20+
- name: Set up JDK 25
21+
uses: actions/setup-java@v4
22+
with:
23+
java-version: '25'
24+
distribution: 'temurin'
25+
cache: gradle
26+
cache-dependency-path: |
27+
build.gradle
28+
code/gradle/autobuild.gradle
29+
code/gradle/distribution.gradle
30+
code/gradle/release.gradle
31+
code/gradle/reporting.gradle
32+
code/gradle/plugins.gradle
33+
34+
# Configure Gradle for optimal use in GitHub Actions, including caching of downloaded dependencies.
35+
# See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md
36+
- name: Setup Gradle
37+
uses: gradle/actions/setup-gradle@v4
38+
with:
39+
cache-disabled: false
40+
cache-read-only: false
41+
cache-overwrite-existing: true
42+
43+
- uses: actions/cache@v4
44+
with:
45+
path: |
46+
${{ github.workspace }}/build/jre
47+
${{ github.workspace }}/build/libs
48+
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
49+
restore-keys: |
50+
${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }}
51+
${{ runner.os }}-gradle
52+
53+
- name: Build with Gradle Wrapper
54+
run: ./gradlew build
55+
56+
- name: Run tests
57+
run: ./gradlew test itest datatest slowtest
58+
59+
- name: Publish Test Results
60+
uses: EnricoMi/publish-unit-test-result-action@v2
61+
if: always()
62+
with:
63+
files: |
64+
build/test-results/**/*.xml
65+
build/test-results/**/*.trx
66+
build/test-results/**/*.json
67+
68+
- name: Run Coverage
69+
run: ./gradlew testCoverage
70+
71+
- name: Upload Report to artifacts
72+
uses: actions/upload-artifact@v4
73+
with:
74+
name: testCoverage
75+
path: ${{ github.workspace }}/build/reports/jacoco/testCoverage/html
76+
77+
- name: Jacoco Report to PR
78+
id: jacoco
79+
uses: madrapps/jacoco-report@v1.7.2
80+
with:
81+
paths: |
82+
${{ github.workspace }}/build/reports/jacoco/testCoverage/testCoverage.xml
83+
token: ${{ secrets.GITHUB_TOKEN }}
84+
title: '## :construction: PCGen Code Coverage'
85+
update-comment: true
86+
debug-mode: false
87+
88+
- name: Get the Coverage info
89+
run: |
90+
echo "Total coverage ${{ steps.jacoco.outputs.coverage-overall }}"
91+
echo "Changed Files coverage ${{ steps.jacoco.outputs.coverage-changed-files }}"

.github/workflows/gradle.yml

Lines changed: 0 additions & 19 deletions
This file was deleted.

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
.settings/
66
/settings/
77

8+
testsuite/
9+
810
# Batch converter
911
batch-convert.jar
1012

@@ -94,6 +96,7 @@ code/build.eclipse/
9496

9597
# IntelliJ IDE
9698
.idea/
99+
.run/
97100
out/
98101
pcgendev.iml
99102
pcgen.iml

.run/Main.run.xml

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)