Walk XML children once when filtering by tag

childElements(parent, tag) used to call childElements(parent) and
filter the resulting list, traversing the NodeList twice. Inline the
filter so each call walks the children once. Also drop the pre-sized
ArrayList in childElements(parent) — Stream.toList() returns a
right-sized immutable list directly.

Author: Vest

code/src/java/pcgen/core/namegen/NameGenDataLoader.java

@@ -203,18 +203,20 @@ private static void loadCategory(Element category, RuleSet rs, Map<String, List<
 	private static List<Element> childElements(Element parent)
 	{
 		NodeList nodes = parent.getChildNodes();
-		List<Element> out = new ArrayList<>(nodes.getLength());
-		IntStream.range(0, nodes.getLength())
+		return IntStream.range(0, nodes.getLength())
 				.mapToObj(nodes::item)
 				.filter(n -> n.getNodeType() == Node.ELEMENT_NODE)
 				.map(Element.class::cast)
-				.forEach(out::add);
-		return out;
+				.toList();
 	}
 
 	private static List<Element> childElements(Element parent, String tagName)
 	{
-		return childElements(parent).stream()
+		NodeList nodes = parent.getChildNodes();
+		return IntStream.range(0, nodes.getLength())
+				.mapToObj(nodes::item)
+				.filter(n -> n.getNodeType() == Node.ELEMENT_NODE)
+				.map(Element.class::cast)
 				.filter(e -> tagName.equals(e.getTagName()))
 				.toList();
 	}