关于modlaunch.vb中,classpath构造阶段对cleanroom的处理代码问题 #2760
qiMengStars
started this conversation in
讨论
Replies: 1 comment 4 replies
-
|
@Pigeon0v0 大佬打扰了,但是真的挺好奇的,我看这段代码是你加的就直接@了 PCL-CE/Plain Craft Launcher 2/Modules/Minecraft/ModLaunch.cs Lines 2894 to 2896 in c241fdd 按道理来说,它永远都不会命中,自然也不会有用,但是我没敢在pr里删 此外我问了一下某位cleanroom维护者,他说cleanroom并没要求过在classpath中的位置 可以解释一下它是确实在解决一些早期问题,还是说已经没用了吗,谢谢 |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
如题,在modlaunch.vb中,有这样一段代码:
PCL-CE/Plain Craft Launcher 2/Modules/Minecraft/ModLaunch.vb
Lines 2059 to 2061 in c241fdd
它被添加于feat(modpack): MMC JSON-Patches 支持
按照注释来看,Library.Name应当不包含版本号
这意味着,这个精确到0.2版本号的if判断应当始终不会为true,因而它也从来不会执行
是有什么我没注意到的地方吗
Beta Was this translation helpful? Give feedback.
All reactions