Add OpenBSD and very old RHEL autoconf 2.69 CI builds (#822)

Also raise minimum Autoconf requirement to 2.69 to match what we test.

Author: NWilson

.github/workflows/build.yml

@@ -14,6 +14,7 @@ on:
         - macos
         - windows
         - freebsd
+        - openbsd
         - solaris
         - zos
         - distcheck
@@ -343,6 +344,63 @@ jobs:
             ../maint/RunManifestTest install-dir ../maint/manifest-cmakeinstall-freebsd
             ../maint/RunSymbolTest install-dir/lib/ ../maint/
 
+  openbsd:
+    name: OpenBSD
+    runs-on: ubuntu-latest
+    if: |
+      (github.event_name == 'workflow_dispatch' && (inputs.job_id == 'all' || inputs.job_id == 'openbsd')) ||
+      github.event_name == 'push'
+    steps:
+      - name: Checkout
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        with:
+          submodules: true
+
+      - name: Prepare
+        run: ./autogen.sh
+
+      - name: Build & test
+        uses: vmactions/openbsd-vm@1e7cc4fa7727646d3cf5921289b1f5c9d1a88f3c # v1.2.0
+        with:
+          envs: 'CFLAGS_GCC_STYLE CMAKE_FLAGS'
+          usesh: true
+          prepare: |
+            set -e
+            pkg_add cmake
+
+          run: |
+            set -e
+
+            export MALLOC_OPTIONS="USRJGFC>>"
+            EXTRA_CFLAGS="-DSLJIT_WX_EXECUTABLE_ALLOCATOR"
+
+            cp -rp . ../build-autoconf
+            cp -rp . ../build-cmake
+
+            echo "== Autoconf =="
+            cd ../build-autoconf
+
+            ./configure CFLAGS="$CFLAGS_GCC_STYLE $EXTRA_CFLAGS" --enable-jit --enable-pcre2-16 --enable-pcre2-32 --enable-Werror
+            make -j3
+            (make check; rc=$?; for i in test-suite.log Run*Test.log pcre2*_test.log; do echo "== $i =="; cat $i; done; exit $rc)
+
+            make install "DESTDIR=`pwd`/install-dir"
+            # I don't really know enough about OpenBSD to say whether the unusually-numbered .so files
+            # with no symlinks are correct or not.
+            # maint/RunManifestTest install-dir maint/manifest-makeinstall-openbsd
+            # maint/RunSymbolTest install-dir/usr/local/lib/ maint/
+
+            echo "== CMake =="
+            cd ../build-cmake
+
+            cmake $CMAKE_FLAGS -DPCRE2_SUPPORT_JIT=ON -DPCRE2_BUILD_PCRE2_16=ON -DPCRE2_BUILD_PCRE2_32=ON -DBUILD_SHARED_LIBS=ON -DBUILD_STATIC_LIBS=ON -DPCRE2_DEBUG=ON -DCMAKE_C_FLAGS="$CFLAGS_GCC_STYLE $EXTRA_CFLAGS" -DCMAKE_COMPILE_WARNING_AS_ERROR=ON -DCMAKE_BUILD_TYPE=Release -B build
+            cd build
+            make -j3
+            ctest -j3 --output-on-failure && (cat ./Testing/Temporary/LastTest.log || true)
+            cmake --install . --prefix install-dir
+            # ../maint/RunManifestTest install-dir ../maint/manifest-cmakeinstall-openbsd
+            # ../maint/RunSymbolTest install-dir/lib/ ../maint/
+
   solaris:
     name: Solaris
     runs-on: ubuntu-latest

.github/workflows/dev.yml

@@ -13,6 +13,7 @@ on:
         - dragon
         - greatawk
         - dodo
+        - passenger
         - wasp
         - bat
         - pterodactyl
@@ -176,7 +177,7 @@ jobs:
           done
 
   dodo:
-    # Tests with: Autconf on oldest supported Ubuntu (in non-extended support)
+    # Tests with: Autoconf on oldest supported Ubuntu (in non-extended support)
     name: GCC -Os, old Autotools
     runs-on: ubuntu-latest
     container: ubuntu:22.04
@@ -212,6 +213,44 @@ jobs:
           maint/RunManifestTest install-dir maint/manifest-makeinstall-linux
           maint/RunSymbolTest install-dir/usr/local/lib/ maint/
 
+  passenger:
+    # Tests with: Autoconf on oldest RHEL (in extended support).
+    # That's the absolute limit to how old a Linux version I'll tolerate regular testing on.
+    name: GCC, very old Autotools
+    runs-on: ubuntu-latest
+    container: redhat/ubi8:8.6
+    if: github.event_name != 'workflow_dispatch' || (inputs.job_id == 'all' || inputs.job_id == 'passenger')
+    steps:
+      - name: Setup
+        run: |
+          yum -q makecache
+          yum -q install -y gcc git make automake autoconf libtool diffutils file glibc-langpack-en
+          yum -q update -y glibc-common
+
+      - name: Checkout
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        with:
+          submodules: true
+
+      - name: Prepare
+        run: ./autogen.sh
+
+      - name: Configure
+        run: ./configure CFLAGS="-O0 $CFLAGS_GCC_STYLE" --enable-jit --enable-pcre2-16 --enable-pcre2-32 --enable-debug --enable-Werror
+
+      - name: Build
+        run: make -j3
+
+      - name: Test
+        run: (make check; rc=$?; for i in test-suite.log Run*Test.log pcre2*_test.log; do echo "== $i =="; cat $i; done; exit $rc)
+
+
+      - name: Install
+        run: |
+          make install "DESTDIR=`pwd`/install-dir"
+          maint/RunManifestTest install-dir maint/manifest-makeinstall-linux
+          maint/RunSymbolTest install-dir/usr/local/lib/ maint/
+
   wasp:
     # Tests with: French locale; oldest supported CMake; no JIT; -Os; libreadline
     name: GCC -Os, CMake+ninja, no JIT

RunGrepTest

@@ -859,8 +859,13 @@ if [ $? -ne 0 ]; then
   echo "RC=2" >>testtrygrep
 else
 
-  (cd $srcdir; unset LC_ALL; LC_CTYPE=locale.bad $valgrind $vjs $pcre2grep abc /dev/null) >>testtrygrep 2>&1
+  (cd $srcdir; unset LC_ALL; LC_CTYPE=locale.bad; export LC_CTYPE; $valgrind $vjs $pcre2grep abc /dev/null >>$builddir/testtrygrep 2>&1) >testtemp1grep 2>&1
   echo "RC=$?" >>testtrygrep
+  shell_errors=`cat testtemp1grep`
+  if [ x"$shell_errors" != x ] ; then
+    printf "shell errors during locale test: "
+    echo "$shell_errors"
+  fi
 fi
 
 echo "---------------------------- Test 151 -----------------------------" >>testtrygrep

autogen.sh

@@ -10,6 +10,7 @@
 # variants like glibtoolize (MacOSX) and libtoolize1x (FreeBSD)
 
 set +ex
+
 echo "Looking for a version of libtoolize (which can have different names)..."
 libtoolize=""
 for l in glibtoolize libtoolize15 libtoolize14 libtoolize ; do
@@ -27,7 +28,12 @@ if [ "x$libtoolize" = "x" ]; then
     exit 1
 fi
 
+$libtoolize --version | head -n1
+autoconf --version | head -n1
+automake --version | head -n1
+
 set -ex
+
 $libtoolize -c -f
 rm -rf autom4te.cache Makefile.in aclocal.m4
 aclocal --force -I m4

configure.ac

@@ -22,7 +22,7 @@ m4_define(libpcre2_posix_version, [3:6:0])
 # NOTE: The CMakeLists.txt file searches for the above variables in the first
 # 50 lines of this file. Please update that if the variables above are moved.
 
-AC_PREREQ([2.62])
+AC_PREREQ([2.69])
 AC_INIT([PCRE2],pcre2_major.pcre2_minor[]pcre2_prerelease,[],[pcre2])
 AC_CONFIG_SRCDIR([src/pcre2.h.in])
 AM_INIT_AUTOMAKE([dist-bzip2 dist-zip foreign])

maint/RunSymbolTest

@@ -87,7 +87,7 @@ for so_name in "libpcre2-8" "libpcre2-16" "libpcre2-32" "libpcre2-posix"; do
     $grep -E -v '^[Uw] ' | \
     $grep -E -v '^A PCRE2_' | \
     $grep -E -v ' (_init|_fini)($|@)' | \
-    $grep -E -v ' (_end|_DYNAMIC|_GLOBAL_OFFSET_TABLE_|_PROCEDURE_LINKAGE_TABLE_|_edata|_etext)($|@)' | \
+    $grep -E -v ' (__bss_start|_end|_DYNAMIC|_GLOBAL_OFFSET_TABLE_|_PROCEDURE_LINKAGE_TABLE_|_edata|_etext)($|@)' | \
     so_mangling | \
     sort \
     > "$base.actual"