Add `gametitle=` validation to the linter

[CookiePLMonster]

We need to enforce the presence of a gametitle field in the file, and maybe enforce a standard layout of it.

[RedDevilus]

Also need to keep in mind if there is a broken patch that you still want history of it when you comment set amount of lines or all of them and submit to repo.

(Serial and CRC mentioned as well, not sure if we should add a new type for those or integrate with existing gametitle=)

Optimally maybe give an example of an extensive patch with enough possibilities that people understand format.

Either way enough input and feedback will help so we don't miss a better template as stated in OP.

The bigger issue is the wildly differently patches already in the repository. It's going to take a lot of work.

Also how to properly name the commit and combining multiple patches in one where applicable.

[CookiePLMonster]

Yeah, for this reason I would be more inclined to only enforce the presence of title without a predetermined layout. Enforcing the layout would potentially mean hundreds of changes.

[RedDevilus]

Yeah, for this reason I would be more inclined to only enforce the presence of title without a predetermined layout. Enforcing the layout would potentially mean hundreds of changes.

On the wiki there is some standardisations how a layout should look. Maybe a good idea to list some good practises examples and what best to avoid?

Then atleast new additions or even modifying current ones have something to aspire or try to follow, without the bot linter nagging.

[RedDevilus]

gametitle=007 - Quantum Of Solace (NTSC-U) (SLUS-21813)

[60 FPS]
author=Souzooka and asasega
description=60 FPS; recommend using 180% EE Cycle Overclock

// Framerate
patch=1,EE,203CA748,extended,3C // 60 FPS
patch=1,EE,E0010001,extended,003DDB84 // Check 003DDB84 is XXXX0001, indicating a .pss is playing
patch=1,EE,203CA748,extended,1E // 30 FPS (normal .pss speed)
patch=1,EE,E0010000,extended,003CAA98 // Check 003CAA98 is XXXX0000, workaround for softlock after subduing first opera house enemy
patch=1,EE,203CA748,extended,1E // 30 FPS (softlock prevention)
// Prevent softlock in cave level (Sink Hole) after shooting 2 guys in helicopter
patch=1,EE,E0030132,extended,003CD020 // Map is that cave level
patch=1,EE,E002BF7B,extended,0037DA62 // Camera position? Who knows
patch=1,EE,E0010001,extended,003CA80C // In cutscene? Who knows
patch=1,EE,203CA748,extended,1E // 30 FPS (softlock prevention)

// Reduce recoil compensation (affected by framerate)
patch=1,EE,203C5C84,extended,3D7CCCCD

[Onscreen FPS Display]
author=asasega
patch=1,EE,003CD06E,word,00000001

gametitle=The Sims 2 (PAL-M) (SLES-53718) E626181E Even lists the region and languages kinda but eh optional.

[CookiePLMonster]

My format of choice is e.g. gametitle=Gran Turismo 4 Prologue [SCES-52438] (E) but I'd be open for anything else. I think just enforcing the presence of the gametitle element would make people look for inspiration in other files.

[PeterDelta]

Also how to properly name the commit and combining multiple patches in one where applicable.

I find this idea interesting. For example, there are many patches that remove black bands from scenes, and this could be combined with the widescreen patch. Or several widescreen scales could be unified, making things more organized.
I prefer to use "()", and in cases where there are multiple elfs, it would be interesting to include their names after the CRC so we know what they correspond to.
Including whether it is PAL or NTSC is not very relevant because the region code itself already indicates it.

I can commit to making these design changes once there is consensus.

[pgert]

I prefere it like this, and wish to keep it that way:
gametitle=Jak II: Renegade * PAL-M7 * SCES-51608 * 2479F4A9
Standardization of the thing that would prevent this is therefore opposed on my part.