move logic to clear

Author: JanCaha

src/vpc.cpp

@@ -40,6 +40,13 @@ using namespace pdal;
 void VirtualPointCloud::clear()
 {
     files.clear();
+
+    // remove the temporary local copy of a remote VPC, if one was downloaded
+    if (!downloadedFilename.empty()) {
+      std::error_code ec;
+      fs::remove(downloadedFilename, ec);
+      downloadedFilename.clear();
+    }
 }
 
 void VirtualPointCloud::dump()
@@ -994,13 +1001,4 @@ std::vector<VirtualPointCloud::File> VirtualPointCloud::overlappingBox2D(const B
     return overlaps;
 }
 
-VirtualPointCloud::~VirtualPointCloud() { cleanup(); }
-
-void VirtualPointCloud::cleanup() {
-  // remove the temporary local copy of a remote VPC, if one was downloaded
-  if (!downloadedFilename.empty()) {
-    std::error_code ec;
-    fs::remove(downloadedFilename, ec);
-    downloadedFilename.clear();
-  }
-}
+VirtualPointCloud::~VirtualPointCloud() { clear(); }

src/vpc.hpp

@@ -75,9 +75,6 @@ struct VirtualPointCloud
     std::string crsWkt;  // valid WKT for CRS of all files (or empty string if undefined, or "_mix_" if a mixture of CRS was seen)
     std::string downloadedFilename;  // local copy of a remote VPC fetched in read()
 
-    //! removes the temporary local copy of a remote VPC, if one was downloaded
-    void cleanup();
-
     void clear();
     void dump();
     bool read(std::string filename);