Skip to content

Commit a6ddc1e

Browse files
rodrigoprimojrfnl
andauthored
Apply suggestions from code review
Co-authored-by: Juliette <[email protected]>
1 parent 6bb661d commit a6ddc1e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Config.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,8 @@ class Config
204204
* - Keys: lowercase version of the generator name.
205205
* - Values: name of the generator PHP class.
206206
*
207-
* Note: once support for PHP < 5.6 is dropped, this property should be refactored into a class
208-
* constant.
207+
* {@internal Once support for PHP < 5.6 is dropped, this property should be refactored into a class
208+
* constant.}
209209
*
210210
* @var array<string, string>
211211
*/
@@ -1256,7 +1256,7 @@ public function processLongArgument($arg, $pos)
12561256
if (isset(self::$validGenerators[$lowerCaseGeneratorName]) === false) {
12571257
$validOptions = implode(', ', array_values(self::$validGenerators));
12581258
$error = sprintf(
1259-
'ERROR: "%s" is not a valid generator. Valid options are: %s.'.PHP_EOL.PHP_EOL,
1259+
'ERROR: "%s" is not a valid generator. The following generators are supported: %s.'.PHP_EOL.PHP_EOL,
12601260
$generatorName,
12611261
$validOptions
12621262
);

tests/Core/Config/GeneratorArgTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ final class GeneratorArgTest extends TestCase
2323
/**
2424
* Ensure that the generator property is set when the parameter is passed a valid value.
2525
*
26-
* @param string $argumentValue Generator name passed in the command line.
26+
* @param string $argumentValue Generator name passed on the command line.
2727
* @param string $expectedPropertyValue Expected value of the generator property.
2828
*
2929
* @dataProvider dataValidGeneratorNames

0 commit comments

Comments
 (0)