Merge pull request #1386 from rodrigoprimo/inline-control-structure-remove-unreacheable-line

jrfnl · web-flow · commit e79fdb783d41 · 2026-03-07T02:12:24.000+01:00
Generic/InlineControlStructure: remove unreachable if condition
diff --git a/src/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php b/src/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php
@@ -115,10 +115,6 @@ public function process(File $phpcsFile, int $stackPtr)
         }
 
         $nextNonEmpty = $phpcsFile->findNext(Tokens::EMPTY_TOKENS, ($start + 1), null, true);
-        if ($nextNonEmpty === false) {
-            // Live coding or parse error.
-            return;
-        }
 
         if ($tokens[$nextNonEmpty]['code'] === T_OPEN_CURLY_BRACKET
             || $tokens[$nextNonEmpty]['code'] === T_COLON

Original file line number	Diff line number	Diff line change
`@@ -115,10 +115,6 @@ public function process(File $phpcsFile, int $stackPtr)`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`$nextNonEmpty = $phpcsFile->findNext(Tokens::EMPTY_TOKENS, ($start + 1), null, true);`
`118`		`- if ($nextNonEmpty === false) {`
`119`		`- // Live coding or parse error.`
`120`		`- return;`
`121`		`- }`
`122`	`118`
`123`	`119`	`if ($tokens[$nextNonEmpty]['code'] === T_OPEN_CURLY_BRACKET`
`124`	`120`	`\|\| $tokens[$nextNonEmpty]['code'] === T_COLON`