Merge pull request #819 from PHPCSStandards/feature/generators-dont-print-stnd-when-empty

Generators: don't print standard when it's empty

Author: jrfnl

src/Generators/HTML.php

@@ -318,7 +318,12 @@ protected function printTextBlock(DOMNode $node)
      */
     protected function getFormattedTextBlock(DOMNode $node)
     {
-        $content = trim($node->nodeValue);
+        $content = $node->nodeValue;
+        if (empty($content) === true) {
+            return '';
+        }
+
+        $content = trim($content);
         $content = htmlspecialchars($content, (ENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML401));
 
         // Allow only em tags.

src/Generators/Markdown.php

@@ -178,7 +178,12 @@ protected function printTextBlock(DOMNode $node)
      */
     protected function getFormattedTextBlock(DOMNode $node)
     {
-        $content = trim($node->nodeValue);
+        $content = $node->nodeValue;
+        if (empty($content) === true) {
+            return '';
+        }
+
+        $content = trim($content);
         $content = htmlspecialchars($content, (ENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML401));
         $content = str_replace('<em>', '*', $content);
         $content = str_replace('</em>', '*', $content);

src/Generators/Text.php

@@ -124,7 +124,12 @@ protected function printTextBlock(DOMNode $node)
      */
     protected function getFormattedTextBlock(DOMNode $node)
     {
-        $text = trim($node->nodeValue);
+        $text = $node->nodeValue;
+        if (empty($text) === true) {
+            return '';
+        }
+
+        $text = trim($text);
         $text = str_replace('<em>', '*', $text);
         $text = str_replace('</em>', '*', $text);
 

tests/Core/Generators/Expectations/ExpectedOutputInvalidStandardNoContent.html

@@ -72,7 +72,6 @@
   <h1>GeneratorTest Coding Standards</h1>
   <a name="Standard-Element,-no-content" />
   <h2>Standard Element, no content</h2>
-  <p class="text"></p>
   <table class="code-comparison">
    <tr>
     <td class="code-comparison-title">Valid: Lorem ipsum dolor sit amet.</td>

tests/Core/Generators/Expectations/ExpectedOutputInvalidStandardNoContent.md

@@ -2,7 +2,6 @@
 
 ## Standard Element, no content
 
-
   <table>
    <tr>
     <th>Valid: Lorem ipsum dolor sit amet.</th>

tests/Core/Generators/Expectations/ExpectedOutputInvalidStandardNoContent.txt

@@ -3,8 +3,6 @@
 | GENERATORTEST CODING STANDARD: STANDARD ELEMENT, NO CONTENT |
 ---------------------------------------------------------------
 
-
-
 ----------------------------------------- CODE COMPARISON ------------------------------------------
 | Valid: Lorem ipsum dolor sit amet.             | Invalid: Maecenas non rutrum dolor.             |
 ----------------------------------------------------------------------------------------------------