From d134a4a5ad9eb8e6672abc9d52e16e8741e60a5b Mon Sep 17 00:00:00 2001 From: Dan Wallis Date: Fri, 16 Jun 2023 16:10:12 +0100 Subject: [PATCH] Add exclude directive for maybe-ASP-open rule --- PHPCompatibilityMagento/ruleset.xml | 1 + Test/MagentoTest.php | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/PHPCompatibilityMagento/ruleset.xml b/PHPCompatibilityMagento/ruleset.xml index ed71dc0..3a5bb22 100644 --- a/PHPCompatibilityMagento/ruleset.xml +++ b/PHPCompatibilityMagento/ruleset.xml @@ -14,6 +14,7 @@ + diff --git a/Test/MagentoTest.php b/Test/MagentoTest.php index 2a5cebd..df659dc 100644 --- a/Test/MagentoTest.php +++ b/Test/MagentoTest.php @@ -8,3 +8,11 @@ */ // TODO: add a test for each polyfilled feature (violations for which are excluded via the ruleset). + +// Magento's template syntax uses <% and %> as a delimiter. These should not be confused with ASP open/close tags. +// @see https://github.com/magento/magento2/blob/2.4.6/app/code/Magento/ConfigurableProduct/view/adminhtml/templates/catalog/product/edit/attribute/steps/bulk.phtml#L108-L109 +?> +