Contribution : Fixed some errors

Author: Progi1984

src/PhpPresentation/Reader/PowerPoint2007.php

@@ -493,7 +493,7 @@ protected function loadSlide(string $sPart, string $baseFile): void
                         // Background
                         $oBackground = new Slide\Background\Image();
                         $oBackground->setPath($tmpBkgImg);
-                        $extension = pathinfo( $pathImage, PATHINFO_EXTENSION );
+                        $extension = pathinfo($pathImage, PATHINFO_EXTENSION);
                         $oBackground->setExtension($extension);
                         // Slide Background
                         $oSlide = $this->oPhpPresentation->getActiveSlide();

src/PhpPresentation/Slide/Background/Image.php

@@ -89,12 +89,11 @@ public function setPath(string $pValue = '', bool $pVerifyFile = true)
      * Set Extension.
      *
      * @param string $pValue File Extension
-     *
-     * @return self
      */
-    public function setExtension(string $pValue)
+    public function setExtension(string $pValue): self
     {
         $this->extension = $pValue;
+
         return $this;
     }
 
@@ -111,12 +110,12 @@ public function getFilename(): string
      */
     public function getExtension(): string
     {
-        if($this->extension){
+        if ($this->extension) {
             return $this->extension;
         }
         $exploded = explode('.', $this->getFilename());
-        return $exploded[count($exploded) - 1];
 
+        return $exploded[count($exploded) - 1];
     }
 
     /**

src/PhpPresentation/Writer/PowerPoint2007/AbstractSlide.php

@@ -678,7 +678,11 @@ protected function writeRunStyles(XMLWriter $objWriter, Run $element): void
         $objWriter->startElement('a:' . $element->getFont()->getFormat());
         $objWriter->writeAttribute('typeface', $element->getFont()->getName());
         if ($element->getFont()->getPanose() !== '') {
-            $objWriter->writeAttribute('panose', $element->getFont()->getPanose());
+            $panose = array_map(function (string $value) {
+                return '0' . $value;
+            }, str_split($element->getFont()->getPanose()));
+
+            $objWriter->writeAttribute('panose', implode('', $panose));
         }
         $objWriter->writeAttributeIf(
             $element->getFont()->getPitchFamily() !== 0,
@@ -689,7 +693,7 @@ protected function writeRunStyles(XMLWriter $objWriter, Run $element): void
         $objWriter->writeAttributeIf(
             $element->getFont()->getCharset() !== Font::CHARSET_DEFAULT,
             'charset',
-            $charset
+            dechex($element->getFont()->getCharset())
         );
         $objWriter->endElement();
 

tests/PhpPresentation/Tests/Writer/PowerPoint2007/PptSlidesTest.php

@@ -886,7 +886,7 @@ public function testRichTextRunFontCharset(): void
         $this->assertZipXmlAttributeExists('ppt/slides/slide1.xml', $latinElement, 'typeface');
         $this->assertZipXmlAttributeEquals('ppt/slides/slide1.xml', $latinElement, 'typeface', 'Calibri');
         $this->assertZipXmlAttributeExists('ppt/slides/slide1.xml', $latinElement, 'charset');
-        $this->assertZipXmlAttributeEquals('ppt/slides/slide1.xml', $latinElement, 'charset', '18');
+        $this->assertZipXmlAttributeEquals('ppt/slides/slide1.xml', $latinElement, 'charset', '12');
         $this->assertZipXmlElementNotExists('ppt/slides/slide1.xml', $eastAsianElement);
         $this->assertZipXmlElementNotExists('ppt/slides/slide1.xml', $complexScriptElement);
         $this->assertIsSchemaECMA376Valid();
@@ -899,7 +899,7 @@ public function testRichTextRunFontCharset(): void
         $this->assertZipXmlAttributeExists('ppt/slides/slide1.xml', $eastAsianElement, 'typeface');
         $this->assertZipXmlAttributeEquals('ppt/slides/slide1.xml', $eastAsianElement, 'typeface', 'Calibri');
         $this->assertZipXmlAttributeExists('ppt/slides/slide1.xml', $eastAsianElement, 'charset');
-        $this->assertZipXmlAttributeEquals('ppt/slides/slide1.xml', $eastAsianElement, 'charset', '18');
+        $this->assertZipXmlAttributeEquals('ppt/slides/slide1.xml', $eastAsianElement, 'charset', '12');
         $this->assertZipXmlElementNotExists('ppt/slides/slide1.xml', $complexScriptElement);
         $this->assertIsSchemaECMA376Valid();
 
@@ -912,7 +912,7 @@ public function testRichTextRunFontCharset(): void
         $this->assertZipXmlAttributeExists('ppt/slides/slide1.xml', $complexScriptElement, 'typeface');
         $this->assertZipXmlAttributeEquals('ppt/slides/slide1.xml', $complexScriptElement, 'typeface', 'Calibri');
         $this->assertZipXmlAttributeExists('ppt/slides/slide1.xml', $complexScriptElement, 'charset');
-        $this->assertZipXmlAttributeEquals('ppt/slides/slide1.xml', $complexScriptElement, 'charset', '18');
+        $this->assertZipXmlAttributeEquals('ppt/slides/slide1.xml', $complexScriptElement, 'charset', '12');
         $this->assertIsSchemaECMA376Valid();
     }