PHPCS & Static analysis fixes

Author: Phil Wilkinson

src/PhpPresentation/Reader/ODPresentation.php

@@ -653,8 +653,13 @@ protected function loadShapeMedia(DOMElement $oNodeFrame): void
         }
 
         $mediaFile = null;
+        $filePath = null;
         if ($oNodePlugin->hasAttribute('xlink:href')) {
             $filePath = $oNodePlugin->getAttribute('xlink:href');
+            if (!$filePath) {
+                return;
+            }
+
             $filePathParts = explode('/', $filePath);
             if (!$filePathParts || $filePathParts[0] !== 'Media') {
                 return;

src/PhpPresentation/Reader/PowerPoint2007.php

@@ -868,7 +868,7 @@ protected function loadShapeDrawing(XMLReader $document, DOMElement $node, Abstr
         $oSlide->addShape($oShape);
     }
 
-    protected function loadShapeDrawingEmbed(DOMElement $oElement, string $fileRels, AbstractDrawingAdapter $oShape): AbstractDrawingAdapter
+    protected function loadShapeDrawingEmbed(DOMElement $oElement, string $fileRels, Media $oShape): Media
     {
         if (!$oElement->hasAttribute('r:embed')) {
             return $oShape;
@@ -900,10 +900,11 @@ protected function loadShapeDrawingEmbed(DOMElement $oElement, string $fileRels,
             ->setName($fileName)
             ->setFileName($fileName)
             ->setPath($tmpEmbed, false);
+
         return $oShape;
     }
 
-    protected function loadShapeDrawingImage(XMLReader $document, DOMElement $node, string $fileRels, AbstractDrawingAdapter $oShape)
+    protected function loadShapeDrawingImage(XMLReader $document, DOMElement $node, string $fileRels, AbstractDrawingAdapter $oShape): AbstractDrawingAdapter
     {
         $oElement = $document->getElement('p:blipFill/a:blip', $node);
         if (!($oElement instanceof DOMElement)) {

src/PhpPresentation/Shape/Drawing/File.php

@@ -79,9 +79,10 @@ public function getFileName(): string
      * @param string $fileName
      * @return File
      */
-    public function setFileName(string $fileName): File
+    public function setFileName(string $fileName): self
     {
         $this->fileName = $fileName;
+
         return $this;
     }