-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathdeferred_gap_bookkeeping.py
More file actions
325 lines (267 loc) · 11.9 KB
/
Copy pathdeferred_gap_bookkeeping.py
File metadata and controls
325 lines (267 loc) · 11.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
"""Deferred-gap bookkeeping support shared by reconcile and sweeper."""
from __future__ import annotations
from copy import deepcopy
from datetime import datetime, timedelta, timezone
def _sidecars(review_data: dict) -> dict:
sidecars = review_data.get("sidecars")
if not isinstance(sidecars, dict):
sidecars = {}
review_data["sidecars"] = sidecars
return sidecars
def _deferred_gaps(review_data: dict) -> dict:
sidecars = _sidecars(review_data)
deferred_gaps = sidecars.get("deferred_gaps")
if not isinstance(deferred_gaps, dict):
deferred_gaps = {}
sidecars["deferred_gaps"] = deferred_gaps
return deferred_gaps
def _reconciled_source_events(review_data: dict) -> dict:
sidecars = _sidecars(review_data)
reconciled = sidecars.get("reconciled_source_events")
if not isinstance(reconciled, dict):
reconciled = {}
sidecars["reconciled_source_events"] = reconciled
return reconciled
def _observer_discovery_watermarks(review_data: dict) -> dict:
sidecars = _sidecars(review_data)
watermarks = sidecars.get("observer_discovery_watermarks")
if not isinstance(watermarks, dict):
watermarks = {}
sidecars["observer_discovery_watermarks"] = watermarks
return watermarks
def _ensure_observer_discovery_watermark(review_data: dict, surface: str) -> dict:
watermarks = _observer_discovery_watermarks(review_data)
current = watermarks.get(surface)
if isinstance(current, dict):
return current
current = {
"last_scan_started_at": None,
"last_scan_completed_at": None,
"last_safe_event_time": None,
"last_safe_event_id": None,
"lookback_seconds": None,
"bootstrap_window_seconds": None,
"bootstrap_completed_at": None,
}
watermarks[surface] = current
return current
def _observer_now_iso(bot) -> str:
return _now_iso(bot)
def _parse_observer_timestamp(value: object) -> datetime | None:
if not isinstance(value, str) or not value.strip():
return None
try:
timestamp = datetime.fromisoformat(value.replace("Z", "+00:00"))
except ValueError:
return None
if timestamp.tzinfo is None:
return timestamp.replace(tzinfo=timezone.utc)
return timestamp
def _configured_seconds(bot, name: str, default: int) -> int:
value = getattr(bot, name, default)
try:
seconds = int(value)
except (TypeError, ValueError):
return default
return seconds if seconds >= 0 else default
def begin_observer_surface_scan(
bot,
review_data: dict,
surface: str,
*,
now: datetime | None = None,
) -> datetime:
watermark = _ensure_observer_discovery_watermark(review_data, surface)
scan_started_at = now or bot.clock.now()
if scan_started_at.tzinfo is None:
scan_started_at = scan_started_at.replace(tzinfo=timezone.utc)
lookback_seconds = _configured_seconds(bot, "DEFERRED_DISCOVERY_OVERLAP_SECONDS", 3600)
bootstrap_window_seconds = _configured_seconds(bot, "DEFERRED_DISCOVERY_BOOTSTRAP_WINDOW_SECONDS", 604800)
watermark.update(
{
"last_scan_started_at": scan_started_at.isoformat(),
"lookback_seconds": lookback_seconds,
"bootstrap_window_seconds": bootstrap_window_seconds,
}
)
bootstrap_floor = scan_started_at - timedelta(seconds=bootstrap_window_seconds)
safe_time = _parse_observer_timestamp(watermark.get("last_safe_event_time"))
if safe_time is None:
return bootstrap_floor
return max(bootstrap_floor, safe_time - timedelta(seconds=lookback_seconds))
def record_observer_watermark_event(bot, review_data: dict, surface: str, event_time: str, event_id: str) -> None:
current = _ensure_observer_discovery_watermark(review_data, surface)
now = _observer_now_iso(bot)
current.update(
{
"last_scan_started_at": current.get("last_scan_started_at") or now,
"last_scan_completed_at": now,
"last_safe_event_time": event_time,
"last_safe_event_id": event_id,
"lookback_seconds": _configured_seconds(bot, "DEFERRED_DISCOVERY_OVERLAP_SECONDS", 3600),
"bootstrap_window_seconds": _configured_seconds(bot, "DEFERRED_DISCOVERY_BOOTSTRAP_WINDOW_SECONDS", 604800),
"bootstrap_completed_at": current.get("bootstrap_completed_at") or now,
}
)
def record_observer_watermark_empty_scan(bot, review_data: dict, surface: str) -> None:
watermark = _ensure_observer_discovery_watermark(review_data, surface)
now = _observer_now_iso(bot)
watermark["last_scan_started_at"] = watermark.get("last_scan_started_at") or now
watermark["last_scan_completed_at"] = now
watermark["lookback_seconds"] = _configured_seconds(bot, "DEFERRED_DISCOVERY_OVERLAP_SECONDS", 3600)
watermark["bootstrap_window_seconds"] = _configured_seconds(bot, "DEFERRED_DISCOVERY_BOOTSTRAP_WINDOW_SECONDS", 604800)
watermark["bootstrap_completed_at"] = watermark.get("bootstrap_completed_at") or now
def list_deferred_gap_keys(review_data: dict) -> list[str]:
return list(_deferred_gaps(review_data))
def get_deferred_gap(review_data: dict, source_event_key: str) -> dict:
gap = _deferred_gaps(review_data).get(source_event_key)
return gap if isinstance(gap, dict) else {}
def get_deferred_gap_reason(review_data: dict, source_event_key: str) -> str | None:
reason = get_deferred_gap(review_data, source_event_key).get("reason")
return reason if isinstance(reason, str) else None
def _now_iso(bot) -> str:
return bot.clock.now().isoformat()
def _reconciled_at_now() -> str:
return datetime.now(timezone.utc).isoformat()
def _is_valid_reconciled_source_event(existing: object, source_event_key: str) -> bool:
if not isinstance(existing, dict):
return False
if existing.get("source_event_key") != source_event_key:
return False
reconciled_at = existing.get("reconciled_at")
return isinstance(reconciled_at, str) and bool(reconciled_at.strip())
def record_deferred_gap_payload(review_data: dict, source_event_key: str, payload: dict | None = None) -> None:
deferred_gaps = _deferred_gaps(review_data)
if payload is None:
payload = {}
payload["source_event_key"] = source_event_key
deferred_gaps[source_event_key] = payload
def clear_deferred_gap(review_data: dict, source_event_key: str) -> bool:
deferred_gaps = _deferred_gaps(review_data)
if source_event_key in deferred_gaps:
deferred_gaps.pop(source_event_key, None)
return True
return False
def clear_automation_comment_false_positive(review_data: dict, source_event_key: str) -> bool:
"""Clear only known self-authored issue-comment observer false positives."""
if not source_event_key.startswith("issue_comment:"):
return False
return clear_deferred_gap(review_data, source_event_key)
def update_deferred_gap_fields(review_data: dict, source_event_key: str, fields: dict) -> bool:
deferred_gaps = _deferred_gaps(review_data)
existing = deferred_gaps.get(source_event_key)
if not isinstance(existing, dict):
return False
previous = deepcopy(existing)
existing.update(fields)
return previous != existing
def mark_reconciled_source_event(
review_data: dict,
source_event_key: str,
*,
reconciled_at: str | None = None,
) -> bool:
reconciled = _reconciled_source_events(review_data)
timestamp = reconciled_at or _reconciled_at_now()
existing = reconciled.get(source_event_key)
if isinstance(existing, dict):
if not _is_valid_reconciled_source_event(existing, source_event_key):
existing["source_event_key"] = source_event_key
existing["reconciled_at"] = timestamp
return True
return False
reconciled[source_event_key] = {
"source_event_key": source_event_key,
"reconciled_at": timestamp,
}
return True
def was_reconciled_source_event(review_data: dict, source_event_key: str) -> bool:
return _is_valid_reconciled_source_event(
_reconciled_source_events(review_data).get(source_event_key),
source_event_key,
)
def _payload_or_existing(payload: dict, existing: dict, key: str):
value = payload.get(key)
return existing.get(key) if value is None else value
def _first_present_payload_value(payload: dict, keys: tuple[str, ...]):
for key in keys:
if key not in payload:
continue
value = payload.get(key)
if isinstance(value, str):
value = value.strip()
if value is not None and value != "":
return value
return None
def _copy_source_evidence(fields: dict, payload: dict, existing: dict) -> None:
evidence_fields = {
"source_actor_login": ("source_actor_login", "comment_author", "actor_login"),
"source_actor_id": ("source_actor_id", "comment_author_id", "actor_id"),
"source_actor_user_type": ("source_actor_user_type", "comment_user_type"),
"source_actor_sender_type": ("source_actor_sender_type", "comment_sender_type"),
"source_actor_installation_id": ("source_actor_installation_id", "comment_installation_id"),
"source_actor_performed_via_github_app": (
"source_actor_performed_via_github_app",
"comment_performed_via_github_app",
),
"source_comment_id": ("source_comment_id", "comment_id"),
"source_review_id": ("source_review_id", "review_id", "pull_request_review_id"),
"source_commit_id": ("source_commit_id",),
"source_review_state": ("source_review_state",),
}
for target_key, source_keys in evidence_fields.items():
value = _first_present_payload_value(payload, source_keys)
if value is None:
value = existing.get(target_key)
if value is not None:
fields[target_key] = value
def _source_event_created_at(payload: dict, existing: dict):
return (
payload.get("source_created_at")
or payload.get("comment_created_at")
or payload.get("source_submitted_at")
or payload.get("source_dismissed_at")
or payload.get("source_event_created_at")
or existing.get("source_event_created_at")
)
def record_deferred_gap_diagnostic(
bot,
review_data: dict,
payload: dict,
reason: str,
diagnostic_summary: str,
*,
failure_kind: str | None = None,
) -> bool:
source_event_key = str(payload.get("source_event_key", ""))
if not source_event_key:
return False
deferred_gaps = _deferred_gaps(review_data)
existing = deferred_gaps.get(source_event_key, {})
if not isinstance(existing, dict):
existing = {}
previous = deepcopy(existing)
fields = {
"source_event_key": source_event_key,
"source_event_kind": f"{payload.get('source_event_name')}:{payload.get('source_event_action')}",
"pr_number": payload.get("pr_number"),
"reason": reason,
"source_event_created_at": _source_event_created_at(payload, existing),
"source_run_id": _payload_or_existing(payload, existing, "source_run_id"),
"source_run_attempt": _payload_or_existing(payload, existing, "source_run_attempt"),
"source_workflow_file": _payload_or_existing(payload, existing, "source_workflow_file"),
"source_artifact_name": _payload_or_existing(payload, existing, "source_artifact_name"),
"first_noted_at": existing.get("first_noted_at") or _now_iso(bot),
"last_checked_at": _now_iso(bot),
"operator_action_required": True,
"diagnostic_summary": diagnostic_summary,
"failure_kind": failure_kind,
}
source_dismissed_at = _payload_or_existing(payload, existing, "source_dismissed_at")
if source_dismissed_at is not None:
fields["source_dismissed_at"] = source_dismissed_at
_copy_source_evidence(fields, payload, existing)
existing.update(fields)
changed = previous != existing
deferred_gaps[source_event_key] = existing
return changed