-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathtest_main.py
More file actions
643 lines (515 loc) · 26.9 KB
/
test_main.py
File metadata and controls
643 lines (515 loc) · 26.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
import pytest
from scripts import reviewer_bot
from scripts.reviewer_bot_lib.context import (
GitHubTransportContext,
LeaseLockContext,
ReviewerBotContext,
StateStoreContext,
)
def make_state():
return {
"schema_version": reviewer_bot.STATE_SCHEMA_VERSION,
"freshness_runtime_epoch": reviewer_bot.FRESHNESS_RUNTIME_EPOCH_V18,
"last_updated": None,
"current_index": 0,
"queue": [
{"github": "alice", "name": "Alice"},
{"github": "bob", "name": "Bob"},
{"github": "carol", "name": "Carol"},
],
"pass_until": [],
"recent_assignments": [],
"active_reviews": {},
}
def test_reviewer_bot_exports_runtime_modules():
assert reviewer_bot.requests is not None
assert reviewer_bot.sys is not None
assert reviewer_bot.datetime is not None
assert reviewer_bot.timezone is not None
def test_reviewer_bot_satisfies_runtime_context_protocol():
assert isinstance(reviewer_bot, ReviewerBotContext)
def test_reviewer_bot_satisfies_narrower_lock_and_state_protocols():
assert isinstance(reviewer_bot, GitHubTransportContext)
assert isinstance(reviewer_bot, StateStoreContext)
assert isinstance(reviewer_bot, LeaseLockContext)
def test_render_lock_commit_message_uses_direct_json_import():
rendered = reviewer_bot.render_lock_commit_message({"lock_state": "unlocked"})
assert reviewer_bot.LOCK_COMMIT_MARKER in rendered
def test_main_show_state_uses_direct_yaml_import(monkeypatch, capsys):
monkeypatch.setenv("EVENT_NAME", "workflow_dispatch")
monkeypatch.setenv("EVENT_ACTION", "")
monkeypatch.setenv("MANUAL_ACTION", "show-state")
monkeypatch.setattr(reviewer_bot, "load_state", lambda *args, **kwargs: make_state())
reviewer_bot.main()
output = capsys.readouterr().out
assert "Current state:" in output
assert "freshness_runtime_epoch" in output
def test_classify_event_intent_cross_repo_review_is_non_mutating_defer(monkeypatch):
monkeypatch.setenv("PR_IS_CROSS_REPOSITORY", "true")
intent = reviewer_bot.classify_event_intent("pull_request_review", "submitted")
assert intent == reviewer_bot.EVENT_INTENT_NON_MUTATING_DEFER
def test_classify_event_intent_same_repo_review_is_non_mutating_defer(monkeypatch):
intent = reviewer_bot.classify_event_intent("pull_request_review", "submitted")
assert intent == reviewer_bot.EVENT_INTENT_NON_MUTATING_DEFER
def test_classify_event_intent_same_repo_dismissed_review_is_non_mutating_defer(monkeypatch):
intent = reviewer_bot.classify_event_intent("pull_request_review", "dismissed")
assert intent == reviewer_bot.EVENT_INTENT_NON_MUTATING_DEFER
def test_classify_event_intent_workflow_run_dismissed_review_is_mutating(monkeypatch):
monkeypatch.setenv("WORKFLOW_RUN_EVENT", "pull_request_review")
monkeypatch.setenv("WORKFLOW_RUN_EVENT_ACTION", "dismissed")
intent = reviewer_bot.classify_event_intent("workflow_run", "completed")
assert intent == reviewer_bot.EVENT_INTENT_MUTATING
def test_main_cross_repo_review_does_not_acquire_lock(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "pull_request_review")
monkeypatch.setenv("EVENT_ACTION", "submitted")
monkeypatch.setenv("PR_IS_CROSS_REPOSITORY", "true")
acquire_called = {"value": False}
def fail_if_called():
acquire_called["value"] = True
raise AssertionError("acquire_state_issue_lease_lock should not be called")
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", fail_if_called)
monkeypatch.setattr(reviewer_bot, "load_state", lambda *args, **kwargs: make_state())
monkeypatch.setattr(reviewer_bot, "handle_pull_request_review_event", lambda state: False)
reviewer_bot.main()
assert acquire_called["value"] is False
def test_main_same_repo_review_does_not_acquire_lock(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "pull_request_review")
monkeypatch.setenv("EVENT_ACTION", "submitted")
acquire_called = {"value": False}
def fail_if_called():
acquire_called["value"] = True
raise AssertionError("acquire_state_issue_lease_lock should not be called")
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", fail_if_called)
monkeypatch.setattr(reviewer_bot, "load_state", lambda *args, **kwargs: make_state())
monkeypatch.setattr(reviewer_bot, "process_pass_until_expirations", lambda state: (state, []))
monkeypatch.setattr(reviewer_bot, "sync_members_with_queue", lambda state: (state, []))
monkeypatch.setattr(reviewer_bot, "handle_pull_request_review_event", lambda state: False)
reviewer_bot.main()
assert acquire_called["value"] is False
def test_main_workflow_run_reconcile_acquires_lock(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "workflow_run")
monkeypatch.setenv("EVENT_ACTION", "completed")
monkeypatch.setenv("WORKFLOW_RUN_EVENT", "pull_request_review")
acquire_called = {"value": False}
def fake_acquire():
acquire_called["value"] = True
return reviewer_bot.LeaseContext(
lock_token="token",
lock_owner_run_id="run",
lock_owner_workflow="workflow",
lock_owner_job="job",
state_issue_url="https://example.com/issues/314",
lock_ref="refs/heads/reviewer-bot-state-lock",
lock_expires_at="2999-01-01T00:00:00+00:00",
)
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", fake_acquire)
monkeypatch.setattr(reviewer_bot, "release_state_issue_lease_lock", lambda: True)
monkeypatch.setattr(reviewer_bot, "load_state", lambda *args, **kwargs: make_state())
monkeypatch.setattr(reviewer_bot, "process_pass_until_expirations", lambda state: (state, []))
monkeypatch.setattr(reviewer_bot, "sync_members_with_queue", lambda state: (state, []))
monkeypatch.setattr(reviewer_bot, "handle_workflow_run_event", lambda state: False)
reviewer_bot.main()
assert acquire_called["value"] is True
def test_main_reloads_state_before_syncing_status_labels(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "issue_comment")
monkeypatch.setenv("EVENT_ACTION", "created")
initial_state = make_state()
reloaded_state = make_state()
load_calls = {"count": 0}
call_order = []
def fake_load_state(*, fail_on_unavailable=False):
load_calls["count"] += 1
call_order.append(f"load:{load_calls['count']}")
if load_calls["count"] == 1:
return initial_state
return reloaded_state
def fake_handle_comment_event(state):
assert state is initial_state
reviewer_bot.collect_touched_item(42)
call_order.append("handle")
return True
def fake_save_state(state):
assert state is initial_state
call_order.append("save")
return True
def fake_sync_status_labels_for_items(state, issue_numbers):
call_order.append("sync")
assert state is reloaded_state
assert list(issue_numbers) == [42]
return True
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", lambda: None)
monkeypatch.setattr(reviewer_bot, "release_state_issue_lease_lock", lambda: True)
monkeypatch.setattr(reviewer_bot, "load_state", fake_load_state)
monkeypatch.setattr(reviewer_bot, "process_pass_until_expirations", lambda state: (state, []))
monkeypatch.setattr(reviewer_bot, "sync_members_with_queue", lambda state: (state, []))
monkeypatch.setattr(reviewer_bot, "handle_comment_event", fake_handle_comment_event)
monkeypatch.setattr(reviewer_bot, "save_state", fake_save_state)
monkeypatch.setattr(reviewer_bot, "sync_status_labels_for_items", fake_sync_status_labels_for_items)
reviewer_bot.main()
assert call_order == [
"load:1",
"handle",
"load:2",
"save",
"load:3",
"load:4",
"sync",
]
def test_issue_close_then_close_comment_does_not_leave_active_review(monkeypatch):
state = make_state()
review = reviewer_bot.ensure_review_entry(state, 42, create=True)
assert review is not None
review["current_reviewer"] = "alice"
monkeypatch.setenv("ISSUE_NUMBER", "42")
monkeypatch.setenv("IS_PULL_REQUEST", "false")
monkeypatch.setenv("ISSUE_TITLE", "Validation issue")
monkeypatch.setenv("ISSUE_BODY", "body")
monkeypatch.setenv("ISSUE_AUTHOR", "dana")
monkeypatch.setenv("ISSUE_STATE", "closed")
monkeypatch.setenv("COMMENT_USER_TYPE", "User")
monkeypatch.setenv("COMMENT_AUTHOR", "dana")
monkeypatch.setenv("COMMENT_ID", "100")
monkeypatch.setenv("COMMENT_CREATED_AT", "2026-03-17T10:00:00Z")
monkeypatch.setenv("COMMENT_BODY", "reviewer-bot validation close-path comment")
assert reviewer_bot.handle_closed_event(state) is True
assert "42" not in state["active_reviews"]
assert reviewer_bot.handle_comment_event(state) is False
assert "42" not in state["active_reviews"]
def test_main_fails_when_save_state_fails(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "issue_comment")
monkeypatch.setenv("EVENT_ACTION", "created")
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", lambda: None)
monkeypatch.setattr(reviewer_bot, "release_state_issue_lease_lock", lambda: True)
monkeypatch.setattr(reviewer_bot, "load_state", lambda *args, **kwargs: make_state())
monkeypatch.setattr(reviewer_bot, "process_pass_until_expirations", lambda state: (state, []))
monkeypatch.setattr(reviewer_bot, "sync_members_with_queue", lambda state: (state, []))
monkeypatch.setattr(reviewer_bot, "handle_comment_event", lambda state: True)
monkeypatch.setattr(reviewer_bot, "save_state", lambda state: False)
with pytest.raises(SystemExit) as excinfo:
reviewer_bot.main()
assert excinfo.value.code == 1
def test_main_workflow_run_fails_closed_on_invalid_context(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "workflow_run")
monkeypatch.setenv("EVENT_ACTION", "completed")
monkeypatch.setenv("WORKFLOW_RUN_EVENT", "pull_request_review")
monkeypatch.setenv("WORKFLOW_RUN_EVENT_ACTION", "submitted")
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", lambda: None)
monkeypatch.setattr(reviewer_bot, "release_state_issue_lease_lock", lambda: True)
monkeypatch.setattr(reviewer_bot, "load_state", lambda *args, **kwargs: make_state())
monkeypatch.setattr(reviewer_bot, "process_pass_until_expirations", lambda state: (state, []))
monkeypatch.setattr(reviewer_bot, "sync_members_with_queue", lambda state: (state, []))
monkeypatch.setattr(
reviewer_bot,
"handle_workflow_run_event",
lambda state: (_ for _ in ()).throw(RuntimeError("invalid deferred context")),
)
with pytest.raises(SystemExit) as excinfo:
reviewer_bot.main()
assert excinfo.value.code == 1
def test_main_schedule_backfills_existing_transition_notice_without_duplicate_comment(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "schedule")
monkeypatch.setenv("EVENT_ACTION", "")
state = make_state()
review = reviewer_bot.ensure_review_entry(state, 42, create=True)
assert review is not None
review["current_reviewer"] = "alice"
review["assigned_at"] = "2026-03-01T00:00:00Z"
review["last_reviewer_activity"] = "2026-03-01T00:00:00Z"
review["transition_warning_sent"] = "2026-03-10T00:00:00Z"
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", lambda: None)
monkeypatch.setattr(reviewer_bot, "release_state_issue_lease_lock", lambda: True)
monkeypatch.setattr(reviewer_bot, "load_state", lambda *args, **kwargs: state)
monkeypatch.setattr(reviewer_bot, "process_pass_until_expirations", lambda current: (current, []))
monkeypatch.setattr(reviewer_bot, "sync_members_with_queue", lambda current: (current, []))
monkeypatch.setattr(reviewer_bot.maintenance_module, "sweep_deferred_gaps", lambda bot, current: False)
monkeypatch.setattr(reviewer_bot.maintenance_module, "maybe_record_head_observation_repair", lambda bot, issue_number, review_data: False)
monkeypatch.setattr(reviewer_bot, "get_pull_request_reviews", lambda issue_number: [])
monkeypatch.setattr(reviewer_bot, "get_issue_or_pr_snapshot", lambda issue_number: {"number": issue_number, "state": "open", "pull_request": {}, "labels": []})
monkeypatch.setattr(reviewer_bot, "save_state", lambda current: True)
monkeypatch.setattr(reviewer_bot, "sync_status_labels_for_items", lambda current, issue_numbers: True)
posted = []
monkeypatch.setattr(reviewer_bot, "post_comment", lambda issue_number, body: posted.append(body) or True)
def fake_api(method, endpoint, data=None):
if endpoint == "issues/42/comments?per_page=100":
return [{"id": 99, "created_at": "2026-03-25T15:22:42Z", "body": "🔔 **Transition Period Ended**\n\nExisting notice", "user": {"login": "github-actions[bot]"}}]
raise AssertionError(endpoint)
monkeypatch.setattr(reviewer_bot, "github_api", fake_api)
reviewer_bot.main()
assert review["transition_notice_sent_at"] == "2026-03-25T15:22:42Z"
assert posted == []
def test_main_schedule_reviewer_review_repair_marks_item_for_label_sync(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "schedule")
monkeypatch.setenv("EVENT_ACTION", "")
state = make_state()
review = reviewer_bot.ensure_review_entry(state, 42, create=True)
assert review is not None
review["current_reviewer"] = "alice"
review["active_cycle_started_at"] = "2026-03-17T09:00:00Z"
synced_issue_numbers = []
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", lambda: None)
monkeypatch.setattr(reviewer_bot, "release_state_issue_lease_lock", lambda: True)
monkeypatch.setattr(reviewer_bot, "load_state", lambda *args, **kwargs: state)
monkeypatch.setattr(reviewer_bot, "process_pass_until_expirations", lambda current: (current, []))
monkeypatch.setattr(reviewer_bot, "sync_members_with_queue", lambda current: (current, []))
monkeypatch.setattr(reviewer_bot.maintenance_module, "sweep_deferred_gaps", lambda bot, current: False)
monkeypatch.setattr(reviewer_bot.maintenance_module, "maybe_record_head_observation_repair", lambda bot, issue_number, review_data: False)
monkeypatch.setattr(reviewer_bot.maintenance_module, "check_overdue_reviews", lambda bot, current: [])
monkeypatch.setattr(
reviewer_bot,
"get_issue_or_pr_snapshot",
lambda issue_number: {"number": issue_number, "state": "open", "pull_request": {}, "labels": []},
)
monkeypatch.setattr(
reviewer_bot,
"get_pull_request_reviews",
lambda issue_number: [
{
"id": 10,
"state": "COMMENTED",
"submitted_at": "2026-03-17T10:01:00Z",
"commit_id": "head-1",
"user": {"login": "alice"},
}
],
)
monkeypatch.setattr(reviewer_bot, "save_state", lambda current: True)
monkeypatch.setattr(
reviewer_bot,
"sync_status_labels_for_items",
lambda current, issue_numbers: synced_issue_numbers.extend(issue_numbers) or True,
)
reviewer_bot.main()
assert review["reviewer_review"]["accepted"]["semantic_key"] == "pull_request_review:10"
assert synced_issue_numbers == [42]
def test_main_mutating_event_fails_closed_when_state_unavailable(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "issue_comment")
monkeypatch.setenv("EVENT_ACTION", "created")
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", lambda: None)
monkeypatch.setattr(reviewer_bot, "release_state_issue_lease_lock", lambda: True)
def fail_load(*, fail_on_unavailable=False):
assert fail_on_unavailable is True
raise RuntimeError("state unavailable")
monkeypatch.setattr(reviewer_bot, "load_state", fail_load)
with pytest.raises(SystemExit) as excinfo:
reviewer_bot.main()
assert excinfo.value.code == 1
def test_main_mutating_event_does_not_sync_or_save_when_state_unavailable(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "issue_comment")
monkeypatch.setenv("EVENT_ACTION", "created")
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", lambda: None)
monkeypatch.setattr(reviewer_bot, "release_state_issue_lease_lock", lambda: True)
called = {
"pass_until": False,
"sync": False,
"handler": False,
"save": False,
}
def fail_load(*, fail_on_unavailable=False):
assert fail_on_unavailable is True
raise RuntimeError("state unavailable")
def track_pass_until(state):
called["pass_until"] = True
return state, []
def track_sync(state):
called["sync"] = True
return state, []
def track_handler(state):
called["handler"] = True
return True
def track_save(state):
called["save"] = True
return True
monkeypatch.setattr(reviewer_bot, "load_state", fail_load)
monkeypatch.setattr(reviewer_bot, "process_pass_until_expirations", track_pass_until)
monkeypatch.setattr(reviewer_bot, "sync_members_with_queue", track_sync)
monkeypatch.setattr(reviewer_bot, "handle_comment_event", track_handler)
monkeypatch.setattr(reviewer_bot, "save_state", track_save)
with pytest.raises(SystemExit) as excinfo:
reviewer_bot.main()
assert excinfo.value.code == 1
assert called == {
"pass_until": False,
"sync": False,
"handler": False,
"save": False,
}
def test_acquire_lock_retries_until_expected_token_visible(monkeypatch):
monkeypatch.setattr(
reviewer_bot.lease_lock_module,
"get_lock_owner_context",
lambda: ("local-run", "reviewer-bot", "reviewer-bot"),
)
snapshots = iter(
[
("old-ref", "tree", {"lock_state": "unlocked", "lock_token": None}),
("stale-ref", "tree", {"lock_state": "unlocked", "lock_token": None}),
("stale-ref-2", "tree", {"lock_state": "unlocked", "lock_token": None}),
(
"new-ref",
"tree",
{
"lock_state": "locked",
"lock_token": "token-123",
"lock_owner_run_id": "local-run",
"lock_owner_workflow": "reviewer-bot",
"lock_owner_job": "reviewer-bot",
"lock_expires_at": "2999-01-01T00:00:00+00:00",
},
),
]
)
monkeypatch.setattr(reviewer_bot.lease_lock_module.uuid, "uuid4", lambda: type("U", (), {"hex": "token-123"})())
monkeypatch.setattr(reviewer_bot.lease_lock_module.time, "sleep", lambda seconds: None)
monkeypatch.setattr(reviewer_bot, "get_lock_ref_snapshot", lambda: next(snapshots))
monkeypatch.setattr(reviewer_bot, "create_lock_commit", lambda parent_sha, tree_sha, lock_meta: reviewer_bot.GitHubApiResult(201, {"sha": "commit-1"}, {}, "", True))
monkeypatch.setattr(reviewer_bot, "cas_update_lock_ref", lambda new_sha: reviewer_bot.GitHubApiResult(200, {}, {}, "", True))
monkeypatch.setattr(reviewer_bot, "get_state_issue_html_url", lambda: "https://example.com/issues/314")
monkeypatch.setattr(reviewer_bot, "ACTIVE_LEASE_CONTEXT", None)
context = reviewer_bot.acquire_state_issue_lease_lock()
assert context.lock_token == "token-123"
assert reviewer_bot.ACTIVE_LEASE_CONTEXT is context
def test_acquire_lock_fails_closed_on_conflicting_visible_token(monkeypatch):
snapshots = iter(
[
("old-ref", "tree", {"lock_state": "unlocked", "lock_token": None}),
("new-ref", "tree", {"lock_state": "locked", "lock_token": "other-token"}),
]
)
monkeypatch.setattr(reviewer_bot.lease_lock_module.uuid, "uuid4", lambda: type("U", (), {"hex": "token-123"})())
monkeypatch.setattr(reviewer_bot.lease_lock_module.time, "sleep", lambda seconds: None)
monkeypatch.setattr(reviewer_bot, "get_lock_ref_snapshot", lambda: next(snapshots))
monkeypatch.setattr(reviewer_bot, "create_lock_commit", lambda parent_sha, tree_sha, lock_meta: reviewer_bot.GitHubApiResult(201, {"sha": "commit-1"}, {}, "", True))
monkeypatch.setattr(reviewer_bot, "cas_update_lock_ref", lambda new_sha: reviewer_bot.GitHubApiResult(200, {}, {}, "", True))
monkeypatch.setattr(reviewer_bot, "get_state_issue_html_url", lambda: "https://example.com/issues/314")
monkeypatch.setattr(reviewer_bot, "ACTIVE_LEASE_CONTEXT", None)
with pytest.raises(RuntimeError, match="unexpected lock state"):
reviewer_bot.acquire_state_issue_lease_lock()
def test_acquire_lock_succeeds_when_later_loop_observes_own_valid_token(monkeypatch):
monkeypatch.setattr(
reviewer_bot.lease_lock_module,
"get_lock_owner_context",
lambda: ("local-run", "reviewer-bot", "reviewer-bot"),
)
snapshots = iter(
[
("old-ref", "tree", {"lock_state": "unlocked", "lock_token": None}),
("stale-ref", "tree", {"lock_state": "unlocked", "lock_token": None}),
(
"new-ref",
"tree",
{
"lock_state": "locked",
"lock_token": "token-123",
"lock_owner_run_id": "local-run",
"lock_owner_workflow": "reviewer-bot",
"lock_owner_job": "reviewer-bot",
"lock_expires_at": "2999-01-01T00:00:00+00:00",
},
),
]
)
monkeypatch.setattr(reviewer_bot.lease_lock_module.uuid, "uuid4", lambda: type("U", (), {"hex": "token-123"})())
monkeypatch.setattr(reviewer_bot.lease_lock_module.time, "sleep", lambda seconds: None)
monkeypatch.setattr(reviewer_bot, "get_lock_ref_snapshot", lambda: next(snapshots))
monkeypatch.setattr(reviewer_bot, "create_lock_commit", lambda parent_sha, tree_sha, lock_meta: reviewer_bot.GitHubApiResult(201, {"sha": "commit-1"}, {}, "", True))
monkeypatch.setattr(reviewer_bot, "cas_update_lock_ref", lambda new_sha: reviewer_bot.GitHubApiResult(200, {}, {}, "", True))
monkeypatch.setattr(reviewer_bot, "get_state_issue_html_url", lambda: "https://example.com/issues/314")
monkeypatch.setattr(reviewer_bot, "ACTIVE_LEASE_CONTEXT", None)
context = reviewer_bot.acquire_state_issue_lease_lock()
assert context.lock_token == "token-123"
assert reviewer_bot.ACTIVE_LEASE_CONTEXT is context
def test_acquire_lock_fails_closed_when_own_token_has_mismatched_owner(monkeypatch):
monkeypatch.setattr(
reviewer_bot.lease_lock_module,
"get_lock_owner_context",
lambda: ("local-run", "reviewer-bot", "reviewer-bot"),
)
snapshots = iter(
[
(
"new-ref",
"tree",
{
"lock_state": "locked",
"lock_token": "token-123",
"lock_owner_run_id": "someone-else",
"lock_owner_workflow": "reviewer-bot",
"lock_owner_job": "reviewer-bot",
"lock_expires_at": "2999-01-01T00:00:00+00:00",
},
)
]
)
monkeypatch.setattr(reviewer_bot.lease_lock_module.uuid, "uuid4", lambda: type("U", (), {"hex": "token-123"})())
monkeypatch.setattr(reviewer_bot.lease_lock_module.time, "sleep", lambda seconds: None)
monkeypatch.setattr(reviewer_bot, "get_lock_ref_snapshot", lambda: next(snapshots))
monkeypatch.setattr(reviewer_bot, "get_state_issue_html_url", lambda: "https://example.com/issues/314")
monkeypatch.setattr(reviewer_bot, "ACTIVE_LEASE_CONTEXT", None)
with pytest.raises(RuntimeError, match="owner metadata drifted"):
reviewer_bot.acquire_state_issue_lease_lock()
def test_release_lock_retries_stale_unlocked_predecessor(monkeypatch):
context = reviewer_bot.LeaseContext(
lock_token="token-123",
lock_owner_run_id="run",
lock_owner_workflow="workflow",
lock_owner_job="job",
state_issue_url="https://example.com/issues/314",
lock_ref="refs/heads/reviewer-bot-state-lock",
lock_expires_at="2999-01-01T00:00:00+00:00",
)
snapshots = iter(
[
("stale-ref", "tree", {"lock_state": "unlocked", "lock_token": None}),
("new-ref", "tree", {"lock_state": "locked", "lock_token": "token-123"}),
]
)
monkeypatch.setattr(reviewer_bot, "ACTIVE_LEASE_CONTEXT", context)
monkeypatch.setattr(reviewer_bot.lease_lock_module.time, "sleep", lambda seconds: None)
monkeypatch.setattr(reviewer_bot, "get_lock_ref_snapshot", lambda: next(snapshots))
monkeypatch.setattr(reviewer_bot, "create_lock_commit", lambda parent_sha, tree_sha, lock_meta: reviewer_bot.GitHubApiResult(201, {"sha": "commit-2"}, {}, "", True))
monkeypatch.setattr(reviewer_bot, "cas_update_lock_ref", lambda new_sha: reviewer_bot.GitHubApiResult(200, {}, {}, "", True))
assert reviewer_bot.release_state_issue_lease_lock() is True
assert reviewer_bot.ACTIVE_LEASE_CONTEXT is None
def test_release_lock_fails_closed_on_conflicting_token(monkeypatch):
context = reviewer_bot.LeaseContext(
lock_token="token-123",
lock_owner_run_id="run",
lock_owner_workflow="workflow",
lock_owner_job="job",
state_issue_url="https://example.com/issues/314",
lock_ref="refs/heads/reviewer-bot-state-lock",
lock_expires_at="2999-01-01T00:00:00+00:00",
)
monkeypatch.setattr(reviewer_bot, "ACTIVE_LEASE_CONTEXT", context)
monkeypatch.setattr(reviewer_bot, "get_lock_ref_snapshot", lambda: ("new-ref", "tree", {"lock_state": "locked", "lock_token": "other-token"}))
assert reviewer_bot.release_state_issue_lease_lock() is False
assert reviewer_bot.ACTIVE_LEASE_CONTEXT is None
def test_schedule_guard_blocks_empty_active_reviews_wipe(monkeypatch):
monkeypatch.setenv("EVENT_NAME", "schedule")
monkeypatch.setenv("EVENT_ACTION", "")
monkeypatch.setattr(reviewer_bot, "acquire_state_issue_lease_lock", lambda: None)
monkeypatch.setattr(reviewer_bot, "release_state_issue_lease_lock", lambda: True)
state = make_state()
state["active_reviews"] = {
"42": {
"current_reviewer": "alice",
"assigned_at": "2026-01-01T00:00:00+00:00",
"last_reviewer_activity": "2026-01-01T00:00:00+00:00",
}
}
def wipe_active_reviews(input_state):
input_state["active_reviews"] = {}
return True
save_called = {"value": False}
def track_save(_state):
save_called["value"] = True
return True
monkeypatch.setattr(reviewer_bot, "load_state", lambda *args, **kwargs: state)
monkeypatch.setattr(reviewer_bot, "process_pass_until_expirations", lambda current: (current, []))
monkeypatch.setattr(reviewer_bot, "sync_members_with_queue", lambda current: (current, []))
monkeypatch.setattr(reviewer_bot, "handle_scheduled_check", wipe_active_reviews)
monkeypatch.setattr(reviewer_bot, "save_state", track_save)
with pytest.raises(SystemExit) as excinfo:
reviewer_bot.main()
assert excinfo.value.code == 1
assert save_called["value"] is False