Skip to content

Commit 7b03ec9

Browse files
committed
test: align closed arrival expectations
1 parent 33d0db8 commit 7b03ec9

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

tests/integration/reviewer_bot/test_app_closed_issue_cleanup.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
pytestmark = pytest.mark.integration
99

1010

11-
def test_execute_run_closed_issue_comment_cleanup_persists_removed_review_entry(monkeypatch):
11+
def test_execute_run_closed_issue_comment_safe_noop_keeps_lifecycle_cleanup_owner(monkeypatch):
1212
harness = AppHarness(monkeypatch)
1313
harness.set_event(
1414
EVENT_NAME="issue_comment",
@@ -52,9 +52,9 @@ def fake_load_state(*, fail_on_unavailable=False):
5252
result = harness.run_execute()
5353

5454
assert result.exit_code == 0
55-
assert save_calls == [False]
55+
assert save_calls == []
5656
assert len(sync_calls) == 1
57-
assert sync_calls[0][0] is reloaded_state
57+
assert sync_calls[0][0] is initial_state
5858
assert sync_calls[0][1] == [42]
5959

6060
def test_execute_run_closed_issue_comment_without_entry_skips_save(monkeypatch):
@@ -94,7 +94,7 @@ def test_execute_run_closed_issue_comment_without_entry_skips_save(monkeypatch):
9494
assert sync_calls == [[42]]
9595

9696

97-
def test_execute_run_late_workflow_run_reconcile_does_not_recreate_removed_review_entry(monkeypatch):
97+
def test_execute_run_late_workflow_run_reconcile_missing_row_safe_noop(monkeypatch):
9898
harness = AppHarness(monkeypatch)
9999
harness.set_workflow_run_name("Reviewer Bot PR Comment Router")
100100
harness.set_event(
@@ -135,7 +135,7 @@ def test_execute_run_late_workflow_run_reconcile_does_not_recreate_removed_revie
135135

136136
result = harness.run_execute()
137137

138-
assert result.exit_code == 1
138+
assert result.exit_code == 0
139139
assert state["active_reviews"] == {}
140140
assert save_called["value"] is False
141141
assert sync_calls == []

0 commit comments

Comments
 (0)