|
| 1 | +# **Coding Guidelines Subcommittee Meeting on 2025-12-03 @ 0800 UTC / 0900 CET / 1700 JST / 0300 EST** |
| 2 | + |
| 3 | +[Link](https://www.worldtimebuddy.com/?qm=1&lid=14,12,1850147,5&h=14&date=2025-12-3&sln=8-9&hf=1) to meeting time in common time zones. |
| 4 | + |
| 5 | +| Search Key | Description | |
| 6 | +| :---- | :---- | |
| 7 | +| \[todo\] | Action Item | |
| 8 | +| \[decision\] | Something decided on | |
| 9 | +| \[important\] | Key information | |
| 10 | + |
| 11 | +## **Agenda** |
| 12 | + |
| 13 | +1. Solicitation of notetaker |
| 14 | +2. Acceptance of [Previous Meeting Minutes](https://github.com/rustfoundation/safety-critical-rust-consortium/blob/main/subcommittee/coding-guidelines/meetings/2025-11-26/minutes.md) |
| 15 | +3. Introduction of new members |
| 16 | +4. “Reviewer circle” |
| 17 | + * Volunteers to go on a list of assignable reviewers |
| 18 | + * If you want a PR reviewed for you, you could review the next one |
| 19 | + * New policy: correct \> complete |
| 20 | +5. Merging of [https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/149](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/149) has happened |
| 21 | + * Have a read on GOALS.md, README.md and CONTRIBUTING.md and think about valuable additions and clarifications |
| 22 | + * Please start incorporating updates (e.g. from review comments) as separate PRs |
| 23 | +6. Focused PR reviews |
| 24 | + * “Seacord’s Section”: |
| 25 | + * [https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/234](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/234) |
| 26 | + * [https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/220](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/220) |
| 27 | + * [https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/232](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/232) |
| 28 | + * Promoted issues: |
| 29 | + * [https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/225](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/225/files) |
| 30 | +7. Proposals and ideas for new rules |
| 31 | + * Idea: Give room for the optional step 0 in our contributing guideline, aka "round table for new rules". |
| 32 | +8. Grooming of rule issues \- promote to PRs if appropriate |
| 33 | +9. Round table |
| 34 | + |
| 35 | +## **Check-in area** |
| 36 | + |
| 37 | +**Please add your name, and an emoji that describes your day.** |
| 38 | + |
| 39 | +* Markus Hosch 🍀 |
| 40 | +* Alex Celeste ☕ |
| 41 | +* Tiago Manczak |
| 42 | +* Oreste Bernardi |
| 43 | +* Achim Kriso |
| 44 | +* Christof Petig 🥣 |
| 45 | +* X |
| 46 | +* X |
| 47 | + |
| 48 | +**Notetaker:** |
| 49 | + |
| 50 | +* Markus Hosch |
| 51 | + |
| 52 | +For tips on how we take notes in the Safety-Critical Rust Consortium, please see the [Meeting Notetaker Role](https://github.com/rustfoundation/safety-critical-rust-consortium/blob/main/docs/notetaker-role.md) doc. |
| 53 | + |
| 54 | +## **Housekeeping section** |
| 55 | + |
| 56 | +* Document space: [coding-guidelines](https://github.com/rustfoundation/safety-critical-rust-consortium/tree/main/subcommittee/coding-guidelines) |
| 57 | +* Zulip: [safety-critical-consortium: Coding Guidelines](https://rust-lang.zulipchat.com/#narrow/channel/445688-safety-critical-consortium/topic/Coding.20Guidelines) |
| 58 | +* [Kanban board](https://github.com/orgs/rustfoundation/projects/1/views/3) |
| 59 | + * [`contributor experience`](https://github.com/orgs/rustfoundation/projects/1/views/4) view |
| 60 | + * [`coding guideline`](https://github.com/orgs/rustfoundation/projects/1/views/5) view |
| 61 | + |
| 62 | +## **Tasks** |
| 63 | + |
| 64 | +* Minutes from 2025-11-19 need to be updated |
| 65 | +* Can only accept minutes from a slot everybody actually attended |
| 66 | +* Reviewer list to be written down either as a membership-style list or as a GitHub automation |
| 67 | +* Fix non-unique IDs on [https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/220](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/220) |
| 68 | +* Check whether non-unique IDs would be detected by CI |
| 69 | +* Merge [https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/232](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/232) |
| 70 | +* Figure out how to cross-reference rules inline (e.g. to refer to a title without literally repeating it). Exercise on an open PR |
| 71 | +* Emphasize the MISRA, CERT, Clippy etc work so that people check on Zulip whether there is already something in the works that watches their guideline suggestion |
| 72 | + |
| 73 | +## **Meeting Minutes** |
| 74 | + |
| 75 | +* Not accepting the meeting from 2025-11-19, PR needs to be updated, see [https://github.com/rustfoundation/safety-critical-rust-consortium/pull/510](https://github.com/rustfoundation/safety-critical-rust-consortium/pull/510) \[TODO: Markus H.\] |
| 76 | +* Check for the meeting minutes from the NA/Pacific meeting \[TODO: ??\] |
| 77 | +* No new members |
| 78 | +* Call for volunteers for PR reviewers |
| 79 | +* Would we want to make all Producers to be reviewer? If no, we need to add another list of reviewers. We might also make Github auto-assign people to new PRs. \[TODO\] |
| 80 | +* Correct \> complete → We should actually formalize this a bit, so that it’s clear that a small but correct piece of content for each chapter is enough to get stuff merged. |
| 81 | +* Reviewing [https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/220](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/220) |
| 82 | + * Maybe too many compliant examples? We might want to create an issue to reduce the number of examples to make the rule easier to comprehend |
| 83 | + * Q: Does every subsection also have a state? → Yes, that’s how thie guidelines were designed |
| 84 | + * Q: How do compiler flags influence the rule? → Seems there were some out-of-band discussions to avoid panics/aborts. We might want to consider compiler flags in the future |
| 85 | + * Examples have the same ID from the examples, which is unintentional. Needs to be fixed before PR merge. Would CI see that? \[TODO: Alex or David: Update PR to use unique IDs\] |
| 86 | + * PR can be merged after ID update |
| 87 | +* Review [https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/232](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/232) |
| 88 | + * We might want to enable the tooling to refer to the title by link instead of repeating |
| 89 | + * Having links inline makes the source harder to read → Do we want to add this to the guidelines as a general rule? |
| 90 | + * Otherwise approved |
| 91 | +* Review [https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/234](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/pull/234) |
| 92 | + * Rule gets “reused” → We should not do that but create new rule, with the old rule being deprecated |
| 93 | + * We might want to also support linking deprecated rules to other rules that replace the now-deprecated rule → Could be implemented by the rules linking facility used for subset vs defect. \[TODO: Markus H.\] |
| 94 | + * Content is fine, though, we will progress with the merge once the rule has been turned into a new one. |
| 95 | +* Round table |
| 96 | + * We would want to coordinate rule work by also using Zulip to find out whether someone else is working on that, e.g. because a similar rule is inside MISRA, CERT etcpp |
| 97 | + * Same story for clippy lints. One could work on lints, but coordinating might still be beneficial to avoid double work. |
| 98 | + * We might want to link that to the reviewer circle? |
| 99 | + |
| 100 | +## **Material** |
| 101 | + |
| 102 | +Any material to read before the meeting should be included here. |
| 103 | + |
| 104 | +* Milestone: [Prepare for launch to wider Rust community](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/milestone/1) |
| 105 | +* FLS Maintenance: [FLS Team \- North Star](https://hackmd.io/@plevasseur/HJb6qomOge/edit) |
| 106 | +* [Github Issue to discuss about panicking in Safety Critical](https://github.com/rustfoundation/safety-critical-rust-coding-guidelines/issues/158) |
| 107 | + |
0 commit comments