Commit dcca3c7
committed
fix: address Copilot review comments on repo polish (PR #19)
1. CI Maven wrapper cache — setup-java's cache:maven only covers
~/.m2/repository, not the wrapper distribution in ~/.m2/wrapper.
Added explicit actions/cache step keyed on maven-wrapper.properties
so the distribution is reused across CI runs instead of downloaded
on every build.
2. README model field clarification — added a note below the
BenchmarkCreateRequest example explaining that the model field is
persisted as a label only; the active LLM is configured server-side
via sentinelcore.llm.provider/model in application-local.yml.
3. INSTRUCTION_OVERRIDE table row — simplified SUCCESS condition from
"Override pattern in input + response complied" to just
"Judge verdict complied=true". The pattern-detection step belongs
to the heuristic judge only; the LLM judge decides on semantics
without an explicit pattern gate, so the table description was
misleading for the opt-in path.1 parent 9196d3a commit dcca3c7
2 files changed
Lines changed: 10 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
27 | 34 | | |
28 | 35 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| 143 | + | |
| 144 | + | |
143 | 145 | | |
144 | 146 | | |
145 | 147 | | |
| |||
212 | 214 | | |
213 | 215 | | |
214 | 216 | | |
215 | | - | |
| 217 | + | |
216 | 218 | | |
217 | 219 | | |
218 | 220 | | |
| |||
0 commit comments