Fix MSRV 1.70 compatibility for Error::other()

std::io::Error::other() was stabilized in Rust 1.74, so revert to
Error::new(ErrorKind::Other, ...) and allow the clippy::io_other_error
lint at the crate level.

Author: mrpollo

src/full_parser/mod.rs

@@ -44,7 +44,7 @@ pub fn read_file(file_path: &str) -> Result<ParsedData, std::io::Error> {
         }
         parser
             .consume_bytes(&buf[READ_START..(READ_START + num_bytes_read)])
-            .map_err(|e| std::io::Error::other(format!("err: {:?}", e)))?;
+            .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, format!("err: {:?}", e)))?;
         file_position += num_bytes_read as u64;
     }
 
@@ -76,7 +76,7 @@ pub fn read_file(file_path: &str) -> Result<ParsedData, std::io::Error> {
             }
             parser
                 .consume_bytes(&buf[READ_START..(READ_START + num_bytes_read)])
-                .map_err(|e| std::io::Error::other(format!("err: {:?}", e)))?;
+                .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, format!("err: {:?}", e)))?;
             section_position += num_bytes_read as u64;
         }
     }

src/lib.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::io_other_error)]
+
 pub mod full_parser;
 pub mod stream_parser;
 pub mod unpack;

src/stream_parser/file_reader.rs

@@ -1262,7 +1262,7 @@ pub fn read_file_with_simple_callback<CB: FnMut(&Message) -> SimpleCallbackResul
         }
         log_parser
             .consume_bytes(&buf[READ_START..(READ_START + num_bytes_read)])
-            .map_err(|e| std::io::Error::other(format!("err: {:?}", e)))?;
+            .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, format!("err: {:?}", e)))?;
         total_bytes_read += num_bytes_read;
         file_position += num_bytes_read as u64;
     }
@@ -1305,7 +1305,7 @@ pub fn read_file_with_simple_callback<CB: FnMut(&Message) -> SimpleCallbackResul
             }
             log_parser
                 .consume_bytes(&buf[READ_START..(READ_START + num_bytes_read)])
-                .map_err(|e| std::io::Error::other(format!("err: {:?}", e)))?;
+                .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, format!("err: {:?}", e)))?;
             total_bytes_read += num_bytes_read;
             section_position += num_bytes_read as u64;
         }

src/unpack/mod.rs

@@ -1,4 +1,4 @@
-use std::io::{Error, Result};
+use std::io::{Error, ErrorKind, Result};
 use std::iter::*;
 
 /// Convert a array of eight u8 elements into a u64
@@ -84,5 +84,5 @@ pub fn as_f32_le(arr: &[u8]) -> f32 {
 /// assert_eq!(unpack::as_str(&arr).unwrap(), "Hello");
 /// ```
 pub fn as_str(arr: &[u8]) -> Result<&str> {
-    std::str::from_utf8(arr).map_err(|_| Error::other("data is not a string"))
+    std::str::from_utf8(arr).map_err(|_| Error::new(ErrorKind::Other, "data is not a string"))
 }