Skip to content
This repository was archived by the owner on Jul 8, 2019. It is now read-only.

Commit b5f620d

Browse files
authored
Fix #103 - specify bug and vuln types against applicable rules (#109)
* Update rules to match most recent tslint * Adding debtTypes to rules
1 parent 18acd35 commit b5f620d

File tree

7 files changed

+258
-21
lines changed

7 files changed

+258
-21
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<groupId>com.pablissimo.sonar</groupId>
66
<artifactId>sonar-typescript-plugin</artifactId>
77
<packaging>sonar-plugin</packaging>
8-
<version>1.0.0-RC1</version>
8+
<version>1.0.0-RC2</version>
99

1010
<name>TypeScript</name>
1111
<description>Analyse TypeScript projects</description>

src/main/java/com/pablissimo/sonar/TsLintExecutorImpl.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,6 @@ else if (files == null) {
144144
LOG.debug("Split " + files.size() + " files into " + batches.size() + " batches for processing");
145145

146146
for (int i = 0; i < batches.size(); i++) {
147-
StringBuilder outputBuilder = new StringBuilder();
148-
149147
List<String> thisBatch = batches.get(i);
150148

151149
Command thisCommand = getBaseCommand(config, tslintOutputFilePath);

src/main/java/com/pablissimo/sonar/TsLintParserImpl.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@
1414
import com.pablissimo.sonar.model.TsLintIssue;
1515

1616
@BatchSide
17-
public class TsLintParserImpl implements TsLintParser {
18-
private static final Logger LOG = LoggerFactory.getLogger(TsLintParserImpl.class);
19-
17+
public class TsLintParserImpl implements TsLintParser {
2018
public Map<String, List<TsLintIssue>> parse(List<String> toParse) {
2119
GsonBuilder builder = new GsonBuilder();
2220
Gson gson = builder.create();

src/main/java/com/pablissimo/sonar/TsLintSensor.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,11 @@
99
import org.sonar.api.batch.sensor.SensorDescriptor;
1010
import org.sonar.api.batch.sensor.issue.NewIssue;
1111
import org.sonar.api.batch.sensor.issue.NewIssueLocation;
12-
import org.sonar.api.batch.fs.FileSystem;
1312
import org.sonar.api.batch.fs.InputFile;
1413
import org.sonar.api.config.Settings;
1514
import org.sonar.api.rule.RuleKey;
1615

1716
import java.io.File;
18-
import java.io.IOException;
19-
import java.nio.file.Files;
20-
import java.nio.file.Path;
21-
import java.nio.file.Paths;
2217
import java.util.*;
2318

2419
public class TsLintSensor implements Sensor {

src/main/java/com/pablissimo/sonar/TsRulesDefinition.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ public static void loadRules(InputStream stream, List<TsLintRule> rulesCollectio
128128
ruleDescription
129129
);
130130
}
131-
131+
132132
rulesCollection.add(tsRule);
133133
}
134134

@@ -203,7 +203,7 @@ public void define(Context context) {
203203
for (TsLintRule customRule : tslintRules) {
204204
createRule(repository, customRule);
205205
}
206-
206+
207207
repository.done();
208208
}
209209

0 commit comments

Comments
 (0)