Skip to content

disableTraps() vs revoke() #37

Open
@warpech

Description

@warpech

It is not clear to me what's the point of having the two public methods disableTraps() and revoke(). In the tests, they are always tested separately.

In real life usage, shouldn't I use both of them?

If it was up to me, I would merge these methods into one. But maybe I am missing something.

I checked if they are used in Palindrom and they are not.

cc @alshakero, @tomalec.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions