Skip to content

Filtering out non-significiant changes Palindrom behavior #58

Open
@tomalec

Description

@tomalec

@warpech, @eriksunsol #45 changes Palindrom behavior in respect of numbers > Number.MAX_SAFE_INTEGER.
This change checks that Number.MAX_SAFE_INTEGER == Number.MAX_SAFE_INTEGER +1 // true and do not emit a patch, therefore such error is not cough by Palindrom's validation.
And the tests that are failing are:

HTTP :
WebSocket:
Outgoing patch: out of range numbers should call onOutgoingPatchValidationError event with a RangeError

WDYT of

  1. adding Number range validation to JSONPatcherProxy?
  2. Removing Range validation for outgoing patches from Palindrom?

as I cannot think of any other solution.

You can check the behavior at https://github.com/Palindrom/Palindrom/compare/update-deps?expand=1
https://travis-ci.org/Palindrom/Palindrom/builds/581106763

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions