Updated guidelines pr (#113)

* Updated CodeRabbit test. Added PR filtering

* Added PR filtering

* Added PR filtering v2

* Added PR issue filter user list

* Fixed CodeRabbit Check. Added No Issue PR Check 1764267502

Author: palisadoes

.github/workflows/config/check-pr-issue-skip-usernames.txt

@@ -0,0 +1,2 @@
+palisadoes
+noman2002

.github/workflows/pull-request-review.yml

@@ -24,8 +24,11 @@ jobs:
             });
 
             // Filter reviews that have a user login containing "coderabbit" (case-insensitive)
+            // and exclude COMMENTED states.
             const codeRabbitReviews = reviews.filter(review => 
-              review.user.login.toLowerCase().includes('coderabbit') || review.user.login.toLowerCase().includes('coderabbitai')
+              (review.user.login.toLowerCase().includes('coderabbit') || 
+              review.user.login.toLowerCase().includes('coderabbitai')) &&
+              review.state !== 'COMMENTED'
             );
 
             // Fail if no CodeRabbit reviews are found

.github/workflows/pull-request-target.yml

@@ -3,16 +3,22 @@
 #
 # NOTE!
 #
-# Please read the README.md file in this directory that defines what should 
+# Please read the README.md file in this directory that defines what should
 # be placed in this file
 #
 ##############################################################################
 ##############################################################################
 
 name: PR Target Workflow
-on: 
+on:
   pull_request_target:
-  
+
+# Required for arkid15r/check-pr-issue-action
+permissions:
+  contents: read
+  issues: read
+  pull-requests: write
+
 jobs:
   PR-Greeting:
     name: Pull Request Target
@@ -24,53 +30,28 @@ jobs:
           comment-tag: pr_review_policy
           message: |
             ## Our Pull Request Approval Process
-            
-            Thanks for contributing! 
-            
-            ### Testing Your Code
-            Remember, your PRs won't be reviewed until these criteria are met:
-
-            1. We don't merge PRs with poor code quality. 
-                1. Follow coding best practices such that CodeRabbit.ai approves your PR.
-            1. We don't merge PRs with failed tests. 
-                1. When tests fail, click on the `Details` link to learn more.
-                1. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
-                1. Tests may fail if you edit sensitive files. Ask to add the `ignore-sensitive-files-pr` label if the edits are necessary.
-            1. We cannot merge PRs with conflicting files. These must be fixed.
-                
-            Our policies make our code better.
-
-            ### Reviewers
-
-            Do not assign reviewers. Our Queue Monitors will review your PR and assign them. 
-            When your PR has been assigned reviewers contact them to get your code reviewed and approved via:
-
-            1. comments in this PR or
-            1. our slack channel
-
-            #### Reviewing Your Code
-
-            Your reviewer(s) will have the following roles:
 
-            1.  arbitrators of future discussions with other contributors about the validity of your changes
-            2.  point of contact for evaluating the validity of your work
-            3.  person who verifies matching issues by others that should be closed.
-            4.  person who gives general guidance in fixing your tests
+            This PR will be reviewed according to the [Palisadoes Contributing Guidelines](https://developer.palisadoes.org/docs/contributor-guide/contributing) 
 
-            ### CONTRIBUTING.md
-
-            Read our CONTRIBUTING.md file. Most importantly:
-
-            1. PRs with issues not assigned to you will be closed by the reviewer
-            1. Fix the first comment in the PR so that each issue listed automatically closes
-
-            ### Other
-
-            1. :dart: Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
-            2. Read the CONTRIBUTING.md file make 
+            Thanks for contributing!
 
       - name: Greeting Message to User
-        uses: actions/first-interaction@v1
+        uses: actions/first-interaction@v3
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
-          pr-message: "Congratulations on making your first PR! :confetti_ball: If you haven't already, check out our [Contributing Guidelines](https://github.com/PalisadoesFoundation/talawa-admin/blob/-/CONTRIBUTING.md) and [PR Reporting Guidelines](https://github.com/PalisadoesFoundation/talawa-admin/blob/-/PR_GUIDELINES.md) to ensure that you are following our guidelines for contributing and creating PR."
+          pr-message: 'Congratulations on making your first PR!'
+
+  Check-PR-Issue:
+    runs-on: ubuntu-latest
+    needs: [PR-Greeting]
+    steps:
+      - uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3
+      - name: Check PR linked issue and assignee
+        uses: arkid15r/check-pr-issue-action@f2c2ac3b8c73b5da96294af9ac3ec174098cf513
+        with:
+          close_pr_on_failure: 'true'
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          no_assignee_message: 'The linked issue must be assigned to the PR author.'
+          no_issue_message: 'The PR must be linked to an issue assigned to the PR author.'
+          require_assignee: 'true'
+          skip_users_file_path: '.github/workflows/config/check-pr-issue-skip-usernames.txt'

docs/contributor-guide/pr-guidelines.md

@@ -62,6 +62,17 @@ If you are concerned that a larger design will be lost in a string of small PRs,
 
 Note all commits in a PR are squashed when merged to the main branch so there is one commit per PR after merge.
 
+## The Role of Reviewers
+
+Your reviewer(s) will have the following roles:
+
+1.  arbitrators of future discussions with other contributors about the validity of your changes
+2.  point of contact for evaluating the validity of your work
+3.  person who verifies matching issues by others that should be closed.
+4.  person who gives general guidance in fixing your tests
+
+Please follow thier advice and discuss the rationale if you feel the requests are not in the best long term interest of the code base or don't meet any best practices.
+
 ## Pull Request Best Practices
 
 In order to give everyone a chance to submit a pull request and contribute to our repositories please be aware of the guidelines we abide by:
@@ -74,7 +85,11 @@ In order to give everyone a chance to submit a pull request and contribute to ou
 1. Do not start working on any open issue and raise a PR unless the issue is assigned to you. PRs that don't meet these guidelines will be closed.
 
 1. All pull requests must have test units.
-   - Valid tests must cover at least 95% of the submitted code and 100% is preferred. If, for some reason, it is not possible to add tests, please let us know and explain why. In that case, you'll need to tell us what steps you followed to manually test your changes.
+   1. Valid tests must cover at least 95% of the submitted code and 100% is preferred. If, for some reason, it is not possible to add tests, please let us know and explain why. In that case, you'll need to tell us what steps you followed to manually test your changes.
+
+   2. We don't merge PRs with failed tests. When tests fail, click on the `Details` link of the test to learn more.
+
+   3. Tests may fail if you edit sensitive files. Ask to add the `ignore-sensitive-files-pr` label if the edits are necessary.
 
 1. [Use this method to automatically close the issue when the PR is completed.](https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue)