-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Labels
cleanupRemove non-functional or unnecessary codeRemove non-functional or unnecessary coderefactorRefactoring tasksRefactoring tasksunapproved
Description
Context
As part of the repository-wide translation compliance cleanup (post #7364), this batch focuses on Recurrence-related and EventForm shared components that are currently passing t as a prop instead of calling useTranslation() locally.
These components are reused across multiple screens, so refactoring must be done carefully to avoid regressions.
Affected Files
- src/shared-components/EventForm/EventForm.tsx
- src/shared-components/EventForm/RecurrenceDropdown/RecurrenceDropdown.tsx
- src/shared-components/EventForm/utils/recurrenceOptions.ts
- src/shared-components/Recurrence/CustomRecurrenceModal.tsx
- src/shared-components/Recurrence/RecurrenceEndOptionsSection.tsx
- src/shared-components/Recurrence/RecurrenceFrequencySection.tsx
- src/shared-components/Recurrence/RecurrenceMonthlySection.tsx
- src/shared-components/Recurrence/RecurrenceWeeklySection.tsx
- src/shared-components/Recurrence/RecurrenceYearlySection.tsx
Required Refactor
For each affected file:
- Remove
tfrom props and parameters - Eliminate any
tprop drilling chains - Import
useTranslationfromreact-i18next - Call
const { t } = useTranslation()locally - Ensure correct namespace usage
- Update related tests and mocks where necessary
No UI, recurrence logic, or form behavior should change as part of this refactor.
Acceptance Criteria
- No component in this batch receives
tas a prop - All translation calls originate from local
useTranslation() - Recurrence logic remains functionally identical
- Tests pass without regression or flakiness
- Translation lint checks pass in CI
- Changes are strictly limited to Recurrence and EventForm domain
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
cleanupRemove non-functional or unnecessary codeRemove non-functional or unnecessary coderefactorRefactoring tasksRefactoring tasksunapproved
Type
Projects
Status
Backlog