fix: Test command actually implemented properly

Author: adambaumeister

filter_plugins/custom_filters.py

@@ -1,4 +1,5 @@
 import json
+from json import JSONDecodeError
 from xml.etree.ElementTree import fromstring
 from typing import Union
 
@@ -69,6 +70,9 @@ def panos_op_policy_match_result_to_bool(self, data: Union[list, dict]) -> bool:
         for op_result in data:
             stdout = op_result.get("stdout")
             if stdout:
-                stdout = json.loads(stdout)
+                try:
+                    stdout = json.loads(stdout)
+                except JSONDecodeError:
+                    return False
                 if stdout.get("response").get("result"):
                     return True

playbooks/orchestrator/add_policy.yml

@@ -79,19 +79,23 @@
       ansible.builtin.include_tasks:
         file: new/lookup_policy.yml
 
-    - name: RULE creation
-      ansible.builtin.include_tasks:
-        file: new/create_policy.yml
-
-    - name: Update that the config has changed
-      ansible.builtin.set_fact:
-        config_changed: true
+    - name: Create Rule Block
+      block:
+      - name: RULE creation
+        ansible.builtin.include_tasks:
+          file: new/create_policy.yml
+
+      - name: Update that the config has changed
+        ansible.builtin.set_fact:
+          config_changed: true
+      when:
+        - not matches_existing_policy
 
   when:
     - not policy_match
-    - source_ip
-    - destination_ip
-    - application
+    - source_ip is defined and source_ip != ""
+    - destination_ip is defined and destination_ip != ""
+    - application is defined and application != ""
 
 
 - name: Commit Block - Triggers on any change

playbooks/orchestrator/preset/user_outbound_policy.yml

@@ -10,4 +10,4 @@
     device_group: Lab # Finally, we set the device group!
   when:
     - "source_ip is defined or source_user is defined"
-    - url is defined
+    - url is defined and url != None