Pull spring-projects#34809: RemoveUnusedPrivateFields

Author: Vincent Potucek

init.gradle

@@ -0,0 +1,30 @@
+initscript {
+    repositories {
+        maven { url "https://plugins.gradle.org/m2" }
+    }
+    dependencies { classpath("org.openrewrite:plugin:7.2.1") }
+}
+rootProject {
+    plugins.apply(org.openrewrite.gradle.RewritePlugin)
+    dependencies {
+        rewrite("org.openrewrite.recipe:rewrite-migrate-java:3.4.0")
+    }
+    rewrite {
+//        activeRecipe("org.openrewrite.java.migrate.UpgradeToJava17")
+//        activeRecipe("org.openrewrite.java.migrate.UpgradeToJava21")
+//        activeRecipe("org.openrewrite.java.migrate.lang.var.UseVarForObject")
+//        activeRecipe("org.openrewrite.java.migrate.lang.var.UseVarForPrimitive")
+//        activeRecipe("org.openrewrite.staticanalysis.FinalizeLocalVariables")
+//        activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedLocalVariables")
+        activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedPrivateFields")
+//        activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods")
+        setExportDatatables(true)
+    }
+    afterEvaluate {
+        if (repositories.isEmpty()) {
+            repositories {
+                mavenCentral()
+            }
+        }
+    }
+}

spring-core/src/test/java/org/springframework/core/BridgeMethodResolverTests.java

@@ -802,8 +802,6 @@ public static class GenericBroadcasterImpl implements Broadcaster {
 	public abstract static class GenericEventBroadcasterImpl<T extends Event>
 			extends GenericBroadcasterImpl implements EventBroadcaster {
 
-		private Class<T>[] subscribingEvents;
-
 		private Channel<T> channel;
 
 		/**

spring-expression/src/test/java/org/springframework/expression/spel/testresources/Inventor.java

@@ -37,7 +37,6 @@ public class Inventor {
 	public String publicName;
 	private PlaceOfBirth placeOfBirth;
 	private Date birthdate;
-	private int sinNumber;
 	private String nationality;
 	private String[] inventions;
 	public String randomField;

spring-oxm/src/test/java/org/springframework/oxm/jaxb/Jaxb2MarshallerTests.java

@@ -377,15 +377,11 @@ public jakarta.xml.bind.Unmarshaller createUnmarshaller() {
 	@XmlRootElement
 	@SuppressWarnings("unused")
 	public static class DummyRootElement {
-
-		private DummyType t = new DummyType();
 	}
 
 	@XmlType
 	@SuppressWarnings("unused")
 	public static class DummyType {
-
-		private String s = "Hello";
 	}
 
 	@SuppressWarnings("unused")

spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandler.java

@@ -53,7 +53,6 @@
 import org.springframework.util.StringUtils;
 import org.springframework.util.StringValueResolver;
 import org.springframework.web.HttpRequestHandler;
-import org.springframework.web.accept.ContentNegotiationManager;
 import org.springframework.web.context.request.ServletWebRequest;
 import org.springframework.web.context.support.ServletContextResource;
 import org.springframework.web.cors.CorsConfiguration;
@@ -123,8 +122,6 @@ public class ResourceHttpRequestHandler extends WebContentGenerator
 
 	private @Nullable ResourceRegionHttpMessageConverter resourceRegionHttpMessageConverter;
 
-	private @Nullable ContentNegotiationManager contentNegotiationManager;
-
 	private final Map<String, MediaType> mediaTypes = new HashMap<>(4);
 
 	private @Nullable CorsConfiguration corsConfiguration;