Skip to content

Commit 911db91

Browse files
committed
fix: use native titles on interactive elements, keep JS tooltips for non-clickable hints
1 parent caa9a22 commit 911db91

3 files changed

Lines changed: 6 additions & 9 deletions

File tree

src/panel/components/StaffRow.svelte

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
type="button"
77
class="btn btn-link px-2"
88
data-bs-toggle="dropdown"
9-
use:tooltip={[$_('common.actions') || 'Actions']}
9+
title={$_('common.actions') || 'Actions'}
1010
aria-label={$_('common.actions') || 'Actions'}>
1111
<span class="fas fa-ellipsis-v"></span>
1212
</button>
@@ -34,7 +34,7 @@
3434
type="button"
3535
class="btn btn-link p-1 focus-ring rounded-pill d-inline-flex align-items-center gap-2 text-decoration-none"
3636
on:click={() => onEdit(member)}
37-
use:tooltip={[$_('common.edit')]}>
37+
title={$_('common.edit')}>
3838
{#if member.avatarUrl}
3939
<img
4040
src={member.avatarUrl}
@@ -67,7 +67,6 @@
6767

6868
<script>
6969
import { _ } from '../../main';
70-
import tooltip from '@panomc/sdk/utils/tooltip';
7170
7271
export let member;
7372
export let onEdit;

src/panel/modals/AddEditStaffModal.svelte

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
type="button"
125125
class="btn-close"
126126
on:click={() => removeSocial(i)}
127-
use:tooltip={[$_('common.remove')]}
127+
title={$_('common.remove')}
128128
aria-label={$_('common.remove')}>
129129
</button>
130130
</div>
@@ -214,7 +214,6 @@
214214
import { _ } from '../../main';
215215
import ApiUtil from '@panomc/sdk/utils/api';
216216
import { showToast } from '@panomc/sdk/toasts';
217-
import tooltip from '@panomc/sdk/utils/tooltip';
218217
219218
let saving = false;
220219

src/theme/components/StaffList.svelte

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
href={url.startsWith('http') ? url : '#'}
4444
target="_blank"
4545
class="btn btn-sm btn-link link-secondary"
46-
use:tooltip={[platform]}
46+
title={platform}
4747
aria-label={platform}>
4848
<i class={getSocialIcon(platform)}></i>
4949
</a>
@@ -73,7 +73,7 @@
7373
href={url.startsWith('http') ? url : '#'}
7474
target="_blank"
7575
class="social-link"
76-
use:tooltip={[platform]}
76+
title={platform}
7777
aria-label={platform}>
7878
<i class={getSocialIcon(platform)}></i>
7979
</a>
@@ -103,7 +103,7 @@
103103
href={url.startsWith('http') ? url : '#'}
104104
target="_blank"
105105
class="text-white opacity-75 hover-opacity-100"
106-
use:tooltip={[platform]}
106+
title={platform}
107107
aria-label={platform}>
108108
<i class={getSocialIcon(platform)}></i>
109109
</a>
@@ -119,7 +119,6 @@
119119
<script>
120120
import { _ } from '../../main';
121121
import { NoContent } from '@panomc/sdk/components/theme';
122-
import tooltip from '@panomc/sdk/utils/tooltip';
123122
124123
export let staff = [];
125124
export let viewMode = 'CARD';

0 commit comments

Comments
 (0)