Use a proper thread pool in ServerLoginPacketListenerImpl and MCUtil #8798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahvdAa
requested changes
Jan 18, 2023
There was a problem hiding this comment.
Try to avoid reformatting these large blocks to keep the diff small :)
This should probably also go into the original patch.
|
|
Are you still planning on moving forward with this ? I don't recall the dhrama discussion about it but I'd close this otherwise. |
|
Closing this given it has gone rather stale 😓 (love you egg <3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8797
An arbitrary-ish number of 1024 was chosen for the bounded queue size.
The asyncExecutor in MCUtil was left unbounded.